Thank you WNW

__________________

Quick Elite Links:TSD Elite Manual Trading | TSD Portfolio | Quick Links: TSD Calendar | Suggestions to improve the forum

I found some interesting indicator.
Author is KimIV.
It is his website.

i-SignalOfTrade indicator.
Download from here (WinRar archive).

This indicator will signal to you about any trading events on your account: open the order, modify the order, hit stop loss or take profit, and so on. Just anything.
It will signal you by the following ways:

UseAlert=True - by alert in the window.
UseComment=True - comments on the chart.
UsePrint=False - write in log file.
UseSendMail=False - by email.
UseSound=True - by sound

12s.jpg

12s1.jpg

12s2.jpg

12s3.jpg

I've seen EA/Scripts that close all open orders but I'm looking for and EA to close all open orders at a specified time. Anyone have an EA like this?
or can someone show me what code to change on an EA that opens orders to add code to close and order.

Thank you

EDIT: if anyone has an EA that Opens an order at a specified time then closes the order at another time can someone post here please.

Hi matrixbiz

this EA open trades at specified time, but not close at specified time.

I'm looking for the same code ( close all orders at specified time ) to built in exist EA's.

May be this help

Attached Files

e-OpenByTime.mq4 (11.0 KB, 19 views)

Hi Coders

I'm still learning by copy and past, because I'm a totally newbie.

I need a function thats close all open trades at specified time.
I have try something.
Don't have any errors with compile. But with strategytester I have follow message:
Testgenerator: unmatched data error(volume limit 719 at 2008.03.27 12:30 exeeded
Testgenerator: unmatched data error(volume limit 135 at 2008.03.27 23:00 exeeded



Black thats the original code. That works
Blue thats what i i like to insert

Thanks for any help

//+-----------------------------------------------------------------------+
//| Check for close order conditions |
//+-----------------------------------------------------------------------+
void CheckForCloseConditions()
{
int ticket;

for(int i=0;i<OrdersTotal();i++)
{
if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==false ) break;
if(OrderMagicNumber()!=MAGICMA || OrderSymbol()!=Symbol()) continue;
if(OrderType()==OP_BUY)
{
if (GetSignal()==1)
{

OrderClose(OrderTicket(),OrderLots(),Bid,3,Red);
return(0);
}



}
if(OrderType()==OP_SELL)
{

if (GetSignal()==2)
{
OrderClose(OrderTicket(),OrderLots(),Ask,3,Red);
return(0);
}


}
}
return(0);
}

//+-----------------------------------------------------------------------+
//| Check for close order conditions trailing |
//+-----------------------------------------------------------------------+
void CheckForCloseConditionsTrailing()
{
int ticket;

for(int i=0;i<OrdersTotal();i++)
{
if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==false ) break;
if(OrderMagicNumber()!=MAGICMA_Trailing || OrderSymbol()!=Symbol()) continue;
if(OrderType()==OP_BUY)
{
if (GetSignal()==1)
{
OrderClose(OrderTicket(),OrderLots(),Bid,3,Red);
return(0);
}

if(TrailingStop>0)
{
if(Bid-OrderOpenPrice()>Point*TrailingStop)
{
if(OrderStopLoss()<Bid-Point*TrailingStop)
{
OrderModify(OrderTicket(),OrderOpenPrice(),Bid-Point*TrailingStop,OrderTakeProfit(),0,Red);
return(0);
}
}
}


}
if(OrderType()==OP_SELL)
{

if (GetSignal()==2)
{
OrderClose(OrderTicket(),OrderLots(),Ask,3,Red);
return(0);
}

if(TrailingStop>0)
{
if((OrderOpenPrice()-Ask)>(Point*TrailingStop))
{
if((OrderStopLoss()>(Ask+Point*TrailingStop)) || (OrderStopLoss()==0))
{
OrderModify(OrderTicket(),OrderOpenPrice(),Ask+Poi nt*TrailingStop,OrderTakeProfit(),0,Magenta);
return(0);
}
}
}

}
}
return(0);
}

//+-----------------------------------------------------------------------+
//| Start function |
//+-----------------------------------------------------------------------+

int start()

//XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX XXXXXXXXXXXXXXXXXXX

//Close Open Orders by Time

//XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX XXXXXXXXXXXXXXXXXXXX

if (UseCloseTime){
if (!(Hour()>=CloseTime && Hour()>=CloseTime)) {
Comment("Time for close trade has come !");
return(0);
} else Comment("");
}else Comment("");


{
int ticket;

for(int i=0;i<OrdersTotal();i++)
{
if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==false ) break;
if(OrderMagicNumber()!=MAGICMA || OrderSymbol()!=Symbol()) continue;
if(OrderType()==OP_BUY)
{
{

OrderClose(OrderTicket(),OrderLots(),Bid,3,Red);
return(0);
}



}
if(OrderType()==OP_SELL)
{

{
OrderClose(OrderTicket(),OrderLots(),Ask,3,Red);
return(0);
}


}
}
return(0);
}

//XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX XXXXXXXXXXXXXXXXXXXX

//Close Open Trailing Orders by Time

//XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX XXXXXXXXXXXXXXXXXXXX


if (UseCloseTime){
if (!(Hour()>=CloseTime && Hour()>=CloseTime)) {
Comment("Time for close trailing trade has come !");
return(0);
} else Comment("");
}else Comment("");




{
if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==false ) //break;
if(OrderMagicNumber()!=MAGICMA_Trailing || OrderSymbol()!=Symbol()) //continue;
if(OrderType()==OP_BUY)
{
// if (GetSignal()==1)
{
OrderClose(OrderTicket(),OrderLots(),Bid,3,Red);
return(0);
}

if(TrailingStop>0)
{
if(Bid-OrderOpenPrice()>Point*TrailingStop)
{
if(OrderStopLoss()<Bid-Point*TrailingStop)
{
OrderModify(OrderTicket(),OrderOpenPrice(),Bid-Point*TrailingStop,OrderTakeProfit(),0,Red);
return(0);
}
}
}


}
if(OrderType()==OP_SELL)
{

{
OrderClose(OrderTicket(),OrderLots(),Ask,3,Red);
return(0);
}

if(TrailingStop>0)
{
if((OrderOpenPrice()-Ask)>(Point*TrailingStop))
{
if((OrderStopLoss()>(Ask+Point*TrailingStop)) || (OrderStopLoss()==0))
{
OrderModify(OrderTicket(),OrderOpenPrice(),Ask+Poi nt*TrailingStop,OrderTakeProfit(),0,Magenta);
return(0);
}
}
}

}
}
return(0);


if(CalculateNumberOfOrders(Symbol())<1&&CalculateN umberOfOrdersTrailing(Symbol())<1)
CheckForOpenConditions();
else
{
CheckForCloseConditions();
CheckForCloseConditionsTrailing();
}


return(0);

}

How do you fix a "'CloseHour' - expression on global scope not allowed" error?

hi matrixbiz

What's mean with "global scope"? The variables in begin of script to define the parameters of indicators ect?

See attached # 1EA_Test_Template. I need this to test function of scripts.

Let it run in strategytester and it works.
Open Ea with MetaEditor and activate the inactive script after int start()
Now compile and let it run in strategytester, the EA don't trade. See the error message in journal.

Attached Files

# 1EA_Test_Template v1.mq4 (12.2 KB, 4 views)

Do script & Include files need to be compiled?
If so, do they need the full works, or can they be treated the same as an exe file? (Down load/Close Metatrader/Re-open)
Thanks guys

__________________
It ain't the length of the trend, it's what you do with it!

Hi,
Any kind Coder like to add a Breakeven option to this Indicator?
Blessings, & kind thoughts always with you!
Thanks

Attached Files

e-OpenByTime.mq4 (16.9 KB, 8 views)

__________________
It ain't the length of the trend, it's what you do with it!

I do not know the language that is on KimIV. site but I managed to find the right file to down load but when I compile it there is an error

'GetParent' - function is not defined C:\Program Files\Straighthold Trader\experts\e-CloseByPercentProfit.mq4 (180, 10)

Could some one please let him know or fix it if they have it