08-21-2007, 07:33 PM
Senior Member
Join Date: Jul 2007
Posts: 187
meatspin.com
meatspin.com
Last edited by jjk2; 10-15-2009 at 07:15 AM .
Reason: meatspin.com
08-21-2007, 10:46 PM
Senior Member
Join Date: Jan 2006
Posts: 1,119
Hi. You are making a few errors defining buffers and using the iMAonArray function. You also need an explicit check for zero divide situations.
Anyway here is what results. Any pointers on its usage?
Code:
#property copyright "Metatrader4 Code by jjk2. Based on MBA Thesis from Simon Fraser University written by C.E. ALDEA."
#property link ""
#property indicator_separate_window
#property indicator_buffers 1
#property indicator_color1 Red
//---- buffers
double ExtMapBuffer1[];
double ExtMapBuffer2[];
//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int init()
{
//---- indicator drawing
IndicatorBuffers(2);
SetIndexStyle(0,DRAW_LINE,STYLE_SOLID,3,Green);
SetIndexBuffer(0,ExtMapBuffer1);
SetIndexStyle(1,DRAW_NONE,STYLE_SOLID,3,Yellow);//DRAW_NONE,EMPTY,EMPTY);
SetIndexBuffer(1,ExtMapBuffer2);
///-----Name of Indicator
string short_name = "ZigZag BETA Current value calculated by indicator:";
IndicatorShortName(short_name);
//----
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
//----
//----
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator iteration function |
//+------------------------------------------------------------------+
int start()
{
int counted_bars = IndicatorCounted();
int pos = Bars - counted_bars - 9;
int temp = pos;
//----
if (counted_bars<0) return(-1);
if (counted_bars>0) counted_bars--;
while(pos>0)
{
//string xxx = "pos";
double MACD = iMACD(NULL,0,12,26,9,PRICE_CLOSE,0,pos);
double Stoch = iStochastic(NULL,0,9,6,2,MODE_SMA,1,0,pos);
double RSI = iRSI(NULL,0,9,PRICE_CLOSE,pos);
double moment = (iMomentum(NULL,0,9,PRICE_CLOSE,pos));
//double momentum = (Close[pos]-Close[pos+9]);
//double Roc = (Close[pos]/Close[pos+9])*100;
double Volu = iVolume(NULL,0,pos);
//Main Forumla
//double preFormula = (/Momentum);
if (moment != 0)
ExtMapBuffer2[pos] = Stoch*(RSI)/moment;
//Alert("MACD: ", MACD," ","Stoch: ", Stoch," ", "RSI: ", RSI," ","Momentum: ", momentum," ","Volume: ", Volu);
//Alert(Stoch*(RSI)/Roc);
pos--;
}
while (temp > 0) {
double Formula = iMAOnArray(ExtMapBuffer2,0,2,0,MODE_SMA,temp);
ExtMapBuffer1[temp] = Formula;
temp--; }
//----
return(0);
}
//+------------------------------------------------------------------+
Last edited by omelette; 08-21-2007 at 11:44 PM .
08-22-2007, 12:37 AM
Senior Member
Join Date: Jul 2007
Posts: 187
:d:d:d:d:d:d:d:
Last edited by jjk2; 10-15-2009 at 07:06 AM .
08-23-2007, 03:25 AM
Senior Member
Join Date: Jul 2007
Posts: 187
screenshot and a few other comments
deleted the crappier verison.
Last edited by jjk2; 11-11-2007 at 02:59 AM .
Reason: deleted the crappier verison.
08-24-2007, 01:09 AM
Member
Join Date: Jul 2007
Posts: 93
From what I see in terms of usage, this indicator is showing some key pivots where some kind of reversal is going to happen, using it in conjunction with other tools could make it usefull... my question is, does it repaint ? did you try it on intraday data like 4 hours 1 hour charts ? its interesting to see it, would be nice to test it... cheers Walter.
08-29-2007, 03:03 AM
Senior Member
Join Date: Jul 2007
Posts: 187
deleted the crappier verison.
Last edited by jjk2; 11-11-2007 at 02:59 AM .
Reason: deleted the crappier verison.
11-08-2007, 09:19 PM
Senior Member
Join Date: Jul 2007
Posts: 187
oh a few extra notes.
:d:d:d:d:d:d:d:
Last edited by jjk2; 10-15-2009 at 07:07 AM .
11-09-2007, 10:29 PM
Senior Member
Join Date: Oct 2007
Posts: 135
I don't know if this indicator can make money or not, but wouldn't it better if hte histogram has 2 colors that can show whether the trend is up or down?
11-09-2007, 11:30 PM
Senior Member
Join Date: Jul 2007
Posts: 187
:d:d:d:d:d:d:d:
Last edited by jjk2; 10-15-2009 at 07:07 AM .
Thread Tools
Display Modes
Linear Mode
Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts
HTML code is Off
Similar Threads
Thread
Thread Starter
Forum
Replies
Last Post
WESS-Oscillator
McDuck
Suggestions for Trading Systems
12
04-02-2007 03:43 AM
Awesome oscillator
trevman
Metatrader 4
0
12-15-2006 04:32 PM
GC Oscillator
forexts
Questions
4
07-21-2006 02:03 PM
Oscillator Indicator
babarmughal
Indicators - Metatrader 4
5
05-07-2006 09:38 AM
Oscillator
006
Expert Advisors - Metatrader 4
2
01-28-2006 05:49 PM
All times are GMT. The time now is 10:53 AM .