Indicator calculation?

cja · #1 (**permalink**) 02-12-2007, 09:19 AM

Hi People

Can anyone have a look at this indicator code, it shows the daily WAIST level.

If i code it with this setup the waist is correct

double OPEN = iOpen(NULL,1440,1);
double CLOSE = iClose(NULL,1440,1);

double WAIST = (OPEN + CLOSE)/2;

If i code it this way it reads 5 to 10 pips out depending on the previous days range.

if(Open[i+1] > YesterdayOpen)
YesterdayOpen = Open[i+1];
//----
if(Close[i+1] < YesterdayClose)
YesterdayClose=Close[i+1];
if (TimeDay(Time[i])!= TimeDay(Time[i+1]))
{
WBuffer[i+1] = EMPTY_VALUE;

WAIST = ( YesterdayOpen + Close[i+1] ) / 2;

I can not see where the problem is - it is probably something real obvious but i just can not see it at present, any help would be greatly appreciated.
Now i need to do it the 2nd way so that i can have it showing up on the previous days as a trading history.

Here is the code
Daily_Waist.mq4

cja

ralph.ronnquist · #2 (**permalink**) 02-12-2007, 09:28 AM

PHP Code:


			
            YesterdayClose = Open[i]; 

            YesterdayOpen = Open[i];

Is that correct?

cja · #3 (**permalink**) 02-12-2007, 09:33 AM

Quote:

Originally Posted by ralph.ronnquist

PHP Code:


			
            YesterdayClose = Open[i]; 

            YesterdayOpen = Open[i];

Is that correct?

I believe that is correct as i have compared this piece of code in other pivot daily open indicators and they all have this line of code? however i could be wrong - i stand to be corrected.

cja

ralph.ronnquist · #4 (**permalink**) 02-12-2007, 09:58 AM

Ok. Well, I have no idea about the logic, but obviously "YesterdayClose" is not of any use whatsoever.... Hmm, let's see... the line

PHP Code:


			
        WBuffer[i+1] = EMPTY_VALUE;

has the effect of killing "all" older indications, where "all" only means those that the indicator is invoked for... not sure why... then there is some peculiar(?) exception for indicating on Mondays or Tuesdays(?)

If I understood your objective correctly, I might suggest you replace the for-loop with the following:

PHP Code:


			
for (int i=limit; i>=0; i--) {

    int d = i * Period() / 1440; // Day bar index.

    WBuffer[i] = (iOpen(NULL,PERIOD_D1,d+1)+iClose(NULL,PERIOD_D1,d+1))/2;

}

That is, kind of that a bar on this chart is indicated by considering the "waist" in regards to the day-chart bar that this bar is placed in. Maybe?

cja · #5 (**permalink**) 02-12-2007, 10:04 AM

Quote:

Originally Posted by ralph.ronnquist

Ok. Well, I have no idea about the logic, but obviously "YesterdayClose" is not of any use whatsoever.... Hmm, let's see... the line

PHP Code:


			
        WBuffer[i+1] = EMPTY_VALUE;

has the effect of killing "all" older indications, where "all" only means those that the indicator is invoked for... not sure why... then there is some peculiar(?) exception for indicating on Mondays or Tuesdays(?)

If I understood your objective correctly, I might suggest you replace the for-loop with the following:

PHP Code:


			
for (int i=limit; i>=0; i--) {

    int d = i * Period() / 1440; // Day bar index.

    WBuffer[i] = (iOpen(NULL,PERIOD_D1,d+1)+iClose(NULL,PERIOD_D1,d+1))/2;

}

That is, kind of that a bar on this chart is indicated by considering the "waist" in regards to the day-chart bar that this bar is placed in. Maybe?

WBuffer[i+1] = EMPTY_VALUE; This line of code takes the joining line out of the historical lines and leaves them as individual daily lines.

ralph.ronnquist · #6 (**permalink**) 02-12-2007, 10:51 AM

Quote:

Originally Posted by cja

WBuffer[i+1] = EMPTY_VALUE; This line of code takes the joining line out of the historical lines and leaves them as individual daily lines.

Right, of course; that's "a good thing", yes... so that should be dropped back into the loop.. making it:

PHP Code:


			
for (int i=limit; i>=0; i--) {
    int d = i * Period() / PERIOD_D1; // Day bar index.
    WBuffer[i] = (iOpen(NULL,PERIOD_D1,d+1)+iClose(NULL,PERIOD_D1,d+1))/2;
    if (TimeDay(Time[i]) != TimeDay(Time[i+1]))
        WBuffer[i+1] = EMPTY_VALUE;
}

... what about the "Monday fiddling"?