MACD indicator - Page 28

yevell · #**271** (**permalink**) 06-25-2009, 01:57 PM

hi guys, I need your help !
i have two MACD indicators, one is MACD_OsMA_ColorLH.mq4, and the other is All TF MACD, i attach them on this thread !

I like the color of the MACD_OsMA_ColorLH.mq4, so, could somebody help to make the All TF MACD have the same color ?

much appreciate !

best wishes !

Sadly · #**272** (**permalink**) 06-25-2009, 02:09 PM

Open both indicators in MetaEditor and look at each #property indicator_color. It's here that you can alter the colours to match.

yevell · #**273** (**permalink**) 06-25-2009, 02:19 PM

thank you very much for your quickly reply !
i'm sorry that i did not make the thing clear !
i like the color because the osma could change color when its current value larger or smaller than it's previous value !
so, i hope the All TF MACD can also change color when the value change !
thanks again !

for(i=0; i<limit; i++)

ind_buffer3[i]=iOsMA(NULL,0,FastEMA,SlowEMA,SignalSMA,AppliedPri ce,i)*3;

//---- dispatch values between 2 buffers
bool up=true;
for(i=limit-1; i>=0; i--)
{
current=ind_buffer3[i];
prev=ind_buffer3[i+1];
if (((current<0)&&(prev>0))||(current<0)) up= false;
if (((current>0)&&(prev<0))||(current>0)) up= true;

if(!up)
{
if(current > prev)
{
ind_buffer2s[i]=current;
ind_buffer2[i]=0.0;
ind_buffer1[i]=0.0;
ind_buffer1s[i]=0.0;
}
else
{
ind_buffer2[i]=current;
ind_buffer2s[i]=0.0;
ind_buffer1[i]=0.0;
ind_buffer1s[i]=0.0;
}
}
else
{
if(current < prev)
{
ind_buffer1s[i]=current;
ind_buffer1[i]=0.0;
ind_buffer2[i]=0.0;
ind_buffer2s[i]=0.0;
}
else
{
ind_buffer1[i]=current;
ind_buffer1s[i]=0.0;
ind_buffer2[i]=0.0;
ind_buffer2s[i]=0.0;
}
}

Quote:

Originally Posted by Sadly

Open both indicators in MetaEditor and look at each #property indicator_color. It's here that you can alter the colours to match.

newdigital · #**274** (**permalink**) 06-25-2009, 02:46 PM

Try this indicator http://www.forex-tsd.com/217332-post2230.html

yevell · #**275** (**permalink**) 06-25-2009, 03:00 PM

thank you so much ! though it is a little different with what i need, but I can modify it by myself now !

thanks again !

Quote:

Originally Posted by newdigital

Try this indicator http://www.forex-tsd.com/217332-post2230.html

yevell · #**276** (**permalink**) 06-25-2009, 05:33 PM

hi guys, I still need your help !
I made some change on mladen's all macd, and it can change color now
but i meet some problems.
please see the pic below:
the first indicator is macd_osma_4color, and the second is all macd with only H1 TF, and the last is all macd with H1 and H4 TF !
you could see that, the first indicator and the second show the same color and value !
but the third is different ! so, could anybody help me to solve this problem ?
i really do not know what the problem is !

thank you very much !
and I attach the indicator !

mladen · #**277** (**permalink**) 06-25-2009, 06:02 PM

If you want same values you should turn the equalize parameter off

equalize parameter is there for cases when you have more time frames and you want to see MACD without something like the 3rd macd on the picture (MACD is an oscillator, but it does not have known minimum and maximum and since it measures differences between two moving averages higher time frames tend to give much higher values that the lower time frames)

_________________________

Also, since you started the coding part (but please, do not misunderstand this, I think you will enjoy much more when you finish the coding you have started

), just one tip without final solution : in the part of the code where you compare values in order to determine colors, the loop goes from left to right (line 300) so you can not compare the current (already "equalized" value) with the previous (non-"equalized" value)
The reason for different colors lays in this part of code. When you finish coding, you will have it as it should be
(this code - you have to change something in it

)

PHP Code:


			
               for(i=0; i<barsPerTimeFrame;i++,k++)
               {
                  ExtMapBuffer5[k] = ExtMapBuffer7[k]*koef;
                  ExtMapBuffer6[k] = ExtMapBuffer6[k]*koef;
                 // osma[k]          = OSMA[k]*koef;
                //  current = osma[k];
                //  prev    = osma[k+1];
                 current = ExtMapBuffer5[k]-ExtMapBuffer6[k];
                 prev    = ExtMapBuffer5[k+1]-ExtMapBuffer6[k+1];
                 if (((current<0)&&(prev>0))||(current<0))   up= false;    
                 if (((current>0)&&(prev<0))||(current>0))   up= true;  
....

regards
mladen

Quote:

Originally Posted by yevell

hi guys, I still need your help !
I made some change on mladen's all macd, and it can change color now
but i meet some problems.
please see the pic below:
the first indicator is macd_osma_4color, and the second is all macd with only H1 TF, and the last is all macd with H1 and H4 TF !
you could see that, the first indicator and the second show the same color and value !
but the third is different ! so, could anybody help me to solve this problem ?
i really do not know what the problem is !

thank you very much !
and I attach the indicator !

yevell · #**278** (**permalink**) 06-25-2009, 11:09 PM

thanks for you help, mladen !
i have try my best but i still could not get the right thing !
so, could you kindly post the final solution ?

thanks again !
best wishes !

Quote:

Originally Posted by mladen

If you want same values you should turn the equalize parameter off

equalize parameter is there for cases when you have more time frames and you want to see MACD without something like the 3rd macd on the picture (MACD is an oscillator, but it does not have known minimum and maximum and since it measures differences between two moving averages higher time frames tend to give much higher values that the lower time frames)

_________________________

Also, since you started the coding part (but please, do not misunderstand this, I think you will enjoy much more when you finish the coding you have started

), just one tip without final solution : in the part of the code where you compare values in order to determine colors, the loop goes from left to right (line 300) so you can not compare the current (already "equalized" value) with the previous (non-"equalized" value)
The reason for different colors lays in this part of code. When you finish coding, you will have it as it should be
(this code - you have to change something in it

)

PHP Code:


			
               for(i=0; i<barsPerTimeFrame;i++,k++)

               {

                  ExtMapBuffer5[k] = ExtMapBuffer7[k]*koef;

                  ExtMapBuffer6[k] = ExtMapBuffer6[k]*koef;

                 // osma[k]          = OSMA[k]*koef;

                //  current = osma[k];

                //  prev    = osma[k+1];

                 current = ExtMapBuffer5[k]-ExtMapBuffer6[k];

                 prev    = ExtMapBuffer5[k+1]-ExtMapBuffer6[k+1];

                 if (((current<0)&&(prev>0))||(current<0))   up= false;    

                 if (((current>0)&&(prev<0))||(current>0))   up= true;  

....

regards
mladen

mladen · #**279** (**permalink**) 06-26-2009, 07:27 AM

Lazy

Replace that code with this one :

PHP Code:


			
               for(i=0; i<barsPerTimeFrame;i++,k++)
               {
                  current = ExtMapBuffer7[k]-ExtMapBuffer6[k];
                  prev    = ExtMapBuffer7[k+1]-ExtMapBuffer6[k+1];
                  if (((current<0)&&(prev>0))||(current<0))   up= false;    
                  if (((current>0)&&(prev<0))||(current>0))   up= true;  

                  //
                  //
                  //
                                   
                  ExtMapBuffer5[k] = ExtMapBuffer7[k]*koef;
                  ExtMapBuffer6[k] = ExtMapBuffer6[k]*koef;

It is what is called "it has everything, but at wrong place". Only the steps were in a wrong order, nothing else

Btw: those are, when you are writing the code, hardest to spot. When someone else looks at it, it is likely that he/she will spot it immediately . Once I lost 3-4 days just to find out that I need to invert 2 line position

regards
mladen

Quote:

Originally Posted by yevell

thanks for you help, mladen !
i have try my best but i still could not get the right thing !
so, could you kindly post the final solution ?

thanks again !
best wishes !

yevell · #**280** (**permalink**) 06-26-2009, 09:20 AM

Fantastic ! that's what i need !
thank you so much !

I really try my best, but i never think the order of line !

thanks again !
best wishes !

Quote:

Originally Posted by mladen

Lazy

Replace that code with this one :

PHP Code:


			
               for(i=0; i<barsPerTimeFrame;i++,k++)

               {

                  current = ExtMapBuffer7[k]-ExtMapBuffer6[k];

                  prev    = ExtMapBuffer7[k+1]-ExtMapBuffer6[k+1];

                  if (((current<0)&&(prev>0))||(current<0))   up= false;    

                  if (((current>0)&&(prev<0))||(current>0))   up= true;  



                  //

                  //

                  //

                                   

                  ExtMapBuffer5[k] = ExtMapBuffer7[k]*koef;

                  ExtMapBuffer6[k] = ExtMapBuffer6[k]*koef;

It is what is called "it has everything, but at wrong place". Only the steps were in a wrong order, nothing else

Btw: those are, when you are writing the code, hardest to spot. When someone else looks at it, it is likely that he/she will spot it immediately . Once I lost 3-4 days just to find out that I need to invert 2 line position

regards
mladen