buy order problems

trevman2005 · #1 (**permalink**) 12-22-2005, 08:11 PM

this bit of code doesnt seem to buy, any ideas why?

Code:

   if(Close[2]<ma && Close[1]>ma)
   {
    OrderSend(Symbol(),OP_BUY,lots,Ask,3,stop,Ask+profit,"",2005,0,Green);
   }

it should buy when a new candle closes above the moving average and the previous closed below it.

codersguru · #2 (**permalink**) 12-22-2005, 09:38 PM

Quote:

Originally Posted by trevman2005

this bit of code doesnt seem to buy, any ideas why?

Code:

   if(Close[2]<ma && Close[1]>ma)
   {
    OrderSend(Symbol(),OP_BUY,lots,Ask,3,stop,Ask+profit,"",2005,0,Green);
   }

it should buy when a new candle closes above the moving average and the previous closed below it.

I think it should be:

PHP Code:


			
 if(Close[1]<ma && Close[0]>ma)
  {
   ticket=OrderSend(Symbol(),OP_BUY,lots,Ask,3,stop*Point,Ask+profit*Point,"",2005,0,Green);
   if(ticket>0)
     {
       if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES)) 
         Print("BUY order opened : ",OrderOpenPrice());
     }
   else Print("Error opening BUY order : ",GetLastError());
      return(0);
}

trevman2005 · #3 (**permalink**) 12-22-2005, 09:46 PM

that worked, very much appreciated, but why the "ticket", "orderselect" and "Point" x ask+profit?, i'm reading through your tutorials atm, i apologise if i missed this info. thanks again.

codersguru · #4 (**permalink**) 12-22-2005, 10:00 PM

Quote:

Originally Posted by trevman2005

that worked, very much appreciated, but why the "ticket" and "orderselect" i'm reading through your tutorials atm, i apologise if i missed this info. thanks again.

You're welcome!

If you noticed the code:

1- I've changed

if(Close[2]<ma && Close[1]>ma)

To:

if(Close[1]<ma && Close[0]>ma)

Because the index of the new bar is 0 and the index of the previous one is 1.

2- I used ticket and OrderSelect only to check what the wrong (if any) is.
(Please prefer to Appendix 2 - Trading functions)

3- I've changed stop to stop*Point and profit to profit*Point.

trevman2005 · #5 (**permalink**) 12-23-2005, 08:06 AM

Quote:

Originally Posted by codersguru

3- I've changed stop to stop*Point and profit to profit*Point.[/color][/size][/font][/left]

why does point need to be a part of the code?

i've also noticed that my stoploss is set to 30 and my take profit is 80, yet my backtest results give me around 17 loss and 45 profit, why does it do this? thanks again.

codersguru · #6 (**permalink**) 12-23-2005, 02:05 PM

Quote:

Originally Posted by trevman2005

why does point need to be a part of the code?

Point function returns the point size of the current symbol.
(EX: if you trade EURUSD the point value = .0001 and if you trade EURJPY the point value should be .01)
So, if your stoploss must be converted to points in order to use OrderSend or OrderModify functions.

Quote:

i've also noticed that my stoploss is set to 30 and my take profit is 80, yet my backtest results give me around 17 loss and 45 profit, why does it do this? thanks again.

Could you explain more? Do you mean that the strategy tester automatically set your stoploss and takeprofit values?

trevman2005 · #7 (**permalink**) 12-23-2005, 02:20 PM

Quote:

Originally Posted by codersguru

Point function returns the point size of the current symbol.
(EX: if you trade EURUSD the point value = .0001 and if you trade EURJPY the point value should be .01)
So, if your stoploss must be converted to points in order to use OrderSend or OrderModify functions.

"Ask+profit*Point" should be equal to whatever i set my profit level at right?, but if "ask" is 1.1825 and "profit" is 50 then "1.1825+80*1.1825" but that equals 95

Quote:

Originally Posted by codersguru

Could you explain more? Do you mean that the strategy tester automatically set your stoploss and takeprofit values?

my expert has the below settings as default
extern double profit = 80;
extern double stop = 30;

but backtesting produced t/p stops of 45-46 and stoploss losses of 17

codersguru · #8 (**permalink**) 12-23-2005, 02:37 PM

Quote:

Originally Posted by trevman2005

"Ask+profit*Point" should be equal to whatever i set my profit level at right?, but if "ask" is 1.1825 and "profit" is 50 then "1.1825+80*1.1825" but that equals 95

No, the Point will be .0001 not 1.1825 (1.1825 is the ask price).
So,
If "ask" is 1.1825 and "profit" is 50then:

1.1825 + (50 * .0001) = 1.1825 + 0.005 = 1.1875 (50 Pips)

Quote:

my expert has the below settings as default
extern double profit = 80;
extern double stop = 30;

but backtesting produced t/p stops of 45-46 and stoploss losses of 17

Still don't understand this point

.
Did you use Optimization testing mode?

trevman2005 · #9 (**permalink**) 12-23-2005, 03:39 PM

maybe this will help,

Parameters profit=80; stop=30;

yet niether the t/p or s/l are the same as the specified

trevman2005 · #10 (**permalink**) 12-27-2005, 06:26 PM

does no one have any ideas why the results are as shown in the test run?

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Order Execution Problems with my EA	mrebersv	Metatrader 4	6	04-01-2007 09:08 AM
Problems with EA's.	rodrigojmz	General Discussion	3	02-22-2007 01:15 AM
Help, anyone having problems with MT4?	increase	General Discussion	10	12-08-2006 01:06 PM
ea problems	Eaglehawk	Metatrader 4	3	06-13-2006 05:32 PM

Register in Forex TSD!
Trading Systems Leaders in this forum (automated trading systems) are winning more than 3000 pips in a month (30000$ investing one lot every time). Click here to register and get more information