Ask! - Page 91

Putz · #**901** (**permalink**) 01-06-2008, 01:55 PM

Hi all,

I am still trying to build my first basic EA. I finally have parts of it working but not all of it.

My idea is to buy/sell on retracements. So far, I am only working on the "Sell" portion of the EA. The "Buy" part will come later...hopefully.

The way that I want it to work is that I want to track the lowest point (CurrentLow) and when the price retraces by Ret1 (75 pips), to put a sell order in. If price comes back to CurrentLow, take profit and start the process over.

If price keeps going against me and it retraces by Ret2 (150 pips from CurrentLow), I want to put another sell order x 2 lots with take profit at the point of the first order plus one pip.

Stop Loss is placed at 225 pips from CurrentLow.

My EA is placing the order from the first level but not from the second level. I was able to get it to place orders from the second level but only at the same price as the first level.

Can someone please look at my code to see how I am screwing up.

Thanks,
Putz

Code:

//+------------------------------------------------------------------+
//|                                                  Bruno test1.mq4 |
//|                      Copyright © 2007, MetaQuotes Software Corp. |
//|                                        http://www.metaquotes.net |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2007, Putz Canada Corp"
#property link      "http://www.Putzfx,com"

extern string     Expert_Name    = "Albatross v1";
extern int        MagicNumber    = 757575;
extern int        Slippage       =     3.0;

//---- input parameters
extern double    TP1=75;
extern double    SL1=150;
extern double    Ret1=75;
extern double    TP2=76;
extern double    Ret2=150;
extern double    Lots=0.1;
double Entry1 = 0;
double Entry2 = 0;
double TPA = 0;
double TPB = 0;
double SL = 0;
double CurrentLow = 1000;


//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//----  
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
//----
   return(0);
  }
  
//+------------------------------------------------------------------+
//| Check Open Position Controls                                     |
//+------------------------------------------------------------------+
  
int CheckOpenTrades()
{
 int cnt;
 int NumTrades;   // Number of buy and sell trades in this symbol
   
 NumTrades = 0;
 for(cnt=OrdersTotal()-1;cnt>=0;cnt--)
  {
   OrderSelect (cnt, SELECT_BY_POS, MODE_TRADES);
   if ( OrderSymbol() != Symbol()) continue;
   if ( OrderMagicNumber() != MagicNumber)  continue;
      
   if(OrderType() == OP_BUY )  NumTrades++;
   if(OrderType() == OP_SELL ) NumTrades++;             
  }
 return (NumTrades);
} 
  
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+

int start()
 {
  int cnt, ticket, total;

  if(Bars<100)
   {
    Print("bars less than 100");
    return(0);  
   }
   
  total = CheckOpenTrades();
  if(total==0) 
  {
   if(Bid < CurrentLow) CurrentLow = Bid; 
    {
     Entry1 = CurrentLow + Ret1*Point;
     Entry2 = CurrentLow + Ret2*Point;
     SL = Entry1 + SL1*Point;
     TPA = Entry1 - TP1*Point;
     TPB = Entry2 - TP2*Point;
     if(Bid >= Entry1)
      {
       OrderSend(Symbol(),OP_SELL,Lots,Entry1,3,SL,TPA,"Albatross_v1",MagicNumber,0,Green);
       if(Bid >= Entry2)
        {
         OrderSend(Symbol(),OP_SELL,Lots*2,Entry2,3,SL,TPB,"Albatross_v1",MagicNumber,0,Green); 
        } 
       CurrentLow=1000; 
      } 
    } 
  }  
 }

Sendra · #**902** (**permalink**) 01-06-2008, 06:54 PM

I think you forgot about which low you use as currentlow. See, I can't imagine if you mean the low of current bar. If you mean what I think you mean, try to use iLowest[]. See it in dictionary of Metaeditor.

Sendra · #**903** (**permalink**) 01-06-2008, 06:57 PM

sorry, I didn't see you put currentlow = 1000;. But suggestion remains. See, currentlow = 1000; 1000 what? 1.0000 like in GBP/USD? 1000 point, from where? So, still the same, use iLowest[] for currentlow. I think it would work fine.

Putz · #**904** (**permalink**) 01-06-2008, 08:33 PM

Hi Sendra,

Thanks for your prompt reply.

What I am trying to achieve is not based on a high or low of any timeframe but the lowest point prior to a Ret1 (75 pip) retracement. I am focusing on the EUR/USD to start.

CurrentLow is supposed to track the lowest point before the retracement.

The following is an example of what I am trying to achieve.

a) Let's say we open the EA and the price is 1.4000 and it ranges between 1.4030 and 1.3970 before going to 1.4045. I would want CurrentLow to be 1.3970 (Lowest point) and to place the first sell order at 1.4045 (Entry1) with a SL of 1.4195 (SL1 =150 pips) and a Take Profit (TPA = 75 pips) of 1.3970.

b) if the price continues to go up to 1.4120 (Entry2), I would want a 2nd sell order placed with take profit (TPB =76 pips) of 1.4044 and SL of 1.4195 (same as on the first order).

My EA seems to work for the first order but it doesn't seem to get to the second order. I have been able to get it to place the second order but the price was the same as the first order and the SL was screwed up.

My long term goal is to have it decide whether it should be a buy or sell based on long term trend indicators and of course to have a buy set up like this sell set up as shown here. I have no idea whether it will be profitable but I am trying to learn and will surely make a million modifications before it is completed. I have come to the conclusion that to find out if any strategy works, it needs to be automated and take the human error out of the decision making. Obviously, fundamentals need to be looked at but that will come later...maybe.

Any help from Sendra or anyone else will be highly appreciated.

Thanks
Putz

Putz · #**905** (**permalink**) 01-06-2008, 08:37 PM

Hi Sendra,

In order to answer your question about CurrentLow, I gave it a value of 1000 as that will always be bigger than any E/U price. This is to make sure that it takes the first EU price when it opens. If I would set it to 0, the price would never be lower and therefore no trades would ever take place.

I have never seen iLowest but I will check into it to see if it would work for me.

Thanks
Putz

khari123 · #**906** (**permalink**) 01-08-2008, 10:26 PM

Can someone help me with a script or ea that forces only 1 trade per day?

Thanks A Bunch

Sendra · #**907** (**permalink**) 01-09-2008, 12:18 AM

Putz, what do you mean, "seems to work"? Either it is working or it is not. if it does work for the first order, then you should base your second order upon it (use OrderOpenPrice() as the basis of your second order instead of your currentlow like the first one).

Sendra · #**908** (**permalink**) 01-09-2008, 12:25 AM

Quote:

Originally Posted by khari123

Can someone help me with a script or ea that forces only 1 trade per day?

Thanks A Bunch

Use daily chart, put:

#property ...

static bool ITradedOnThisBar;

//+---------------------------+
//| expert initialization function |
//+---------------------------+

then, on your opening and closing conditions add:
ITradedOnThisBar!=Bars

and after OrderSend():
ITradedOnThisBar=Bars;