Ask! - Page 107

Michel · #**1061** (**permalink**) 04-27-2008, 09:20 AM

Quote:

Originally Posted by bearfoot090

hi there!

can some here help me add this function. Make it to close trade when the bar is completed or in another word to make it close the trade when the next bar appear.( doesnt matter the trade is profit or loss )

To detect a new bar there are several solutions:

1)

PHP Code:


			
if(Volume[0] == 1) CloseOrders();

Not very reliable, for example if the terminal has to be restarted you may loose the first tick of the bar.

2)

PHP Code:


			
if(BarsCnt < Bars) {BarsCnt = Bars; CloseOrders();}

Not very reliable, for example if new bars are added to the left of the chart.

3)

PHP Code:


			
if(Time1 < Time[0]) {Time1 = Time[0]; CloseOrders();}

Better, but again, restarting the terminal may produce wrong behaviors.

So my opinion is that the best is to write the lifetime max of each order into the order itself, using the "Comment" field :

PHP Code:


			
OrderSend(..., ""+(Time[0] + Period()*60), ..);

Then you can scan the orders and check :

PHP Code:


			
if(TimeCurrent() > OrderComment()) OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), 0, CLR_NONE);

. This is a good solution because if you have several orders to close, you have all the time needed to do it.

bearfoot090 · #**1062** (**permalink**) 04-27-2008, 01:05 PM

thanks michel for the reply.

I`ll try. but what should i put in the comment?anything i like?

Michel · #**1063** (**permalink**) 04-27-2008, 03:04 PM

Quote:

Originally Posted by bearfoot090

thanks michel for the reply.

I`ll try. but what should i put in the comment?anything i like?

Put the time you want to close the order. The Comment field must be a string, that's why there is ""+ in front of the value. for example:

PHP Code:


			
""+(Time[0] + Period()*60)   // begin of the next bar on the current timeframe



""+(TimeCurrent() + 2*360 + 30*60)   // 2 hours 30 minutes after the openning



""+(iTime(NULL,PERIOD_D1,0) + 23*360 + 45*60) // today at 23:45 (server time)



""+(iTime(NULL,PERIOD_W1,0) + (PERIOD_W1 - 10)*60) // next friday at 23:50

yyc196 · #**1064** (**permalink**) 04-28-2008, 12:39 AM

Quote:

Originally Posted by Michel

If needed, check first that you are later than 8 am:

PHP Code:


			
if(Hour() < 8) return;

Then, find the max and min of the current day. (if its ok for you, its easier than from 8 am):

PHP Code:


			
double Max = iHigh(Symbol(), PERIOD_D1, 0);

double Min = iLow(Symbol(), PERIOD_D1, 0);

int Range = (Max - Min) / Point;

if(Range > 90) return;

...

Hi,

Apology to take such a ling time to say "thank you".

I appreciate your help.

Thanks again.

Shek

bearfoot090 · #**1065** (**permalink**) 04-28-2008, 12:56 PM

Quote:

Originally Posted by Michel

To detect a new bar there are several solutions:

1)

PHP Code:


			
if(Volume[0] == 1) CloseOrders();

Not very reliable, for example if the terminal has to be restarted you may loose the first tick of the bar.

2)

PHP Code:


			
if(BarsCnt < Bars) {BarsCnt = Bars; CloseOrders();}

Not very reliable, for example if new bars are added to the left of the chart.

3)

PHP Code:


			
if(Time1 < Time[0]) {Time1 = Time[0]; CloseOrders();}

Better, but again, restarting the terminal may produce wrong behaviors.

So my opinion is that the best is to write the lifetime max of each order into the order itself, using the "Comment" field :

PHP Code:


			
OrderSend(..., ""+(Time[0] + Period()*60), ..);

Then you can scan the orders and check :

PHP Code:


			
if(TimeCurrent() > OrderComment()) OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), 0, CLR_NONE);

. This is a good solution because if you have several orders to close, you have all the time needed to do it.

i got the error below.what does ot mean?

PHP Code:


			
'>' - different types in comparison    F:Program FilesMetaTrader - FXOpenexpertsEMA_10.mq4 (88, 22)

I make it like this
for the send order

PHP Code:


			
OrderSend(Symbol(),OP_BUY,Lots,Ask,0,Ask-25*Point,Ask+TakeProfit*Point, ""+(Time[0] + Period()*60),SystemMagicNumber,0,Blue);

and for the close order

PHP Code:


			
if(TimeCurrent() > OrderComment())

    {

     OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), 0, CLR_NONE);  

    }

and i got the error shown above.
Is it right?

Michel · #**1066** (**permalink**) 04-28-2008, 01:59 PM

my mistake, sorry.
This should work:

PHP Code:


			
if(TimeCurrent() > StringToInteger(OrderComment())

bearfoot090 · #**1067** (**permalink**) 04-28-2008, 02:31 PM

It come to error like this.I try to put
entern int StringToInteger;
but still the error appear.
what should i do?
sorry for keep asking you but I really donno what I`m doing actually.So I would really appreciate your help .

PHP Code:


			
'StringToInteger' - function is not defined    F:Program FilesMetaTrader - FXOpenexpertsEMA_10.mq4 (87, 28)

Michel · #**1068** (**permalink**) 04-28-2008, 03:05 PM

Quote:

Originally Posted by bearfoot090

It come to error like this.I try to put
entern int StringToInteger;
but still the error appear.
what should i do?
sorry for keep asking you but I really donno what I`m doing actually.So I would really appreciate your help .

PHP Code:


			
'StringToInteger' - function is not defined    F:Program FilesMetaTrader - FXOpenexpertsEMA_10.mq4 (87, 28)

"entern int StringToInteger;" has no meaning. but it's again my mistake, so again sorry... the function is StrToInteger()

So the code to close the orders sould be something like this :

PHP Code:


			
for(int i = OrdersTotal() - 1; i >= 0; i --)

{

   OrderSelect(i,SELECT_BY_POS,MODE_TRADES);

   if(OrderMagicNumber() != Magic) continue;

   if(TimeCurrent() > StrToInteger(OrderComment())) OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), 0, CLR_NONE);  

}

bearfoot090 · #**1069** (**permalink**) 04-28-2008, 03:52 PM

thank you michel!

I can compile it with no errors now.

solamax · #**1070** (**permalink**) 05-01-2008, 12:57 PM

speaking of error codes

- does anybody know what these error codes mean?

they come up all the time when the EA tries to open a trade but cant because of this error

many thnx 4 any help

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

LinkBacks (?) LinkBack to this Thread: http://www.forex-tsd.com/questions/270-ask.html
Posted By	For	Type	Date
OzFx System:) - Page 639	This thread	Refback	06-21-2008 09:53 PM
Forex SRDC Sidus Sibkis EA MT4 Forum OTCSmart	This thread	Refback	12-08-2007 11:46 AM

Register in Forex TSD!
Trading Systems Leaders in this forum (automated trading systems) are winning more than 3000 pips in a month (30000$ investing one lot every time). Click here to register and get more information