Ask! - Page 103

Michel · #**1021** (**permalink**) 03-31-2008, 09:18 PM

Quote:

Originally Posted by ableze_joepardy

hi.. I've modified the default script (trade.mq4) in metatrader platform to execute martingle based trade.. the condition is like below:

Starting lot: 0.1
Multiple: 2
Pips: 8
TP: 10
Max trade: 5

and here's the code..

Code:

//+------------------------------------------------------------------+
//|                                                    buy 1 lot.mq4 |
//|                      Copyright © 2004, MetaQuotes Software Corp. |
//|                                       http://www.metaquotes.net/ |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2004, MetaQuotes Software Corp."
#property link      "http://www.metaquotes.net/"

#include <stdlib.mqh>
#include <WinUser32.mqh>
//+------------------------------------------------------------------+
//| script "trading for all money"                                   |
//+------------------------------------------------------------------+
int start()
  {
//----
   if(MessageBox("Do you really want to execute Martingle "+Symbol()+" at ASK price?    ",
                 "Script",MB_YESNO|MB_ICONQUESTION)!=IDYES) return(1);
//----
   int ticket1=OrderSend(Symbol(),OP_BUY,0.1,Ask,3,Ask-40*Point,Ask+10*Point,"GU M5",770,0,CLR_NONE);
   int ticket2=OrderSend(Symbol(),OP_BUYLIMIT,0.2,Ask-8*Point,3,Ask-40*Point,Ask+2*Point,"GU M5",770,0,CLR_NONE);
   int ticket3=OrderSend(Symbol(),OP_BUYLIMIT,0.4,Ask-16*Point,3,Ask-40*Point,Ask-6*Point,"GU M5",770,0,CLR_NONE);
   int ticket4=OrderSend(Symbol(),OP_BUYLIMIT,0.8,Ask-24*Point,3,Ask-40*Point,Ask-14*Point,"GU M5",770,0,CLR_NONE);
   int ticket5=OrderSend(Symbol(),OP_BUYLIMIT,1.6,Ask-32*Point,3,Ask-40*Point,Ask-22*Point,"GU M5",770,0,CLR_NONE);
   if(ticket1<1)
     {
      int error1=GetLastError();
      Print("Error = ",ErrorDescription(error1));
      return;
     }
   if(ticket2<1)
     {
      int error2=GetLastError();
      Print("Error = ",ErrorDescription(error2));
      return;
     }
   if(ticket3<1)
     {
      int error3=GetLastError();
      Print("Error = ",ErrorDescription(error3));
      return;
     }
   if(ticket4<1)
     {
      int error4=GetLastError();
      Print("Error = ",ErrorDescription(error4));
      return;
     }
   if(ticket5<1)
     {
      int error5=GetLastError();
      Print("Error = ",ErrorDescription(error5));
      return;
     }        
//----
   OrderPrint();
   return(0);
  }
//+------------------------------------------------------------------+

but the code didnt execute the order.. whats wrong with the code?

What is the returned error ? You also should numbered the error messages, but take care that if you have two errors, for example on order 2 and 5, you will display for the order 2 the error of the order 5.

ableze_joepardy · #**1022** (**permalink**) 03-31-2008, 09:41 PM

Quote:

Originally Posted by Michel

What is the returned error ? You also should numbered the error messages, but take care that if you have two errors, for example on order 2 and 5, you will display for the order 2 the error of the order 5.

edited:

sorry.. i think the error is displayed in Expert window rite? And this is what I got after renaming the Error from 1 - 5...

error.GIF

Michel · #**1023** (**permalink**) 03-31-2008, 10:23 PM

Quote:

Originally Posted by ableze_joepardy

edited:

sorry.. i think the error is displayed in Expert window rite? And this is what I got after renaming the Error from 1 - 5...

Attachment 58175

You have the error " trade not allowed in the expert properties"
So hit ctrl-O, then tab "Expert Avisors" and select "Allow live trading"

BTW, renaming the variables will not erase the possibility of false information, you also need to check the error after each OrderSend() call and before the next one.

ableze_joepardy · #**1024** (**permalink**) 03-31-2008, 10:39 PM

owh thank you michel..

btw.. got another question.. ive also modified the mt4 default script to check if any trades opened using script above reach +10 pips.. If got any then close all 5 orders..

example..

Trade 1 lost
Trade 2 lost
Trade 3 +10 pips
Trade 4 Pending
Trade 5 Pending

then close all trades n delete all pending orders with magic no. 770..

can u please check whether the script below will do the job as planne?

Code:

//+------------------------------------------------------------------+
//|                                         AutoClose Same Magic.mq4 |
//|                      Copyright © 2008, MetaQuotes Software Corp. |
//|                                        http://www.metaquotes.net |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2008, MetaQuotes Software Corp."
#property link      "http://www.metaquotes.net"

int cnt;
double CurrentProfit;

//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//----

//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+

void CloseAllOrders(double MN) {
   bool   result;
   double price;
   int    cmd,error;
  
   while (OrdersTotal() > 0) {
      // Loop through all orders and close them
      for (int i = (OrdersTotal() - 1); i >= 0; i--) {
         if (OrderSelect(i,SELECT_BY_POS,MODE_TRADES)) {
            if (OrderMagicNumber() == MN) {
               cmd = OrderType();
               if (cmd == OP_BUY) {
               OrderClose(OrderTicket(),OrderLots(),Bid,3,CLR_NONE);
               }
               else if (cmd != OP_BUY && cmd != OP_SELL) {
               OrderDelete(OrderTicket());
               }
            }
         }
      }
   }
}

int start()
  {
//----

for(cnt=OrdersTotal();cnt>=0;cnt--)
      {
         OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
         if( OrderMagicNumber()==770 )
            {
               if(OrderType()==OP_BUY)
                  {
                     CurrentProfit=Bid-OrderOpenPrice() ;
                     if(CurrentProfit>10*Point)
                        {
                           CloseAllOrders(770);
                        }
                  }
            }
      }   
//----
   return(0);
  }
//+------------------------------------------------------------------+

Michel · #**1025** (**permalink**) 03-31-2008, 10:57 PM

Quote:

Originally Posted by ableze_joepardy

owh thank you michel..

btw.. got another question.. ive also modified the mt4 default script to check if any trades opened using script above reach +10 pips.. If got any then close all 5 orders..

example..

Trade 1 lost
Trade 2 lost
Trade 3 +10 pips
Trade 4 Pending
Trade 5 Pending

then close all trades n delete all pending orders with magic no. 770..

can u please check whether the script below will do the job as planne?

Code:

//+------------------------------------------------------------------+
//|                                         AutoClose Same Magic.mq4 |
//|                      Copyright © 2008, MetaQuotes Software Corp. |
//|                                        http://www.metaquotes.net |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2008, MetaQuotes Software Corp."
#property link      "http://www.metaquotes.net"

int cnt;
double CurrentProfit;

//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//----

//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+

void CloseAllOrders(double MN) {
   bool   result;
   double price;
   int    cmd,error;
  
   while (OrdersTotal() > 0) {
      // Loop through all orders and close them
      for (int i = (OrdersTotal() - 1); i >= 0; i--) {
         if (OrderSelect(i,SELECT_BY_POS,MODE_TRADES)) {
            if (OrderMagicNumber() == MN) {
               cmd = OrderType();
               if (cmd == OP_BUY) {
               OrderClose(OrderTicket(),OrderLots(),Bid,3,CLR_NONE);
               }
               else if (cmd != OP_BUY && cmd != OP_SELL) {
               OrderDelete(OrderTicket());
               }
            }
         }
      }
   }
}

int start()
  {
//----

for(cnt=OrdersTotal();cnt>=0;cnt--)
      {
         OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
         if( OrderMagicNumber()==770 )
            {
               if(OrderType()==OP_BUY)
                  {
                     CurrentProfit=Bid-OrderOpenPrice() ;
                     if(CurrentProfit>10*Point)
                        {
                           CloseAllOrders(770);
                        }
                  }
            }
      }   
//----
   return(0);
  }
//+------------------------------------------------------------------+

It seems it should work, just try it... But the programation is bad: if you have a trade with another MN, or a manual trade, you will enter in an endless loop (the while loop will never stop because you close only the orders fitting with a particular MN).

Dave137 · #**1026** (**permalink**) 04-01-2008, 02:30 AM

Realized I had the answer already!

winias · #**1027** (**permalink**) 04-01-2008, 02:58 AM

I just noticed this thread after I posted a new one....I think this would be a snap for some of you guys.....

EA building 101 question Need Help please!

I searched for an answer in advance but couldnt come up with much. Any ideas?

Thank you!

ajk · #**1028** (**permalink**) 04-01-2008, 03:30 AM

I want to code to hold a trade for 3 hours but the server time rolls over
from 23:00 to a new time.
How do I exit in 3 hours? ANy suggestions?

Dave137 · #**1029** (**permalink**) 04-03-2008, 10:45 PM

RSI = 5;

How do I find the number of the most recent bar back of the RSI that has the highest RSI and is also above 75, likewise the most number of the recent bar back of RSI that has the lowest RSI which is also below RSI of 25?

This has me puzzled! Can you help with the statement to solve this??

Much appreciation in advance for your time and effort!

Dave

Linuxser · #**1030** (**permalink**) 04-03-2008, 11:19 PM

Quote:

Originally Posted by Dave137

RSI = 5;

How do I find the number of the most recent bar back of the RSI that has the highest RSI and is also above 75, likewise the most number of the recent bar back of RSI that has the lowest RSI which is also below RSI of 25?

This has me puzzled! Can you help with the statement to solve this??

Much appreciation in advance for your time and effort!

Dave

Maybe:

Code:

         Lowest_RSI=MathMin(Lowest_RSI,iRSI(NULL,0,Periods,MODE,i));
         Highest_RSI=MathMax(Highest_RSI,iRSI(NULL,0,Periods,MODE,i));