Phoenix - Development+Suggestions - MQ4 in Post#1 - Page 42

Linuxser · #**411** (**permalink**) 01-17-2008, 11:07 AM

Quote:

Originally Posted by Togu

Thanks for the response but the link you gave is incorrect. It just redirects me to the whole Phoenix forum. Can you just tell me what version of Phoenix you using? Will be greatly appreciated.

You could start with this thread or this one is the stable

alkhal4 · #**412** (**permalink**) 01-17-2008, 03:42 PM

Has anyone tried using version 6 of the EA that is present on Phoenix - Development+Suggestions - MQ4 in Post#1

I have downloaded it and it doesn't seem to trade at all!
USDCHF M15 and all setting is as default but no trading

Could someone respond and clarify this issue

Do I need to do any thing to the settings?

Togu · #**413** (**permalink**) 01-26-2008, 03:46 AM

Quote:

Originally Posted by alkhal4

Has anyone tried using version 6 of the EA that is present on Phoenix - Development+Suggestions - MQ4 in Post#1

I have downloaded it and it doesn't seem to trade at all!
USDCHF M15 and all setting is as default but no trading

Could someone respond and clarify this issue

Do I need to do any thing to the settings?

I have the same problem. but I could run it on Omnivest-Omnivest Trading System but when I tried ODL it doesn't trade at all. With the Omnivest broker it was working. And so far I don't know how Phonenix was performing lately.

globus2008 · #**414** (**permalink**) 02-03-2008, 01:28 AM

Hello Alkhal4, Togu and all,

The Phoenix 6 Released doesn't work to you because originally extern variable "F_ATR" is set up on value 0.6 and it should be around 0.0001. But then when you run it you will find in a Journal a lot of "Ordermodify errors Nr.130". It is because there are bugs in functions "X1_ManageExit" and "X9_ModifySL". I have found two solutions not to display them :
1) Set up variable E_BE_SL=0 . But then you can not trade break even.
2) Replace these two functions "X1_ManageExit" and "X9_ModifySL" with my scripts in a source mq4 file. See below.

If you want and if you are not able to do it alone, I can send you this EA without these bugs but I don't want to upload EA here because it is in violation of Hendrick's wish -

Quote:

You can the change the code of Phoenix if you want to, but please don’t post it in this thread!

- see first post in Phoenix 2007 (new thread) .

This problem must have also others and I please a man who cares about source code of Phoenix (it was Hendrick, now daraknor ? - I don't know I have red only a couple of messages ) for debugging and putting correct version in the first post.

repared code of function "X1_ManageExit" :

Code:

//**********  Exit Strategies & Trailing Stops **********************************//
void X1_ManageExit(int myticket)
{ //Contains all of the exit strategies and trade management routines. Listed in priority.
    minStop=MarketInfo(Symbol(),MODE_STOPLEVEL); //updated every tick in case of news SL movement
  
    if(E_GraceHours !=0 ||E_ForceHours !=0) 
      X1_ForceClose_or_GraceModify(myticket);
  
    if(E_RecrossMax!=0)
      {
        double price;
          if (OrderType() == OP_BUY)   price=Bid;
          if (OrderType() == OP_SELL)  price=Ask;
          if(Bars>bcRecross)
            { //Bar hasn't been counted yet
              if(OrderOpenPrice()>price-1 && OrderOpenPrice()<price+1)
                {
                  recrosscount++;
                  bcRecross=Bars;

                  if (recrosscount>=E_RecrossMax)
                     if(!OrderClose(myticket,OrderLots(),price,AcceptSlip,Red)) 
                       L4_WriteError();
                }
              }
    
      }
  //TODO StealthExit  
  if(E_BE_SL>0)
  {  //    BreakEven SL @target
    if(E_BE_SL<E_BE_Profit+minStop) E_BE_Profit=E_BE_SL-minStop; //keeps trade safe all of the time
    if (OrderType() == OP_BUY && Bid-OrderOpenPrice()>=Point*E_BE_SL && OrderStopLoss()-Point*E_BE_Profit<OrderOpenPrice() && Bid-OrderOpenPrice()-E_BE_Profit*Point>=minStop*Point)
        X9_ModifySL(OrderOpenPrice()+E_BE_Profit*Point,myticket); 
    if (OrderType() == OP_SELL && OrderOpenPrice()-Ask>=Point*E_BE_SL+MarketInfo(Symbol(),MODE_SPREAD)*Point && OrderStopLoss()+Point*E_BE_Profit+MarketInfo(Symbol(),MODE_SPREAD)*Point>OrderOpenPrice() && OrderOpenPrice()+E_BE_Profit*Point+MarketInfo(Symbol(),MODE_SPREAD)*Point-Ask>=minStop*Point)
        X9_ModifySL(OrderOpenPrice()-E_BE_Profit*Point-MarketInfo(Symbol(),MODE_SPREAD)*Point,myticket); 
  }

repared code of function "X9_ModifySL" :

Code:

bool X9_ModifySL(double sl, int ticket)
  {
    double MoveTP;
    if(E_MoveTPonTS !=0)
    {
      if (OrderType() == OP_SELL) 
      {
        MoveTP=E_MoveTPonTS*(-1)*Point;
        if(Ask-OrderTakeProfit()+MoveTP<minStop*Point && sl-Ask>=minStop*Point) 
          MoveTP=minStop*Point*(-1)+Ask-OrderTakeProfit(); //Set the new distance to minimum safe point, -OTP() cancels OTP() // repared error 4051
      }
      else 
      {
        MoveTP=E_MoveTPonTS*Point;
        if(OrderTakeProfit()-Bid+MoveTP<minStop*Point && Bid-sl>=minStop*Point) 
          MoveTP=minStop*Point-Bid+OrderTakeProfit();  //Set the new distance to minimum safe point, -OTP() cancels OTP()
      }
    }
    
    if(U_WriteDebug) L3_WriteDebug("MODIFY Ticket:"+ticket+" OpenPrice:"+OrderOpenPrice()+" SL:"+sl+" TP:"+(OrderTakeProfit()+MoveTP*Point));
    if(NormalizeDouble(sl/Point,0)==NormalizeDouble(OrderStopLoss()/Point,0)) return(true);  
    if(OrderModify ( ticket, OrderOpenPrice(), sl,
                      OrderTakeProfit()+MoveTP,   
                      0, Red) ==(-1)) 
        return(false);
    else return(true);
  }

Behzad2008 · #**415** (**permalink**) 02-20-2008, 01:27 PM

Hello to all...

Which version of "Phoenix" is better?

"Hendrik's Phoenix" or "daraknor's Phoenix" ?

please tell me one...thanks

yoyo · #**416** (**permalink**) 02-21-2008, 07:08 PM

Hello globus2008,

Could you send me a private message, with your "Phoenix 6 Released" running version ?

Thanks,

yoyo

Quote:

Originally Posted by globus2008

Hello Alkhal4, Togu and all,

The Phoenix 6 Released doesn't work to you because originally extern variable "F_ATR" is set up on value 0.6 and it should be around 0.0001. But then when you run it you will find in a Journal a lot of "Ordermodify errors Nr.130". It is because there are bugs in functions "X1_ManageExit" and "X9_ModifySL". I have found two solutions not to display them :
1) Set up variable E_BE_SL=0 . But then you can not trade break even.
2) Replace these two functions "X1_ManageExit" and "X9_ModifySL" with my scripts in a source mq4 file. See below.

If you want and if you are not able to do it alone, I can send you this EA without these bugs but I don't want to upload EA here because it is in violation of Hendrick's wish - - see first post in Phoenix 2007 (new thread) .

This problem must have also others and I please a man who cares about source code of Phoenix (it was Hendrick, now daraknor ? - I don't know I have red only a couple of messages ) for debugging and putting correct version in the first post.

repared code of function "X1_ManageExit" :

Code:

//**********  Exit Strategies & Trailing Stops **********************************//
void X1_ManageExit(int myticket)
{ //Contains all of the exit strategies and trade management routines. Listed in priority.
    minStop=MarketInfo(Symbol(),MODE_STOPLEVEL); //updated every tick in case of news SL movement
  
    if(E_GraceHours !=0 ||E_ForceHours !=0) 
      X1_ForceClose_or_GraceModify(myticket);
  
    if(E_RecrossMax!=0)
      {
        double price;
          if (OrderType() == OP_BUY)   price=Bid;
          if (OrderType() == OP_SELL)  price=Ask;
          if(Bars>bcRecross)
            { //Bar hasn't been counted yet
              if(OrderOpenPrice()>price-1 && OrderOpenPrice()<price+1)
                {
                  recrosscount++;
                  bcRecross=Bars;

                  if (recrosscount>=E_RecrossMax)
                     if(!OrderClose(myticket,OrderLots(),price,AcceptSlip,Red)) 
                       L4_WriteError();
                }
              }
    
      }
  //TODO StealthExit  
  if(E_BE_SL>0)
  {  //    BreakEven SL @target
    if(E_BE_SL<E_BE_Profit+minStop) E_BE_Profit=E_BE_SL-minStop; //keeps trade safe all of the time
    if (OrderType() == OP_BUY && Bid-OrderOpenPrice()>=Point*E_BE_SL && OrderStopLoss()-Point*E_BE_Profit<OrderOpenPrice() && Bid-OrderOpenPrice()-E_BE_Profit*Point>=minStop*Point)
        X9_ModifySL(OrderOpenPrice()+E_BE_Profit*Point,myticket); 
    if (OrderType() == OP_SELL && OrderOpenPrice()-Ask>=Point*E_BE_SL+MarketInfo(Symbol(),MODE_SPREAD)*Point && OrderStopLoss()+Point*E_BE_Profit+MarketInfo(Symbol(),MODE_SPREAD)*Point>OrderOpenPrice() && OrderOpenPrice()+E_BE_Profit*Point+MarketInfo(Symbol(),MODE_SPREAD)*Point-Ask>=minStop*Point)
        X9_ModifySL(OrderOpenPrice()-E_BE_Profit*Point-MarketInfo(Symbol(),MODE_SPREAD)*Point,myticket); 
  }

repared code of function "X9_ModifySL" :

Code:

bool X9_ModifySL(double sl, int ticket)
  {
    double MoveTP;
    if(E_MoveTPonTS !=0)
    {
      if (OrderType() == OP_SELL) 
      {
        MoveTP=E_MoveTPonTS*(-1)*Point;
        if(Ask-OrderTakeProfit()+MoveTP<minStop*Point && sl-Ask>=minStop*Point) 
          MoveTP=minStop*Point*(-1)+Ask-OrderTakeProfit(); //Set the new distance to minimum safe point, -OTP() cancels OTP() // repared error 4051
      }
      else 
      {
        MoveTP=E_MoveTPonTS*Point;
        if(OrderTakeProfit()-Bid+MoveTP<minStop*Point && Bid-sl>=minStop*Point) 
          MoveTP=minStop*Point-Bid+OrderTakeProfit();  //Set the new distance to minimum safe point, -OTP() cancels OTP()
      }
    }
    
    if(U_WriteDebug) L3_WriteDebug("MODIFY Ticket:"+ticket+" OpenPrice:"+OrderOpenPrice()+" SL:"+sl+" TP:"+(OrderTakeProfit()+MoveTP*Point));
    if(NormalizeDouble(sl/Point,0)==NormalizeDouble(OrderStopLoss()/Point,0)) return(true);  
    if(OrderModify ( ticket, OrderOpenPrice(), sl,
                      OrderTakeProfit()+MoveTP,   
                      0, Red) ==(-1)) 
        return(false);
    else return(true);
  }

yoyo · #**417** (**permalink**) 02-21-2008, 07:20 PM

Hello Glogus2008,

Could you send me a "private messade" with your "Phoenix 6 Released" running version ?

Thanks,

yoyo

Quote:

Originally Posted by globus2008

Hello Alkhal4, Togu and all,

The Phoenix 6 Released doesn't work to you because originally extern variable "F_ATR" is set up on value 0.6 and it should be around 0.0001. But then when you run it you will find in a Journal a lot of "Ordermodify errors Nr.130". It is because there are bugs in functions "X1_ManageExit" and "X9_ModifySL". I have found two solutions not to display them :
1) Set up variable E_BE_SL=0 . But then you can not trade break even.
2) Replace these two functions "X1_ManageExit" and "X9_ModifySL" with my scripts in a source mq4 file. See below.

If you want and if you are not able to do it alone, I can send you this EA without these bugs but I don't want to upload EA here because it is in violation of Hendrick's wish - - see first post in Phoenix 2007 (new thread) .

This problem must have also others and I please a man who cares about source code of Phoenix (it was Hendrick, now daraknor ? - I don't know I have red only a couple of messages ) for debugging and putting correct version in the first post.

repared code of function "X1_ManageExit" :

Code:

//**********  Exit Strategies & Trailing Stops **********************************//
void X1_ManageExit(int myticket)
{ //Contains all of the exit strategies and trade management routines. Listed in priority.
    minStop=MarketInfo(Symbol(),MODE_STOPLEVEL); //updated every tick in case of news SL movement
  
    if(E_GraceHours !=0 ||E_ForceHours !=0) 
      X1_ForceClose_or_GraceModify(myticket);
  
    if(E_RecrossMax!=0)
      {
        double price;
          if (OrderType() == OP_BUY)   price=Bid;
          if (OrderType() == OP_SELL)  price=Ask;
          if(Bars>bcRecross)
            { //Bar hasn't been counted yet
              if(OrderOpenPrice()>price-1 && OrderOpenPrice()<price+1)
                {
                  recrosscount++;
                  bcRecross=Bars;

                  if (recrosscount>=E_RecrossMax)
                     if(!OrderClose(myticket,OrderLots(),price,AcceptSlip,Red)) 
                       L4_WriteError();
                }
              }
    
      }
  //TODO StealthExit  
  if(E_BE_SL>0)
  {  //    BreakEven SL @target
    if(E_BE_SL<E_BE_Profit+minStop) E_BE_Profit=E_BE_SL-minStop; //keeps trade safe all of the time
    if (OrderType() == OP_BUY && Bid-OrderOpenPrice()>=Point*E_BE_SL && OrderStopLoss()-Point*E_BE_Profit<OrderOpenPrice() && Bid-OrderOpenPrice()-E_BE_Profit*Point>=minStop*Point)
        X9_ModifySL(OrderOpenPrice()+E_BE_Profit*Point,myticket); 
    if (OrderType() == OP_SELL && OrderOpenPrice()-Ask>=Point*E_BE_SL+MarketInfo(Symbol(),MODE_SPREAD)*Point && OrderStopLoss()+Point*E_BE_Profit+MarketInfo(Symbol(),MODE_SPREAD)*Point>OrderOpenPrice() && OrderOpenPrice()+E_BE_Profit*Point+MarketInfo(Symbol(),MODE_SPREAD)*Point-Ask>=minStop*Point)
        X9_ModifySL(OrderOpenPrice()-E_BE_Profit*Point-MarketInfo(Symbol(),MODE_SPREAD)*Point,myticket); 
  }

repared code of function "X9_ModifySL" :

Code:

bool X9_ModifySL(double sl, int ticket)
  {
    double MoveTP;
    if(E_MoveTPonTS !=0)
    {
      if (OrderType() == OP_SELL) 
      {
        MoveTP=E_MoveTPonTS*(-1)*Point;
        if(Ask-OrderTakeProfit()+MoveTP<minStop*Point && sl-Ask>=minStop*Point) 
          MoveTP=minStop*Point*(-1)+Ask-OrderTakeProfit(); //Set the new distance to minimum safe point, -OTP() cancels OTP() // repared error 4051
      }
      else 
      {
        MoveTP=E_MoveTPonTS*Point;
        if(OrderTakeProfit()-Bid+MoveTP<minStop*Point && Bid-sl>=minStop*Point) 
          MoveTP=minStop*Point-Bid+OrderTakeProfit();  //Set the new distance to minimum safe point, -OTP() cancels OTP()
      }
    }
    
    if(U_WriteDebug) L3_WriteDebug("MODIFY Ticket:"+ticket+" OpenPrice:"+OrderOpenPrice()+" SL:"+sl+" TP:"+(OrderTakeProfit()+MoveTP*Point));
    if(NormalizeDouble(sl/Point,0)==NormalizeDouble(OrderStopLoss()/Point,0)) return(true);  
    if(OrderModify ( ticket, OrderOpenPrice(), sl,
                      OrderTakeProfit()+MoveTP,   
                      0, Red) ==(-1)) 
        return(false);
    else return(true);
  }

Pcontour · #**418** (**permalink**) 02-24-2008, 04:36 PM

Quote:

Originally Posted by Behzad2008

Hello to all...

Which version of "Phoenix" is better?

"Hendrik's Phoenix" or "daraknor's Phoenix" ?

please tell me one...thanks

How to find what I consider to be best working copy of Phoenix.

Click on the Search menu item at the very top (for the whole forum - not for this thread)
Paste the "Best Version of Phoenix" including the "
Select Show Posts.
Press GO
Find that phrase in the subject, and click that one from the list of Posts
Find that post on the page that comes up.
Read that whole post - the documentation is at the bottom and there is a link to the code.

comorg · #**419** (**permalink**) 03-03-2008, 05:15 AM

Downloaded Phoenix 5.6.3, installed in experts last night, compiled, placed in price chart:

in upper right. No trades placed overnight, this AM there was an x. I tried to compile again, blue icon in experts...removed it from price window, double click, and smiley briefly appears, then switches to x. What is going on? Thanks for help.

alkhal4 · #**420** (**permalink**) 03-03-2008, 10:41 AM

Hello

Thanks for your response, I tried to do what you suggested below,
I replaced the codes but when compiling I get an error - probably because I don't know how to do step 1 - could you send the correct code.

Thanks

Quote:

Originally Posted by globus2008

Hello Alkhal4, Togu and all,

The Phoenix 6 Released doesn't work to you because originally extern variable "F_ATR" is set up on value 0.6 and it should be around 0.0001. But then when you run it you will find in a Journal a lot of "Ordermodify errors Nr.130". It is because there are bugs in functions "X1_ManageExit" and "X9_ModifySL". I have found two solutions not to display them :
1) Set up variable E_BE_SL=0 . But then you can not trade break even.
2) Replace these two functions "X1_ManageExit" and "X9_ModifySL" with my scripts in a source mq4 file. See below.

If you want and if you are not able to do it alone, I can send you this EA without these bugs but I don't want to upload EA here because it is in violation of Hendrick's wish - - see first post in Phoenix 2007 (new thread) .

This problem must have also others and I please a man who cares about source code of Phoenix (it was Hendrick, now daraknor ? - I don't know I have red only a couple of messages ) for debugging and putting correct version in the first post.

repared code of function "X1_ManageExit" :

Code:

//**********  Exit Strategies & Trailing Stops **********************************//
void X1_ManageExit(int myticket)
{ //Contains all of the exit strategies and trade management routines. Listed in priority.
    minStop=MarketInfo(Symbol(),MODE_STOPLEVEL); //updated every tick in case of news SL movement
  
    if(E_GraceHours !=0 ||E_ForceHours !=0) 
      X1_ForceClose_or_GraceModify(myticket);
  
    if(E_RecrossMax!=0)
      {
        double price;
          if (OrderType() == OP_BUY)   price=Bid;
          if (OrderType() == OP_SELL)  price=Ask;
          if(Bars>bcRecross)
            { //Bar hasn't been counted yet
              if(OrderOpenPrice()>price-1 && OrderOpenPrice()<price+1)
                {
                  recrosscount++;
                  bcRecross=Bars;

                  if (recrosscount>=E_RecrossMax)
                     if(!OrderClose(myticket,OrderLots(),price,AcceptSlip,Red)) 
                       L4_WriteError();
                }
              }
    
      }
  //TODO StealthExit  
  if(E_BE_SL>0)
  {  //    BreakEven SL @target
    if(E_BE_SL<E_BE_Profit+minStop) E_BE_Profit=E_BE_SL-minStop; //keeps trade safe all of the time
    if (OrderType() == OP_BUY && Bid-OrderOpenPrice()>=Point*E_BE_SL && OrderStopLoss()-Point*E_BE_Profit<OrderOpenPrice() && Bid-OrderOpenPrice()-E_BE_Profit*Point>=minStop*Point)
        X9_ModifySL(OrderOpenPrice()+E_BE_Profit*Point,myticket); 
    if (OrderType() == OP_SELL && OrderOpenPrice()-Ask>=Point*E_BE_SL+MarketInfo(Symbol(),MODE_SPREAD)*Point && OrderStopLoss()+Point*E_BE_Profit+MarketInfo(Symbol(),MODE_SPREAD)*Point>OrderOpenPrice() && OrderOpenPrice()+E_BE_Profit*Point+MarketInfo(Symbol(),MODE_SPREAD)*Point-Ask>=minStop*Point)
        X9_ModifySL(OrderOpenPrice()-E_BE_Profit*Point-MarketInfo(Symbol(),MODE_SPREAD)*Point,myticket); 
  }

repared code of function "X9_ModifySL" :

Code:

bool X9_ModifySL(double sl, int ticket)
  {
    double MoveTP;
    if(E_MoveTPonTS !=0)
    {
      if (OrderType() == OP_SELL) 
      {
        MoveTP=E_MoveTPonTS*(-1)*Point;
        if(Ask-OrderTakeProfit()+MoveTP<minStop*Point && sl-Ask>=minStop*Point) 
          MoveTP=minStop*Point*(-1)+Ask-OrderTakeProfit(); //Set the new distance to minimum safe point, -OTP() cancels OTP() // repared error 4051
      }
      else 
      {
        MoveTP=E_MoveTPonTS*Point;
        if(OrderTakeProfit()-Bid+MoveTP<minStop*Point && Bid-sl>=minStop*Point) 
          MoveTP=minStop*Point-Bid+OrderTakeProfit();  //Set the new distance to minimum safe point, -OTP() cancels OTP()
      }
    }
    
    if(U_WriteDebug) L3_WriteDebug("MODIFY Ticket:"+ticket+" OpenPrice:"+OrderOpenPrice()+" SL:"+sl+" TP:"+(OrderTakeProfit()+MoveTP*Point));
    if(NormalizeDouble(sl/Point,0)==NormalizeDouble(OrderStopLoss()/Point,0)) return(true);  
    if(OrderModify ( ticket, OrderOpenPrice(), sl,
                      OrderTakeProfit()+MoveTP,   
                      0, Red) ==(-1)) 
        return(false);
    else return(true);
  }

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

LinkBacks (?) LinkBack to this Thread: http://www.forex-tsd.com/phoenix/4636-phoenix-development-suggestions-mq4-post-1-a.html
Posted By	For	Type	Date
Forex Factory - Phoenix 2007 (new thread)	This thread	Refback	06-27-2008 05:56 PM
Phoenix 2007 (new thread) - Page 60	This thread	Refback	06-22-2008 10:34 PM
Forex Factory - Phoenix 2007 (new thread)	Post #1	Refback	06-22-2008 11:31 AM
Forex Factory - Phoenix 2007 (new thread)	This thread	Refback	04-27-2008 01:55 PM
Phoenix 2007 (new thread) - Page 65	Post #1	Refback	04-20-2008 03:13 PM
Phoenix 2007 (new thread) - Page 65	Post #1	Refback	04-01-2008 09:32 AM
Forex Factory - Phoenix 2007 (new thread)	This thread	Refback	02-11-2008 06:45 PM
Phoenix 2007 (new thread) - Page 65	Post #1	Refback	02-06-2008 07:35 PM
Forex Factory - Phoenix 2007 (new thread)	This thread	Refback	01-08-2008 10:37 PM
Phoenix - Page 2 - Fxopen forex forum - forex review - trading methods - education - analytics	This thread	Refback	12-26-2007 09:22 AM
Phoenix 2007 (new thread) - Page 65	Post #1	Refback	11-27-2007 06:54 PM
Phoenix 2007 (new thread) - Page 65	Post #1	Refback	11-05-2007 01:10 PM
Firebird EA - fixed version - - Page 109	This thread	Refback	10-27-2007 12:21 PM
Phoenix 2007 (new thread) - Page 61	This thread	Refback	10-14-2007 10:13 PM
Forex Factory - Phoenix 2007 (new thread)	Post #1	Refback	09-30-2007 10:23 PM
Phoenix 2007 (new thread) - Page 65	Post #1	Refback	09-25-2007 07:22 PM
Phoenix 2007 (new thread) - Page 65	Post #1	Refback	08-16-2007 04:57 PM

Register in Forex TSD!
Trading Systems Leaders in this forum (automated trading systems) are winning more than 3000 pips in a month (30000$ investing one lot every time). Click here to register and get more information