Originally Posted by daraknor

I have been following this. Did you comment out the Refresh Quotes line for your live trading?

Originally Posted by Wackena

I will try commenting out RefreshRates line.

Not sure, but I think this may be the problem. If OrderModify is like OrderSend, then it must have the spread difference between current Ask/Bid and new Stoploss level.
If OrderProfit is very low, OrderOpenPrice may be too close to current Ask/Bid, then the spread may come into play.
Again, not sure, just a thought.

Originally Posted by Pcontour

Quote:
Originally Posted by Pcontour
Background

I've been working in Computers for 25 years. I've developed programming standards myself. Your code is top notch.

Proposition

I would like to have a chance to apply a bunch of changes to your code to make it easier to understand for Forex beginners like myself and for people who are not coders. These would be user friendly changes. Nothing radical would make sense, as it's excellent already.

Benefits

1. It would be easier for you to find your own functions in your own program.

2. It would be easier for others to come up to speed and make some useful suggestions. I get confused at times and can't tell the difference between your functions and MT4 functions. People will have less questions.

3. Would give you a better base for future developments for both your code and other code that might be based on the same basic structure as your program.

4. The beauty of your code is how you could use the same phoenix strategy with different indicators. Your code getting to the point of plug and play, you can easily switch pieces.

5. Once you see what I do, you can improve on it in ways that I wouldn't think of.

6. If you don't like it, you don't have to use it.

What do I want

All I need is a window where you are not making changes, so I don't do work on the wrong version.

What I'm hoping for is a code base that anyone could work from to develop new Experts. We would benefit as a community if all the programs looked the same and we could look at and understand other peoples code and help each other out faster.

This is my way to contribute by doing what I'm good at.

I'm new to the forum and don't want to miss your reply so please mail me directly.


Quote:
Reply by Hendrick

Hi,

I like this very much:
"What I'm hoping for is a code base that anyone could work from to develop new Experts"

Have you visit the developers part of the Phoenix thread? At the moment I'm not working on Phoenix (I needed a break).


Reply by Pcontour

The code is attached with some additional information.

Tested to ensure the result were the same as before.

Tested Mode1, 2 and 3

Tested Mode 2 - close trade after x hours
Tested Mode 2 - close trade 1 when opening trade 2 (true and false)

I hope you like it.

Originally Posted by alamanjani

This sounds (and looks) like great idea!

Mario

Originally Posted by yeremeyv

I did some testing of 5.6.7a, and I was a bit impressed by the low results, especially if comprared with earlier versions. Risk: 1.4; Currencies: USDJPY, EURUSD; Time periods: 2006.06.24->2006.12.06, 2005.06.24->2006.12.06; Broker: FXDD

Originally Posted by daraknor

His version isn't really 5.6.4, it is 5.6.3 with renamed variables and functions. Hopefully we will collaborate on development but I really would like to avoid renaming the variables for settings file compatibility. Since we don't have any settings files posted at all, it is less of a concern :/