How to code? - Page 42

wolfe · #**411** (**permalink**) 10-12-2007, 01:40 AM

Quote:

Originally Posted by jimven

Save the current bar's highest quoted value to a variable. Every time you get another quote, compare it with the value of the variable. If the new value is higher, save it to the variable. If the new value is lower, keep the variable the same.

if(variable < newquote)
variable = newquote;

Hope that helps!

Thank you for the help, I have one question though. What happens when the current bar is no longer the bar that the order opened in? What if the order opened in the bar 5 bars ago? Now I want the highest quoted value of 5 bars, the highest quoted price since the order opened. Will this still work?

Thanks

wolfe · #**412** (**permalink**) 10-12-2007, 01:43 AM

Quote:

Originally Posted by jimven

Save the current bar's highest quoted value to a variable. Every time you get another quote, compare it with the value of the variable. If the new value is higher, save it to the variable. If the new value is lower, keep the variable the same.

if(variable < newquote)
variable = newquote;

Hope that helps!

Now that I think about it, your suggestion will probably work. Thank you! I'll try it out.

jimven · #**413** (**permalink**) 10-12-2007, 05:06 PM

Quote:

Originally Posted by wolfe

Now that I think about it, your suggestion will probably work. Thank you! I'll try it out.

Good. When the trade position is closed, you want to set the variable to zero. When the next trade opens, you start the process again.

Of course my example was for a "BUY" position. For "SELL," you want to get the lowest value saved.

waaustin · #**414** (**permalink**) 10-12-2007, 06:25 PM

Could anyone share with what syntax and instructions I would use in mql to write some code in EA using the following:

(OrderProfit() < 0).

Except I really want to know when OrderProfit() is some specific value less than zero such as when the profit on an open trade is -1,250.00. For example:

if (OrderProfit() < -1,250.00).

Thanks

wolfe · #**415** (**permalink**) 10-13-2007, 01:49 AM

Quote:

Originally Posted by waaustin

Could anyone share with what syntax and instructions I would use in mql to write some code in EA using the following:

(OrderProfit() < 0).

Except I really want to know when OrderProfit() is some specific value less than zero such as when the profit on an open trade is -1,250.00. For example:

if (OrderProfit() < -1,250.00).

Thanks

I think you have the right idea. However you would probably want to use if (OrderProfit() <= -1250.00) Your OrderProfit() may never = -1,250.00, especially if a position is held for more than a day and swaps are involved. I think you would be safer to use less than or equal (<=). You may want to set an external double variable so you can change the negative amount if you wish to. Such as external double Loss_Value = -1250.00; then you could use if (OrderProfit() <= Loss_Value).

Hope this helps

vonokpasah · #**416** (**permalink**) 10-13-2007, 06:57 PM

I am appealing to the experts out there to please come to my aid i need some to help me buld an EXPERT ADVISER META 4 TRADER for me i would be greatfull if my request is granted.

newdigital · #**417** (**permalink**) 10-14-2007, 08:02 AM

Quote:

Originally Posted by vonokpasah

I am appealing to the experts out there to please come to my aid i need some to help me buld an EXPERT ADVISER META 4 TRADER for me i would be greatfull if my request is granted.

Hi vonokpasah,

Just for information: we are having few very good threads with templates to create EAs and indicators. For example:

Templates to create EAs and Indicators:
- some good templates are here;
- templates with some new codes are here.
- Programming Modules with many programming functions are here.
- function of "mql4 code": thread with codes.

To use those templates and to create your own EA so you will need some very preliminary knowledge and it is basicly related to this thread http://www.forex-tsd.com/general-dis...der-forex.html

If you don't want to do some routine coding so you may automate this job: use this EA builder Expert Advisor Builder for MetaTrader 4 (it is free) and use this program Forex Trading with Gordago Forex Broker - Best Forex Software for Creating Forex Trading System! (I bought it for $9 long time ago - don't know about the price now). But to use those builders so you will need this thread first with Codersguru lessans http://www.forex-tsd.com/general-dis...der-forex.html

jimven · #**418** (**permalink**) 10-15-2007, 03:01 AM

Remember that any time you store data to temporary variables in an EA, the data will be gone if you reinitialize or restart the EA (or reboot your computer). This could have unexpected consequences regarding your trades. One possibility is that open trades will close, for example.

You can store data to Global Variables (using GlobalVariableSet and GlobalVariableGet). They remain in the terminal for two weeks (I think), even if undisturbed by your EA. But of course such data could quickly become just as problematic as lost data if you have a computer equipment problem.

In any event, your EA should be written defensively to prepare for loss of connection and the possibility of reinitialization.

Flytox · #**419** (**permalink**) 10-15-2007, 04:41 PM

Good Day
i'am learning mql4 and have difficulties to understand some functions example:

Code:

 for( shift=limit; shift>=0; shift--)
   {
   double RSI = iRSI(NULL,0,RSILength,PRICE_CLOSE,shift);
   SmRSI[shift]= SmRSI[shift+1] + 2./(Smooth+1)*(RSI - SmRSI[shift+1]);  
   
      if(SmRSI[shift] > SmRSI[shift+1]) {double hRSI = SmRSI[shift]; double lRSI = SmRSI[shift+1];}
      else 
      if(SmRSI[shift] < SmRSI[shift+1]) {hRSI = SmRSI[shift+1]; lRSI = SmRSI[shift];}
      else
      {hRSI = SmRSI[shift]; lRSI = SmRSI[shift];}
   
   ATRRSI[shift] = hRSI - lRSI;

I don't see how it is possible to know SmRSI value with the following line, knowing that it has not been defined before and seems to me mathematically impossible.

Code:

SmRSI[shift]= SmRSI[shift+1] + 2./(Smooth+1)*(RSI - SmRSI[shift+1]);

Could anyone explain please.
PS: it's a pîece of code from Igorad trendstrength indi.
Thnaks

Flytox · #**420** (**permalink**) 10-15-2007, 06:41 PM

May be i understood the code above:
We can affect a value to smRsi because it use the same index then the iRsi().
Can someone confirm this ?