the problem is that u are using Ask and Bid for the price.
Try to use : MarketInfo(OrderSymbol(),MODE_BID) and MarketInfo(OrderSymbol(),MODE_ASK) instead

elihayun,

It makes sense & thanks a lot. I'll try to use MarketInfo() function.

I AM WRITING AND INDICATOR IN MQL4 THAT MEASURES THE BANDWIDTH BETWEEN UPPER AND LOWER BOLLINGER BANDS... FOR SOME REASON WHEN INSTALLED IN THE TRADING TERMINAL NO LINE IS PLOTTED IN THE INDICATOR WINDOW!... I KNOW THE MATH IS WORKING AS THE CORRECT VALUE OF BANDWIDTH IS DISPLAYED IN THE UPPER LEFT-HAND CORNER OF THE INDICATOR WINDOW AS THE PRICE CHANGES. WHY MIGHT THIS BE HAPPENING? I SUSPECT THERE IS SOME SIMPLE THING WRONG WITH MY CODE AS I ONLY BEGAN LEARNING TO PROGRAM 3 DAYS AGO. ANY HELP WOULD BE GREAT!... WHAT LINES OF CODE NEED TO BE ALTERED?

THANKS,
RYAN




//+------------------------------------------------------------------+
//| Band Width of Bollinger Bands .mq4 |
//| Copyright © 2006, Ghostrider Capital LLC. |
//| ryanjmcgregor@tds.net |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2006, Ghostrider Capital LLC."
#property link "ryanjmcgregor@tds.net"

#property indicator_separate_window
#property indicator_buffers 4
#property indicator_color1 DodgerBlue
#property indicator_maximum 1.5
#property indicator_minimum -0.5


//---- indicator parameters
extern int BandsPeriod=20;
extern int BandsShift=0;
extern double BandsDeviations=2.0;
//---- buffers
//---- Moving, Upper, and Lower are for counting to draw Band Width 20
double BandWidth20Buffer[];
double MovingBuffer[];
double UpperBuffer[];
double LowerBuffer[];

//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int init()
{
//---- indicators
SetIndexStyle(0,DRAW_LINE,STYLE_SOLID,2,DodgerBlue );
SetIndexBuffer(0,BandWidth20Buffer);
SetIndexLabel(0,"Band Width 20");

SetIndexBuffer(1,MovingBuffer);
SetIndexBuffer(2,UpperBuffer);
SetIndexBuffer(3,LowerBuffer);

//----
//---- 4 Indicators Buffers Mapping
SetIndexDrawBegin(0,0);
// SetIndexDrawBegin(1,BandsPeriod+BandsShift);
// SetIndexDrawBegin(2,BandsPeriod+BandsShift);
// SetIndexDrawBegin(3,BandsPeriod+BandsShift);
IndicatorDigits(MarketInfo(Symbol(),MODE_DIGITS)+2 );
IndicatorShortName("Band Width of 20 2.0 BB");
//----
return(0);
}
//+------------------------------------------------------------------+
//| Bollinger Bands |
//+------------------------------------------------------------------+
int start()
{
int i,k,counted_bars=IndicatorCounted();
double deviation;
double sum,oldval,newres,upper,lower,middle;

//----
if(Bars<=BandsPeriod) return(0);
//---- initial zero
if(counted_bars<1)
for(i=1;i<=BandsPeriod;i++)
{
MovingBuffer[Bars-i]=EMPTY_VALUE;
UpperBuffer[Bars-i]=EMPTY_VALUE;
LowerBuffer[Bars-i]=EMPTY_VALUE;
BandWidth20Buffer[Bars-i]=EMPTY_VALUE;
}
//----
int limit=Bars-counted_bars;
if(counted_bars>0) limit++;
for(i=0; i<limit; i++)
MovingBuffer[i]=iMA(NULL,0,BandsPeriod,BandsShift,MODE_SMA,PRICE_ CLOSE,i);
middle=MovingBuffer[i];
//----
i=Bars-BandsPeriod+1;
if(counted_bars>BandsPeriod-1) i=Bars-counted_bars-1;
while(i>=0)
{
sum=0.0;
k=i+BandsPeriod-1;
oldval=MovingBuffer[i];
while(k>=i)
{
newres=Close[k]-oldval;
sum+=newres*newres;
k--;
}
deviation=BandsDeviations*MathSqrt(sum/BandsPeriod);
UpperBuffer[i]=oldval+deviation;
LowerBuffer[i]=oldval-deviation;
upper=UpperBuffer[i];
lower=LowerBuffer[i];
//---- Formula Band Width = (Upper - Lower) / Middle Band moving sma
BandWidth20 Buffer[i]=(upper-lower)/middle;

i--;
}
//----
return(0);
}
//+------------------------------------------------------------------+

Can someone please explain what these lines of code mean/do? :

SetIndexDrawBegin(0,BandsPeriod+BandsShift);
SetIndexDrawBegin(1,BandsPeriod+BandsShift);
SetIndexDrawBegin(2,BandsPeriod+BandsShift);
SetIndexDrawBegin(3,BandsPeriod+BandsShift);

hi,

Suposse that you have an indicator with 4 lines. This code, says to the 4 lines where they have to start.

THe 1st parameter is the line index or id (usually: from 0 to 9 . is´t correct?).
The 2nd one is how many bars ago from current one must to start the line.

Correct me if I wrong

Good luck!

suppressed - to basic - without interest - sorry

I am trying to come up with a profitable strategy using this indicator--4 period ma. I used to trade live successfully using a similar indicator that I don't have access to anymore. I can't seem to find the optimal settings on 4pma i.e. ma length, method, etc.
Would anybody who can read MQL4 code be able to tell me how this indicator is constructed--how do you determine the hi and lo levels(they are the dynamic fibo levels), how do you determine the lcf and hcf levels? I understand the ma1, ma2, ma3 are moving averages, which lenght and method of calculation can be set by the user--ex. simple moving average, 13 period. It doesn't look like the default settings are optimal. That is why I am trying to understand how it works so that I can fix it.
The indicator is attached below.
Any help is appreciated.

Attached Files

4_Period_MA.mq4 (46.6 KB, 54 views)

Ive got an EA that doesnt seem to open Buy orders. Perhaps there is an error in the code????
//+------------------------------------------------------------------+
//| Open buy | |
//+------------------------------------------------------------------+
if (!ExistPositions()){
if ((Ask < Op && Tenkan >= Kijun&&PrClose<Kijun/* &&BandUp4>BandUp12 */ ))
/*Hi-Lo > LongBar*Point ex PRG
/* PrClose>BandUp4&& PrClose>LWMA &&LWMA>LWMA20 /*&&BandUp4>BandUp12 */
{
OpenBuy();
return(0);
}


Thanks in advance,
Efextrader

Can someone fix this indicator so that it doesn't paint the past?


Thanks in advance!

Attached Files

#00_ZZ_Window.mq4 (7.1 KB, 46 views)

You need to have a professional programmer handle this EA. I recommend Yaroslav at Forex-Experts.com.