Yeah thanks for offering to help, i have fixed the problem already, it was a problem with my indicator.
However i noticed that my EA doesn't trade according to the Buy or Sell Arrows, here's my EA code.
Thanks in advance for your prompt reply,
//+------------------------------------------------------------------+
//| Anubis.mq4 |
//| Copyright © 2008, Sola Ajayi, NerdyMonk |
//| shollylabor@gmail.com |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2008, Sola Ajayi, NerdyMonk"
#property link "shollylabor@gmail.com"

extern double TakeProfit = 500;
extern double Lots = 1;
extern double TrailingStop = 200;

double SS_SELL_0=0, SS_BUY_0=0;
bool SSIsBuy=false, SSIsSell=false;

//+------------------------------------------------------------------+
//| expert initialization function |
//+------------------------------------------------------------------+
int init()
{
//----

//----
return(0);
}
//+------------------------------------------------------------------+
//| expert deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
//----

//----
return(0);
}
//+------------------------------------------------------------------+
//| expert start function |
//+------------------------------------------------------------------+
int start()
{
int cnt,ticket,total;

SS_SELL_0 = iCustom(Symbol(),Period(),"zeus",4,0,0);
SS_BUY_0 = iCustom(Symbol(),Period(),"zeus",4,1,0);

if (SS_SELL_0 > 0) {SSIsSell=true;SSIsBuy=false;}
if (SS_BUY_0 > 0) {SSIsSell=false;SSIsBuy=true;}

if(Bars<100)
{
Print("bars less than 100");
return(0);
}
if(TakeProfit<10)
{
Print("TakeProfit less than 10");
return(0); // check TakeProfit
}
total=OrdersTotal();
if(total<1)
{
// no opened orders identified
if(AccountFreeMargin()<(1000*Lots))
{
Print("We have no money. Free Margin = ", AccountFreeMargin());
return(0);
}
if(SSIsBuy == true)
{
ticket=OrderSend(Symbol(),OP_BUY,Lots,Ask,3,0,Ask+ TakeProfit*Point,"zeus",16384,0,Green);
if(ticket>0)
{
if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES )) Print("BUY order opened : ",OrderOpenPrice());
}
else Print("Error opening BUY order : ",GetLastError());
return(0);
}
if(SSIsSell == true)
{
ticket=OrderSend(Symbol(),OP_SELL,Lots,Bid,3,0,Bid-TakeProfit*Point,"zeus",16384,0,Red);
if(ticket>0)
{
if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES )) Print("SELL order opened : ",OrderOpenPrice());
}
else Print("Error opening SELL order : ",GetLastError());
return(0);
}
return(0);
// it is important to enter the market correctly,
// but it is more important to exit it correctly...
for(cnt=0;cnt<total;cnt++)
{
OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
if(OrderType()<=OP_SELL && // check for opened position
OrderSymbol()==Symbol()) // check for symbol
{
if(OrderType()==OP_BUY) // long position is opened
{
// should it be closed?
if(SSIsSell == true)
{
OrderClose(OrderTicket(),OrderLots(),Bid,3,Violet) ; // close position
return(0); // exit
}
// check for trailing stop
if(TrailingStop>0)
{
if(Bid-OrderOpenPrice()>Point*TrailingStop)
{
if(OrderStopLoss()<Bid-Point*TrailingStop)
{
OrderModify(OrderTicket(),OrderOpenPrice(),Bid-Point*TrailingStop,OrderTakeProfit(),0,Green);
return(0);
}
}
}
}
else // go to short position
{
// should it be closed?
if(SSIsBuy == true)
{
OrderClose(OrderTicket(),OrderLots(),Ask,3,Violet) ; // close position
return(0); // exit
}
// check for trailing stop
if(TrailingStop>0)
{
if((OrderOpenPrice()-Ask)>(Point*TrailingStop))
{
if((OrderStopLoss()>(Ask+Point*TrailingStop)) || (OrderStopLoss()==0))
{
OrderModify(OrderTicket(),OrderOpenPrice(),Ask+Poi nt*TrailingStop,OrderTakeProfit(),0,Red);
return(0);
}
}
}
}
}
}
}
return(0);
}
//+------------------------------------------------------------------+

This is my firs EA. It uses 2 rsi's crossing in 3 time frames. I have a problem with the ea taking trades against the crosses. Buying when it is supposed to sell, sell when suppose to buy. Could someone please look at the code and tell me where I went wrong. I haven't been able to see anything wrong.


I have attached the ea and a pic of the problem.

Attached Images

rsi wrong entry.gif (59.3 KB, 120 views)

Attached Files

RSI_Test.mq4 (10.9 KB, 18 views)

Hi all,


As you know the fx market is 24 hours, I am not comfortable to trade overnight without sitting in front of PC. So I am thinking the best way is program to protect the trade if the price moves towards my favorite direction. For example, if I opened 5 lots in total, when the profit is above 50 pips, it automatically move stop loss to break even. When the profit is above 100 pips, it moves to protect 30 pips.When the profit is above 200 pips, it moves to protect 50 pips. and so on.

I tried to code my self. But it doesn't work when I drag it into my chart and set it trading live. Any body could help me to have a look of my code and fix it? Many thanks.


#property copyright "x li"
#property link ""
#property show_confirm

//---- input parameters
extern int target1 =50;
extern int target2 =100;
extern int target3 =150;
extern int target4 =200;
extern int target5 =300;

extern int protect1 =0;
extern int protect2 =5;
extern int protect3 =50;
extern int protect4 =100;



//+-----------------------------------------------------------------------------+
//| script "move stoploss to protect(50->0;100->5;150->50;200->50;300->100)" |
//+-----------------------------------------------------------------------------+

int start()
{
bool result;
double stop_loss,point,EntryPrice,profit;
int cmd,total,error,i;
//----
total=OrdersTotal();
point=MarketInfo(Symbol(),MODE_POINT);
//----
for(i=0; i<total; i++)
{
if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES))
{
cmd=OrderType();
EntryPrice=OrderOpenPrice();

//---- buy orders are considered
if(cmd==OP_BUY)
{
profit=Bid-EntryPrice;

if(profit>target1*point && profit<target2*point)
{
stop_loss=EntryPrice+protect1*point;
result=OrderModify(OrderTicket(),0,stop_loss,0,0,C LR_NONE);
}
if(profit>target2*point && profit<target3*point)
{
stop_loss=EntryPrice+protect2*point;
result=OrderModify(OrderTicket(),0,stop_loss,0,0,C LR_NONE);
}
if(profit>target3*point && profit<target4*point)
{
stop_loss=EntryPrice+protect3*point;
result=OrderModify(OrderTicket(),0,stop_loss,0,0,C LR_NONE);
}
if(profit>target4*point && profit<target5*point)
{
stop_loss=EntryPrice+protect3*point;
result=OrderModify(OrderTicket(),0,stop_loss,0,0,C LR_NONE);
}
if(profit>target5*point)
{
stop_loss=EntryPrice+protect4*point;
result=OrderModify(OrderTicket(),0,stop_loss,0,0,C LR_NONE);
}
}
//---- sell orders are considered
if(cmd==OP_SELL)
{
profit=EntryPrice-Ask;

if(profit>target1*point && profit<target2*point)
{
stop_loss=EntryPrice-protect1*point;
result=OrderModify(OrderTicket(),0,stop_loss,0,0,C LR_NONE);
}
if(profit>target2*point && profit<target3*point)
{
stop_loss=EntryPrice-protect2*point;
result=OrderModify(OrderTicket(),0,stop_loss,0,0,C LR_NONE);
}
if(profit>target3*point && profit<target4*point)
{
stop_loss=EntryPrice-protect3*point;
result=OrderModify(OrderTicket(),0,stop_loss,0,0,C LR_NONE);
}
if(profit>target4*point && profit<target5*point)
{
stop_loss=EntryPrice-protect3*point;
result=OrderModify(OrderTicket(),0,stop_loss,0,0,C LR_NONE);
}
if(profit>target5*point)
{
stop_loss=EntryPrice-protect4*point;
result=OrderModify(OrderTicket(),0,stop_loss,0,0,C LR_NONE);
}
}
}
else { Print( "Error when order select ", GetLastError()); break; }
}
//----
return(0);
}
//+------------------------------------------------------------------+

I do not see why you use the same variable to open and to close trades, but it may work.

This may be the problem:
"Order" is a global variable. So at the end of each run through the Start function it will be set to the last value it was assigned, and use that value for the beginning of the next run through. It you make it local (move it inside Start) it may fix it. Else you will have to reset it after last use of it.

Good Hunting,

Big Be

I am quite sure that your indicator repaints at least the current bar.

In your EA, in the iCustom() function you use the current bar (the last 0). Try to check the signal only at bar close (set the last number to 1). Then at the first tick of the new candle, if the arrow is still there (and not repaint), the trade won't be a false signal.

Note that I didn't checked it it repaints more than the current bar. But you get the idea.

FerruFx

__________________
FerruFx / www.ervent.net - Professional Coding Services (EAs/Indicators/Alerts)

BBVPS.com - Reliable Windows VPS For MT4 Hosting

I have a problem with an EA modifying orders from other EA's and Manual Trades. I use multiple EA's - some that modify the orders but the EA's that modify the orders take into account orders not associated with the EA. How can I have it only modify orders pretaining to a particular EA and not every order that is open for that currency. Thanks.

Kevin

Hello!
Each ea can mark his orders by magic number. Use it to search in order pool for orders that you wish to be modified. In this case you can have other orders separated.

__________________
You need proffesional mql coder? Contact me! I will help you!
........................................
http://www.fxservice.eu/
........................................

Hello,
I find coder for this.
Is there somebody who can develop a EA to calculate the pips month.
Look at the example below.



if i give you EA source code to count pip can you change it in order it can works for all brokers because from now on it only works for FXDD.

Hi fungraphic. I moved your post.

I know you must have some hurry bue there is not need to post same twice. If somebody is interest in help it would reply.

__________________

I need code for using the moving average as a stoploss. The stoploss would change as the moving average changed so it would effectively be an adaptive stoploss based upon the moving average. Thanks