EA Opening Too Many Trades

samuelabyrd · #1 (**permalink**) 05-24-2009, 04:51 AM

Hello all, first of all I've searched this site for an answer to my question and not found a clear answer.

I'm using Expert Advisor Builder for Meta Trader 4 Expert Advisor Builder for MetaTrader 4 to create an EA. The problem I have is that the EA opens a trade whenever:

A. the defined rules for opening a trade at the beginning of a new bar (ex. 1 hour) are true.

AND

B. if a trade opened as a result of the above has closed, and the defining bar (ex. 1 hour) is still active.

I'd like to know how to script or define additional rules so the EA will not continually open trades, within the same bar, if a trade had already been opened based upon the rules. I guess another way to state it is how do limit the EA to opening no more than one trade per hour or defined time frame or bar.

Thanks in advance to anyone who can offer a clear concise solution.

auto · #2 (**permalink**) 05-24-2009, 05:13 AM

There are many way to do it .. but the simplest way to limit 1 trade per hour is to use ..

int Fixed = 100;
int MagicNumber = Fixed + Hour();

and check for orders with that magic no. before sending new orders.

regards.

davidke20 · #3 (**permalink**) 05-24-2009, 11:05 AM

Code:

 
extern double TakeProfit=10;
extern double StopLoss=10;
extern MagicNumber=772188;
datetime Stamp=0;
 
int start()
{
  double MA1=iMA(NULL,0,10,0,MODE_SMA,PRICE_CLOSE,0);
  double MA2=iMA(NULL,0,20,0,MODE_SMA,PRICE_CLOSE,0);
  double MA3=iMA(NULL,0,10,0,MODE_SMA,PRICE_CLOSE,1);
  double MA4=iMA(NULL,0,20,0,MODE_SMA,PRICE_CLOSE,1);
// MA crossed
if(MA1>MA2 && MA3<MA4 && Stamp!=iTime(NULL,0,0))
{
   result=OrderSend(OrderSend(Symbol(),OP_SELL,Lots,Bid,3,Ask+StopLoss*Point,Bid-TakeProfit*Point,NULL,MagicNumber,0,Red)
   if(result>1)
Stamp=iTime(NULL,0,0);
return(0);
}
}

The Stamp will limit you 1 trade / bar. Hope this help.

Regards,

David

auto · #4 (**permalink**) 05-24-2009, 11:25 AM

Quote:

Originally Posted by davidke20

The Stamp will limit you 1 trade / bar.

.. as long as the MT4 is not restarted.

davidke20 · #5 (**permalink**) 05-25-2009, 09:47 AM

Quote:

Originally Posted by auto

.. as long as the MT4 is not restarted.

Yes. MT4 restart may cause it to fire up another trade if it happened within the same hour. However, this can avoid complication of having different magic number every hour. Such as:

Magic + 13 hour = 18000 + 13 = 18013

If current hour is 14:00, magic number had automatically changed to 18014. Trailing stop not function until next day's 13:00. No worries, this is not a debate. May be you prefer changing magic number.

Regards,

David