How to code? - Page 93

Michel · 05-15-2008, 07:31 AM

Quote:

Originally Posted by payback

anyway it doesn't work and i don't understand and figure out why..

here are my variables

PHP Code:


			
 BuyValueCurrent   = iCustom(NULL,TimeFrame,IndicatorName1,NumBars,0,1);  // braintrend1

PHP Code:


			
 BuyValueCurrent2   = iCustom(NULL,TimeFrame,IndicatorName2,NumBars,0,1);  // braintrend2

and here is the statement

PHP Code:


			
 BuyCondition  = (BuyValueCurrent != EMPTY_VALUE && BuyValueCurrent2 != EMPTY_VALUE);

it gives totally fuzzy results even when the indicator (Braintrend2stop and BrainTrend1Stop) are SELL

I do not know your indic Braintrend1 and 2, I just assumed that when a buy condition is fulfilled, they draw an arrow on the chart. In MT4, the default buffer's value is a constant named "EMPTY-VALUE", so if there is no arrow the value returned by iCustom() is this constant, and if there is an arrow the returned value is the price where the arrow is put.
As I understood, you want to buy when both indics are showing an arrow, isn't that ?

payback · 05-15-2008, 10:40 AM

yes is exactly what i want to do

Michel · 05-15-2008, 01:17 PM

Quote:

Originally Posted by payback

yes is exactly what i want to do

So, please, check your iCustom() syntax.

payback · 05-15-2008, 05:53 PM

what i have to check? maybe i miss something

PHP Code:


			
 double iCustom( string symbol, int timeframe, string name, ..., int mode, int shift)

well for what i suppose if there is a buy signal it is stored in buffer 0 else it is empty and buffer 1 has the sell signal

Michel · 05-15-2008, 08:06 PM

Quote:

Originally Posted by payback

what i have to check? maybe i miss something

PHP Code:


			
 double iCustom( string symbol, int timeframe, string name, ..., int mode, int shift)

well for what i suppose if there is a buy signal it is stored in buffer 0 else it is empty and buffer 1 has the sell signal

Post your indic here, I will look.

payback · 05-15-2008, 09:53 PM

ok thx!
and please explain

Michel · 05-16-2008, 02:19 AM

Quote:

Originally Posted by payback

ok thx!
and please explain

Open BrainTrend1Stop.mq4.
At the begining of the file you can find :

PHP Code:


			
extern int       NumBars=500;

extern int       EnableAlerts=0;

extern int       SignalID=0;

This means that you have to fill those three parameters as arguments in the iCustom() call, like this:

PHP Code:


			
BuyValueCurrent = iCustom(NULL,0,"BrainTrend1Stop",NumBars,EnableAlerts,SignalID,0,1);  // braintrend1

About the buffer's number, you can see this:

PHP Code:


			
#property indicator_color1 Magenta

#property indicator_color2 Aqua

So the buffer 0 is Magenta and the buffer 1 is Aqua.
Thus if the Buy arrow's color is Aqua, the buffer's number is 1 and the iCustom call is:

PHP Code:


			
BuyValueCurrent = iCustom(NULL,0,"BrainTrend1Stop",NumBars,EnableAlerts,SignalID,1,1);  // braintrend1

A little lower you have:

PHP Code:


			
   SetIndexEmptyValue(1,0.0);

This means that the default empty value for the buffer 1 is set to 0.0; so when there is no arrow, the value returned by the iCustom() call will be 0.0.
So you should know the presence of the arrow checking its value against 0, like this (if the second indic follows the same behavior):

PHP Code:


			
BuyCondition = (BuyValueCurrent > 0 && BuyValueCurrent2 > 0);

About the second indic, I think you should be able to do the same analyse by yourself.

clarc · 05-17-2008, 11:44 AM

Quote:

Originally Posted by FerruFx

Here's the idea:

And in the start() function:

Hope that helps.

FerruFx

@FerruFx

thank your for your suggestion - i try to add your code into the EA, but everytime i get errorwarnings... if you have time, could you look into this EA how i do the mistakes (i have uploaded an clean version of the EA)

thank you for your help

clarc

FerruFx · 05-17-2008, 02:41 PM

Quote:

Originally Posted by clarc

@FerruFx

thank your for your suggestion - i try to add your code into the EA, but everytime i get errorwarnings... if you have time, could you look into this EA how i do the mistakes (i have uploaded an clean version of the EA)

thank you for your help

clarc

Done. Add the countlong and countshorts functions.

You missed a { at the beginning of the start function. It was for this reason you can't compile.

FerruFx

clarc · 05-17-2008, 05:02 PM

awsome, ferrufx ... Thanks a lot for this... i'm not a programmer, thats why its nearly impossible for me to do such changes...

regards

clarc

LinkBacks (?) LinkBack to this Thread: http://www.forex-tsd.com/metatrader-programming/554-how-code.html
Posted By	For	Type	Date
Need an experienced programmer? - Page 2	Post #0	Refback	09-24-2008 06:24 AM

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
How to code this?	iscuba11	Metatrader 4 mql 4 - Development course	1	08-03-2007 04:22 PM

Register in Forex TSD!
Trading Systems Leaders in this forum (automated trading systems) are winning more than 3000 pips in a month (30000$ investing one lot every time). Click here to register and get more information