How to code? - Page 92

birami · #**911** (**permalink**) 05-13-2008, 06:07 AM

hello
on this expert I'd like modify all sl to last orders sl same as tp but I couldn't

please help me

benitohau · #**912** (**permalink**) 05-13-2008, 10:30 AM

I need help coding in MT4

I have some code below:
StopLoss=EMAtrend-iClose(NULL,0,1);
TakeProfit=StopLoss

If(EMAshort>EMAlong && EMAshort_prev<EMAlong_prev)
{
OrderSend(Symbol(),OP_BUY,Lots,Ask,0,Ask+StopLoss* Point,Bid+TakeProfit*Point,"Buy at close price",10000,0,Green);
}

If(EMAshort<EMAlong && EMAshort_prev>EMAlong_prev)
{
OrderSend(Symbol(),OP_SELL,Lots,Bid,0,StopLoss,Bid +TakeProfit*Point,"Sell at close price",11000,0,Red);
}

The idea were:
1. Open order at close price when criteria met;
2. I want to make the EMAtrend to be the stoploss level;
3. The distance between EMAtrend to Close price bar will be the distance for takeprofit from opened price

I try the code above but nothing happen and there is an error 130.

Please help me.

basza · #**913** (**permalink**) 05-13-2008, 11:36 AM

Hi all

I am trying to get an ea to compile, but it comes up with the following error:

Code:

'TradeSymbol' - expression on global scope not allowed	I:\Program Files\MetaTrader - Alpari\experts\TTL.mq4 (65, 34)

Now the part of the ea causing this is right at the start of the code :

Code:

string         TradeSymbol;      TradeSymbol=Symbol();

If I block this out it comes up with errors for the following bit of code :

Code:

 if(TotalTradesThisSymbol(TradeSymbol)==0) {  int BS=0,SS=0,BL=0,SL=0;   }
   if(TotalTradesThisSymbol(TradeSymbol)>0)  {
      for(cnt=0;cnt<total;cnt++) {
         OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES);
         if(OrderSymbol()== Symbol) {
            if(OrderMagicNumber()==11) { BS=OrderTicket(); }
            if(OrderMagicNumber()==22) { SS=OrderTicket(); }
            if(OrderMagicNumber()==33) { BL=OrderTicket(); }
            if(OrderMagicNumber()==44) { SL=OrderTicket(); }
            }//end if(OrderSymbol
         }//end for
  }//end if   */

What I am wanting to know is if there is an easy way to fix this.
I'm no good at coding , only copying and pasteing.

Thanks in advance
Basza

Michel · #**914** (**permalink**) 05-13-2008, 02:56 PM

Quote:

Originally Posted by basza

Hi all

I am trying to get an ea to compile, but it comes up with the following error:

Code:

'TradeSymbol' - expression on global scope not allowed	I:\Program Files\MetaTrader - Alpari\experts\TTL.mq4 (65, 34)

Now the part of the ea causing this is right at the start of the code :

Code:

string         TradeSymbol;      TradeSymbol=Symbol();

If I block this out it comes up with errors for the following bit of code :

Code:

 if(TotalTradesThisSymbol(TradeSymbol)==0) {  int BS=0,SS=0,BL=0,SL=0;   }
   if(TotalTradesThisSymbol(TradeSymbol)>0)  {
      for(cnt=0;cnt<total;cnt++) {
         OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES);
         if(OrderSymbol()== Symbol) {
            if(OrderMagicNumber()==11) { BS=OrderTicket(); }
            if(OrderMagicNumber()==22) { SS=OrderTicket(); }
            if(OrderMagicNumber()==33) { BL=OrderTicket(); }
            if(OrderMagicNumber()==44) { SL=OrderTicket(); }
            }//end if(OrderSymbol
         }//end for
  }//end if   */

What I am wanting to know is if there is an easy way to fix this.
I'm no good at coding , only copying and pasteing.

Thanks in advance
Basza

You can define TradeSymbol as string on global scoop, but there you cannot evaluate the function Symbol(). So replace all "TradeSymbol" by "Symbol()", or assign the value in the init() or start() function like this:

PHP Code:


			
void Init(){TradeSymbol=Symbol();}

payback · #**915** (**permalink**) 05-14-2008, 12:11 PM

Hi i was trying to program an ea, and i followed your course (very intresting!)
I know quite well how to program in java and some c++

I was trying to program an ea with brain trend indicators the idea behind is
when brainTrend2stop and braintrend1stop DOTs are present buy (and viceversa)

but if i call the icustom function like this

BuyValueCurrent = iCustom(NULL,TimeFrame,IndicatorName1,NumBars,0,1) ;

i get only the value of the indicator in the present bar
is there a way to make it boolean? i'd like to write a function like

buy=true

BuyCondition = (IndicatorName1=true && IndicatorName2=true);

can someone help please please please???

clarc · #**916** (**permalink**) 05-14-2008, 03:31 PM

i have an EA wich open and mange the position, but sometimes give the indikator the same signal multiple and the EA open everytime this signal comes out an new position - but i dont want a second or third and so on and on position, i will only the first one - is it possible that the EA checks the open position by the basis of the magic number and pair to avoid such multiple entrys ?

Michel · #**917** (**permalink**) 05-14-2008, 08:38 PM

Quote:

Originally Posted by payback

Hi i was trying to program an ea, and i followed your course (very intresting!)
I know quite well how to program in java and some c++

I was trying to program an ea with brain trend indicators the idea behind is
when brainTrend2stop and braintrend1stop DOTs are present buy (and viceversa)

but if i call the icustom function like this

BuyValueCurrent = iCustom(NULL,TimeFrame,IndicatorName1,NumBars,0,1) ;

i get only the value of the indicator in the present bar
is there a way to make it boolean? i'd like to write a function like

buy=true

BuyCondition = (IndicatorName1=true && IndicatorName2=true);

can someone help please please please???

PHP Code:


			
BuyCondition = BuyValueCurrent1 != EMPTY_VALUE && BuyValueCurrent2 != EMPTY_VALUE;

payback · #**918** (**permalink**) 05-15-2008, 12:43 AM

thx but can you explain me why
BuyCondition = BuyValueCurrent1 != EMPTY_VALUE
why empty_value?

payback · #**919** (**permalink**) 05-15-2008, 12:56 AM

anyway it doesn't work and i don't understand and figure out why..

here are my variables

PHP Code:


			
 BuyValueCurrent   = iCustom(NULL,TimeFrame,IndicatorName1,NumBars,0,1);  // braintrend1

PHP Code:


			
 BuyValueCurrent2   = iCustom(NULL,TimeFrame,IndicatorName2,NumBars,0,1);  // braintrend2

and here is the statement

PHP Code:


			
 BuyCondition  = (BuyValueCurrent != EMPTY_VALUE && BuyValueCurrent2 != EMPTY_VALUE);

it gives totally fuzzy results even when the indicator (Braintrend2stop and BrainTrend1Stop) are SELL

FerruFx · #**920** (**permalink**) 05-15-2008, 01:23 AM

Quote:

Originally Posted by clarc

i have an EA wich open and mange the position, but sometimes give the indikator the same signal multiple and the EA open everytime this signal comes out an new position - but i dont want a second or third and so on and on position, i will only the first one - is it possible that the EA checks the open position by the basis of the magic number and pair to avoid such multiple entrys ?

Here's the idea:

Quote:

int CountLongs()
{
int count=0;
int trade;
int trades=OrdersTotal();
for(trade=0;trade<trades;trade++) {
OrderSelect(trade,SELECT_BY_POS,MODE_TRADES);
if(OrderSymbol()!=Symbol() || OrderMagicNumber() != MagicNumber) continue;
if(OrderType()==OP_BUY) count++;
} //---- for
return(count);
}

int CountShorts()
{
int count=0;
int trade;
int trades=OrdersTotal();
for(trade=0;trade<trades;trade++) {
OrderSelect(trade,SELECT_BY_POS,MODE_TRADES);
if(OrderSymbol()!=Symbol() || OrderMagicNumber() != MagicNumber) continue;
if(OrderType()==OP_SELL) count++;
} //---- for
return(count);
}

And in the start() function:

Quote:

if(CountLongs() == 0 && CountShorts() == 0) {

Your entry condition here
}

Hope that helps.

FerruFx

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
How to code this?	iscuba11	Metatrader 4 mql 4 - Development course	1	08-03-2007 04:22 PM

Register in Forex TSD!
Trading Systems Leaders in this forum (automated trading systems) are winning more than 3000 pips in a month (30000$ investing one lot every time). Click here to register and get more information