How to code? - Page 91

delvinja · 05-12-2008, 09:05 AM

Thanks, ferrufx for the info. but how do iget this ea to work i obviously am not competent enough to make the adjustments myself so any assistance would be greatly appreciated, thanks

Badguy · 05-12-2008, 09:15 AM

Thanks Linuxer

I try to learn a little bit of coding MQL4 by copy and paste.
It's not so important, only for my learning.

Thanks once again

Quote:

Originally Posted by Linuxser

I see with your code the idea is to buy/sell above/below 0 line.

Why don't you try with iCCI for your TCCI instead of call iCustom. There is nothing different between standard CCI and the other indicator.

FerruFx · 05-12-2008, 09:49 AM

Quote:

Originally Posted by FerruFx

delvinja, your code is at the very beginning. Actually I didn't see any long or short conditions to trigger a trade.

Sorry delvinja, I answered wrong by looking the wrong EA. This answer was for Badguy.

FerruFx

delvinja · 05-12-2008, 01:28 PM

The indicator is the Macd_BB like the one used by Nexgen.
Settings are as follows"
FastLen = 10
SloLengthwLen = 26
Length = 10
Stdev = 1

a buy order should be executed when a green ball is developed above the upper line and closes only when the balls cross below the upper line again or hits ny trailing stop.
a sell is executed when a magenta ball is developed below the lower line and closes only when the balls cross above the lower line again.

take profits and stop loss should be moderate and allow the settings to be changed to tweak the expert. Ihave attached the indicator and am most grateful for your help with this.
If there is anything else that you may need you can post here or email me at delvin.patrick@gmail.com

thanks again bro!

delvinja · 05-12-2008, 01:30 PM

here is the indicator Ferrufx, sorry about that(for the expert advisor)

apres · 05-12-2008, 03:21 PM

I've tried to translate this indicator from another language.
It loads up OK but it won't refresh at the next new bar and subsequent bars.
Any help would be most welcome.

newdigital · 05-12-2008, 03:28 PM

Try this thread Zerolag systems - may be you will find something similar.

Michel · 05-12-2008, 04:11 PM

Quote:

Originally Posted by delvinja

Hi guys i have been trying for the last three days to get this expert advisor to execute long trades in mt4 with no success. it only executes short trades even though the signal_buy is there . please could anyone have a look at this code and fix it for me or tell me what to do. i'm new to programming and built it from an online strategy builder. thanks in advance!

the code is attached.

PHP Code:


			
double ... = iMA(NULL, 0, 3, -3, MODE_SMA, PRICE_CLOSE, Current + 0);

I am not sure about the -3 shift parameter : it shift the curve to the left, so the current bar is undefinited. Try to replace all -3 by 0 to see if the buy orders are triggered.
I would replace

PHP Code:


			
double Var1 = iMA(NULL, 0, 3, -3, MODE_SMA, PRICE_CLOSE, Current + 0);

double Var2 = iMA(NULL, 0, 3, -3, MODE_SMA, PRICE_CLOSE, Current + 0);

double Var3 = iBands(NULL, 0, 20, 2, 1, PRICE_CLOSE, MODE_UPPER, Current + 0);

double Var4 = iBands(NULL, 0, 20, 2, 1, PRICE_CLOSE, MODE_LOWER, Current + 0);



double Buy1_1 = iMA(NULL, 0, 3, -3, MODE_SMA, PRICE_CLOSE, Current + 0);

double Buy1_2 = iBands(NULL, 0, 20, 2, 1, PRICE_CLOSE, MODE_UPPER, Current + 0);



double Sell1_1 = iMA(NULL, 0, 3, -3, MODE_SMA, PRICE_CLOSE, Current + 0);

double Sell1_2 = iBands(NULL, 0, 20, 2, 1, PRICE_CLOSE, MODE_LOWER, Current + 0);



double CloseBuy1_1 = iMA(NULL, 0, 3, -3, MODE_SMA, PRICE_CLOSE, Current + 0);

double CloseBuy1_2 = iBands(NULL, 0, 20, 2, 1, PRICE_CLOSE, MODE_UPPER, Current + 0);



double CloseSell1_1 = iMA(NULL, 0, 3, -3, MODE_SMA, PRICE_CLOSE, Current + 0);

double CloseSell1_2 = iBands(NULL, 0, 20, 2, 1, PRICE_CLOSE, MODE_UPPER, Current + 0);

by

PHP Code:


			
double Buy1_1 = iMA(NULL, 0, 3, 0, MODE_SMA, PRICE_CLOSE, Current);

double Buy1_2 = iBands(NULL, 0, 20, 2, 1, PRICE_CLOSE, MODE_UPPER, Current);



double Sell1_1 = Buy1_1;

double Sell1_2 = iBands(NULL, 0, 20, 2, 1, PRICE_CLOSE, MODE_LOWER, Current);



double CloseBuy1_1 = Buy1_1;

double CloseBuy1_2 = iBands(NULL, 0, 20, 2, 1, PRICE_CLOSE, MODE_UPPER, Current);



double CloseSell1_1 = Buy1_1;

double CloseSell1_2 = iBands(NULL, 0, 20, 2, 1, PRICE_CLOSE, MODE_UPPER, Current);

Rem :
- Var1,2,3,4 are not used.
- Both CloseBuy1_2 and CloseSell1_2 are the same : one is probably wrong (MODE_LOWER)

delvinja · 05-12-2008, 05:40 PM

Michel, thanks a lot for your help, that fixed it perfectly! you guyss are the best, i can finally get some rest. I'll let you know how my testing turned out.

oh by the way, r u saying that -3 will never be able to work in this expert advisor? thanks again.

Michel · 05-12-2008, 07:31 PM

Quote:

Originally Posted by delvinja

... oh by the way, r u saying that -3 will never be able to work in this expert advisor? thanks again.

To tell you the truth, I never really understood the use of this shift : if you want to know the value of an indic 3 bars before the current bar, just use 3 as shift, but the last one; the first one just shift the drawing of the curve, and if you use a negative value, it's like the past is knowing the future...
Anyway I would be happy that someone explain me it's use !

But to answer your question, try to know the exact strategy you want to follow, from where comes that -3 ?

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
How to code this?	iscuba11	Metatrader 4 mql 4 - Development course	1	08-03-2007 04:22 PM

Register in Forex TSD!
Trading Systems Leaders in this forum (automated trading systems) are winning more than 3000 pips in a month (30000$ investing one lot every time). Click here to register and get more information