How to code? - Page 77

mr_boney · #**761** (**permalink**) 03-12-2008, 08:02 AM

I Think This Ea Is Very Good...

But Only Open One Order In One Pair...why?

adria · #**762** (**permalink**) 03-13-2008, 11:31 AM

I created the similar EA. You have to change TIME value according to your
chart time.

hedge4x · #**763** (**permalink**) 03-14-2008, 04:59 AM

I notice broker sometimes requote the price causing the EA not to close
the order. How can I prevent the EA to continue until all of orders according
to its magic number is closed, maybe put a sleep function for 5 second and
a while loop to check and close the orders before continue. Below is the
closealltrades function. Appreciate the help and thanks in advance.

void CloseAllTrades()
{
int rc;
int cnt;

for(cnt=OrdersTotal()-1;cnt>=0;cnt--)
{
OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
if (OrderMagicNumber()==GetMagicNumber())
{
rc= OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), MarketInfo(OrderSymbol(), MODE_SPREAD), Yellow);
if(!rc)
Log("Close error="+GetLastError());
}
}
}

Michel · #**764** (**permalink**) 03-14-2008, 07:41 AM

Quote:

Originally Posted by hedge4x

I notice broker sometimes requote the price causing the EA not to close
the order. How can I prevent the EA to continue until all of orders according
to its magic number is closed, maybe put a sleep function for 5 second and
a while loop to check and close the orders before continue. Below is the
closealltrades function. Appreciate the help and thanks in advance.

void CloseAllTrades()
{
int rc;
int cnt;

for(cnt=OrdersTotal()-1;cnt>=0;cnt--)
{
OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
if (OrderMagicNumber()==GetMagicNumber())
{
rc= OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), MarketInfo(OrderSymbol(), MODE_SPREAD), Yellow);
if(!rc)
Log("Close error="+GetLastError());
}
}
}

PHP Code:


			
bool IsAllClosed ;         //Global variable



void CloseAllTrades()

{

   int cnt;

   IsAllClosed = true;

   for(cnt=OrdersTotal()-1;cnt>=0;cnt--)

    {

      OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);

      if (OrderMagicNumber()==GetMagicNumber()) 

         IsAllClosed = IsAllClosed && OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), MarketInfo(OrderSymbol(), MODE_SPREAD), Yellow);

    }

}



void start()

{

   while(!IsAllClosed) {CloseAllTrades(); return;}

   ...

hedge4x · #**765** (**permalink**) 03-14-2008, 11:21 AM

thank you Michel for your help.

I will try it out.

hedge4x · #**766** (**permalink**) 03-14-2008, 11:30 AM

This line while(!IsAllClosed) {CloseAllTrades(); return;}
in the main start will close all open positions if MT goes down
and I start it back up. Is there a way to put this line
in the closealltrades function so it won't close all open positions
after MT4 restart?

thanks.

hedge4x · #**767** (**permalink**) 03-14-2008, 11:39 AM

I got it to work now.

Michel · #**768** (**permalink**) 03-14-2008, 04:19 PM

Quote:

Originally Posted by hedge4x

This line while(!IsAllClosed) {CloseAllTrades(); return;}
in the main start will close all open positions if MT goes down
and I start it back up. Is there a way to put this line
in the closealltrades function so it won't close all open positions
after MT4 restart?

thanks.

Yes, sorry you can define the bool at start time like this :

PHP Code:


			
bool IsAllClosed = true ;         //Global variable

Then it becomes even better to define a extern variable, so you can keep the control :

PHP Code:


			
extern bool CloseAll = false ;         //Global variable



void CloseAllTrades() 

{ 

   int cnt; 

   CloseAll = false; 

   for(cnt=OrdersTotal()-1;cnt>=0;cnt--) 

    { 

      OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES); 

      if (OrderMagicNumber()==GetMagicNumber())  

         CloseAll = CloseAll || !OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), MarketInfo(OrderSymbol(), MODE_SPREAD), Yellow); 

    } 

} 



void start() 

{ 

   while(CloseAll) {CloseAllTrades(); return;} 

   ...

The main advantage of this method is that the EA try to close each postion at each tick until all are closed.

eldegwy · #**769** (**permalink**) 03-18-2008, 02:47 AM

Hi All...

i made an EA by the great expert advisor bulder web site and i test it and found it profitble for the last year but i think that can be enhanced ...

so if any one can help to improve that EA ?

detaled about EA..

the EA pased on two indecators one of them is mine and the other is can found on bublic fourms " zero lag macd "

now the expert is working all the time enter buy then close and reverse to sell and so on ...

i need to make it work only in spesfic times, add a money managemint and the last thing i need to delay the excute of buy or sell with the next "1 minute" candel but the EA work on the 1H candel in fact ...

so hope to find how can help in that
Thank you All
best regards
Tamer

star90 · #**770** (**permalink**) 03-19-2008, 11:42 PM

Hi,
I want to know how can I refer to a filename that I am running.
For example if I run a script called supertrader.mq4 and I want to open a logfile called supertrader_logfile from the script supertrader.
Is there a variable that holds the name of the file I am running?
Thanks.

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
How to code this?	iscuba11	Metatrader 4 mql 4 - Development course	1	08-03-2007 04:22 PM

Register in Forex TSD!
Trading Systems Leaders in this forum (automated trading systems) are winning more than 3000 pips in a month (30000$ investing one lot every time). Click here to register and get more information