How to code? - Page 6

eric79 · #51 (**permalink**) 04-09-2006, 02:45 PM

Thank you very much, i will try it.

FX5 · #52 (**permalink**) 04-10-2006, 05:13 AM

Hello Everybody:

I wrote a script to close all trades including the pending orders, but was disapointed after testing it. The functions: OrderClose, and Orderdelete fail in closing the trades. By calling the GetLastError function I get the error code: 4109 which is defined in the error header file as TRADE_NOT_ALLOWED.

I even tried to execute those scripts which come with the platform but with no success.

I hope someone can solve the problem.

Thanks,

firedave · #53 (**permalink**) 04-10-2006, 05:47 AM

Okay, try this one. I think Lots and Price variable should be double not integer. Hope this help

Code:

//+------------------------------------------------------------------+
//|                                                     CloseAll.mq4 |
//|                                                     FX5          |
//|                                                                  |
//+------------------------------------------------------------------+
#property copyright "FX5"
#property link      " "

//+------------------------------------------------------------------+
//| script program start function                                    |
//+------------------------------------------------------------------+
int start()
  {
//----
      int Ticket,Lots,Price,Type,Result;
      int Error=0;
      int Total=OrdersTotal();
      for(int i=0;i<Total;i++)
      {
         if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==0)
         {
            Alert("Can''t select the order indexed: ",i);
            Alert("Error code is ", GetLastError());
            Error++;
         }
         else
         {
/*            Lots=OrderLots();
            Ticket=OrderTicket();
            Type=OrderType();*/
            Result=0;
/*            if(Type==OP_BUY)
               Price=Bid;
            if(Type==OP_SELL)
               Price=Ask;*/
//            if(Type==OP_BUY || Type==OP_SELL)
            if(OrderType()<=OP_SELL)
            {
               Alert(OP_BUY,"  ",OP_SELL,"  ",Type);
//               Result=OrderClose(Ticket,Lots,Price,5,Blue);
               if(OrderType()==OP_BUY)  Result=OrderClose(OrderTicket(),OrderLots(),Bid,5,Blue);
               if(OrderType()==OP_SELL) Result=OrderClose(OrderTicket(),OrderLots(),Ask,5,Blue);
            }
            else
            {
               Result=OrderDelete(OrderTicket());
            }
            if(Result==0)
            {
               Alert("Can''t close the Order number: ",i," with Ticket:  ",Ticket);
               Alert("Error Code:  ",GetLastError());
               Error++;
            }
         }
      }
   if(Error!=0)
      Alert(Error,"   Errors have occured");
   else
      Alert("Close all Orders Succeeded with no Errors");
//----
   return(0);
  }
//+------------------------------------------------------------------+

crepuscular · #54 (**permalink**) 04-10-2006, 06:11 AM

Quote:

Originally Posted by FX5

Hello Everybody:

I wrote a script to close all trades including the pending orders, but was disapointed after testing it. The functions: OrderClose, and Orderdelete fail in closing the trades. By calling the GetLastError function I get the error code: 4109 which is defined in the error header file as TRADE_NOT_ALLOWED.

I even tried to execute those scripts which come with the platform but with no success.

I hope someone can solve the problem.

Thanks,

In metatrader, go to tools -> options, click the expert advisor tab and select allow live trading, and click the allow dll imports, and uncheck confirm calls. I wrote a few scripts and was having the same problem.

Michel · #55 (**permalink**) 04-10-2006, 12:50 PM

Quote:

Originally Posted by firedave

Okay, try this one. I think Lots and Price variable should be double not integer. Hope this help

Code:

//+------------------------------------------------------------------+
//|                                                     CloseAll.mq4 |
//|                                                     FX5          |
//|                                                                  |
//+------------------------------------------------------------------+
#property copyright "FX5"
#property link      " "

//+------------------------------------------------------------------+
//| script program start function                                    |
//+------------------------------------------------------------------+
int start()
  {
//----
      int Ticket,Lots,Price,Type,Result;
      int Error=0;
      int Total=OrdersTotal();
      for(int i=0;i<Total;i++)
      {
         if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==0)
         {
            Alert("Can''t select the order indexed: ",i);
            Alert("Error code is ", GetLastError());
            Error++;
         }
         else
         {
/*            Lots=OrderLots();
            Ticket=OrderTicket();
            Type=OrderType();*/
            Result=0;
/*            if(Type==OP_BUY)
               Price=Bid;
            if(Type==OP_SELL)
               Price=Ask;*/
//            if(Type==OP_BUY || Type==OP_SELL)
            if(OrderType()<=OP_SELL)
            {
               Alert(OP_BUY,"  ",OP_SELL,"  ",Type);
//               Result=OrderClose(Ticket,Lots,Price,5,Blue);
               if(OrderType()==OP_BUY)  Result=OrderClose(OrderTicket(),OrderLots(),Bid,5,Blue);
               if(OrderType()==OP_SELL) Result=OrderClose(OrderTicket(),OrderLots(),Ask,5,Blue);
            }
            else
            {
               Result=OrderDelete(OrderTicket());
            }
            if(Result==0)
            {
               Alert("Can''t close the Order number: ",i," with Ticket:  ",Ticket);
               Alert("Error Code:  ",GetLastError());
               Error++;
            }
         }
      }
   if(Error!=0)
      Alert(Error,"   Errors have occured");
   else
      Alert("Close all Orders Succeeded with no Errors");
//----
   return(0);
  }
//+------------------------------------------------------------------+

This may be wrong : to delete multiple orders, you must begin from the last one as their indexes are decrementing following the deleting process.
So, in place of " for(int i=0;i<Total;i++) ", use " for(int i=Total-1;i>=0;i--) "

FX5 · #56 (**permalink**) 04-10-2006, 12:56 PM

Thanks firedave for the code modification. It was a small bug which I didn't pay attention to.

Crepuscular, thank you so much for hint. I could have spent a century before figuring out the solution. Finally, I have a working code.

FX5 · #57 (**permalink**) 04-10-2006, 01:04 PM

Michel, that was a very clever note, thank you very much.

harriss · #58 (**permalink**) 04-11-2006, 08:45 PM

i would like to write a function which gets the max drawdown from trade that have been closed. i have come up with two solutions.

1. calculate the drawdown while the trade is still active. saving the number to a global variable and writing the data to file according to ticket number. MT4 would always have to be online.

2. get the drawdown by geting the highest high or lowest low from the 1 min chart. the problem here is we have to have the 1 min history for the trade. (i would use this method if i could get the 1 min bars neccessary if they werent already downloaded)

I would like to come up with a nicer way of getting max drawdown.

Any input is appreciated.

Mohammed · #59 (**permalink**) 04-11-2006, 10:11 PM

Quote:

Originally Posted by harriss

i would like to write a function which gets the max drawdown from trade that have been closed. i have come up with two solutions.

1. calculate the drawdown while the trade is still active. saving the number to a global variable and writing the data to file according to ticket number. MT4 would always have to be online.

2. get the drawdown by geting the highest high or lowest low from the 1 min chart. the problem here is we have to have the 1 min history for the trade. (i would use this method if i could get the 1 min bars neccessary if they werent already downloaded)

I would like to come up with a nicer way of getting max drawdown.

Any input is appreciated.

Salam harriss,

What did you mean by "drawdown"?
Do you mean the maximum lose one of closed trades has been made?

harriss · #60 (**permalink**) 04-12-2006, 12:57 AM

What i mean by drawdown is, what is the lowest point in the trade. For example, if the trade hit the stoploss, then the stoploss would be the drawdown. Now if the trade ended up on the positive side and was -15 pips at one point then the drawdown would be 15. Lastly, if the trade close at -15 pips but was -30 at one point then the drawdown would be 30.

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

LinkBacks (?) LinkBack to this Thread: http://www.forex-tsd.com/metatrader-programming/554-how-code.html
Posted By	For	Type	Date
Need an experienced programmer? - Page 2	Post #0	Refback	09-24-2008 07:24 AM

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
How to code this?	iscuba11	Metatrader 4 mql 4 - Development course	1	08-03-2007 05:22 PM

Register in Forex TSD!
Trading Systems Leaders in this forum (automated trading systems) are winning more than 3000 pips in a month (30000$ investing one lot every time). Click here to register and get more information