int OrderSend( string symbol, int cmd, double volume, double price, int slippage, double stoploss, double takeprofit, string comment=NULL, int magic=0, datetime expiration=0, color arrow_color=CLR_NONE)

As you can see parameter six is the stoploss. Make sure your stoploss is defined as an int. Next, make sure in your OrderSend() command that you are multiplying the stoploss by point. This converts to the right double for the currency you are trading.

Example for long:
ticketa=OrderSend(Symbol(),OP_BUY,lotsize,Ask,slip ,Ask-intStopLoss*Point,Ask+intTakeProfit*Point,"Comment ",magic,0,Green);

Example for short:
ticketb=OrderSend(Symbol(),OP_SELL,lotsize,Bid,sli p,Bid+intStopLoss*Point,Bid-intTakeProfit*Point,"Comment",magic,0,Blue);

Hope this helps.

Thanks Wolfe

That helped alot but has open a new problem lol it now buys but no sell well not in the right place. I have been trying to buy what all three indi are blue and sell when all red.
I think I have picked the right name "The Abyss" for the ea. as that is where I am sitting trying to code my way out. LOL


2007.11.24 10:14:44 2007.11.23 12:00 The Abyss EURUSD,H4: Error opening SELL order : 0

void CheckForSignals() {


double TML=iCustom(NULL,0,"TrendManager",TM_Period,TM_Shi ft,0,shift);
double TMS=iCustom(NULL,0,"TrendManager",TM_Period,TM_Shi ft,1,shift);
double hasOpenLong=iCustom(NULL,0,"Heiken_Ashi_Smoothed", MaMetod,MaPeriod,MaPeriod2,1,shift) ;
double hasCloseLong=iCustom(NULL,0,"Heiken_Ashi_Smoothed" ,MaMetod,MaPeriod,MaPeriod2,3,shift) ;
double hasOpenShort=iCustom(NULL,0,"Heiken_Ashi_Smoothed" ,MaMetod,MaPeriod,MaPeriod2,0,shift) ;
double hasCloseShort=iCustom(NULL,0,"Heiken_Ashi_Smoothed ",MaMetod,MaPeriod,MaPeriod2,2,shift) ;
double SDLL=iCustom(NULL,0,"Slope Direction Line",period,method,price,0,shift);
double SDLS=iCustom(NULL,0,"Slope Direction Line",period,method,price,1,shift);




buysig=false;
sellsig=false;
closebuy=false;
closesell=false;


bool Long1 = TML;
bool Short1 = TMS;
bool Long2 = SDLL;
bool Short2 = SDLS;
bool Long3 = hasOpenLong > hasCloseLong;
bool Short3 = hasOpenShort < hasCloseShort;

buysig = Long1 && Long2 && Long3;
sellsig = Short1 && Short2 && Short3;

closebuy=sellsig;
closesell=buysig;

}

void CheckForOpen() {

if (last==Time[0]) return;

int res,ord;
double entry,stop;

ord=CalculateCurrentOrders();

if (ord!=0) CheckForClose();

//---- buy conditions
if (buys< buysig) {
res=OpenAtMarket(OP_BUY,Lots);
if (res<0) Print("Error opening BUY order : ",(GetLastError()));
else last=Time[0];
}
//---- sell conditions
if (sells< sellsig) {
res=OpenAtMarket(OP_SELL,Lots);
if (res<=0) Print("Error opening SELL order : ",(GetLastError()));
else last=Time[0];
}
}

int OpenAtMarket(int mode,double lot) {
int tr,col;
double openprice;
tr=0; while (tr<5 && !IsTradeAllowed()) { tr++; Sleep(2000); }
RefreshRates();
if (mode==OP_SELL) {
openprice=Bid;
col=Red;
} else {
//openprice=nd(Ask);
openprice=Ask;
col=Blue;
}
OrderSend(Symbol(),mode,lot,openprice,slippage,sl, tp,EAName+Magic,Magic,0,col);

}
return;


//+------------------------------------------------------------------+
//| Check for close order conditions |
//+------------------------------------------------------------------+
void CheckForClose() {
int total;
//----
total=OrdersTotal();
for(int i=total;i>=0;i--)
{
if(!OrderSelect(i,SELECT_BY_POS,MODE_TRADES)) continue;
if(OrderMagicNumber()!=Magic || OrderSymbol()!=Symbol()) continue;
//---- check order type
if(OrderType()==OP_BUY && closebuy) CloseAtMarket(OrderTicket(),OrderLots());
if(OrderType()==OP_SELL && closesell) CloseAtMarket(OrderTicket(),OrderLots());
}
}

bool CloseAtMarket(int ticket,double lot) {
bool bres=false; int tr;
tr=0; while (tr<5 && !IsTradeAllowed()) { tr++; Sleep(2000); }
RefreshRates();
bres=OrderClose(ticket,lot,OrderClosePrice(),slipp age,White);
if (!bres) Print("Error closing order : ",(GetLastError()));

}

Yes, it may be that; all depend of what you are intended to do...

Dear all:

I'm building a system I think it is very good, I tested the idea before for 3 months, Now I'm trying to coding an indicator which will be asap in the forum so we can test it and it will really will make good money i think:

Plz help me for now to convert these lines into mql4 coding:

1- I have vairable X , this will have a value and I'm calculating it now
SO We have X as an Integer

2- the indicator must check the currnet GMT Time, It must be 6:00am GMT - Time Frame 1 H

-- check GMT TIME 6:00am, WHEN this candle close, we need to calculate the following Variable Of this candle:
High - Low = A
A / 2 = B
B - High = C = SL
D = X * 30%
Buy_Entry= D + C
Buy_Target= C + (X * 60%)
Sell_Entry= C - D
Sell _Target= C - (X * 60%)

Then:
I want to drow the result as lines on the chart with GreaN Area for buy and red Area for Short According to Entry for Buy and Sell and SL

these must be automaticly apear as soon as GMT 6:00 candle finished , Time Frame 1H, so caluculation must be according to 6:00 to 6:59am GMT Candle high and low

PLZ Convert this to MQL4, so i can test it and get back again to puplish the result

THANKS ALOT

Beno, I'm not sure about this one. I have usually not had good experience with using color changing indicators in EA's. Open your data window with your indicators attached and find out what numerical value is returned for each color. That may help your coding, also make sure you are calling the correct indicator buffer at the right time. (I'm sure you have already done that) You may have better luck with help if you post the entire EA, if you really need help. Also, personally I would code it with 2 separate Ordersend() functions, one dedicated to shorts, and one dedicated to longs. That's just my opinion, it makes things easier to follow.

Good luck, we all have had our own versions of "the Abyss"!

Cheers Wolfe

I am going to try the 2 Ordersend option to see what happens. once I get this going I will post it.

Gidday Wolfe

Attached is The Abyss EA it needs some work doing to it. I am still working on it but some more help By some one who knows what they are doing would be great.


cheers

Beno

Attached Files

	The Abyss.mq4 (10.1 KB, 11 views)
	Heiken_Ashi_Smoothed.mq4 (4.2 KB, 5 views)
	Slope Direction Line.mq4 (4.1 KB, 5 views)

i need a little help.. how do i make it work? i tried but it won't read the mins? i i should use something else aside from TimeHour but what?

Maybe you meant something like the following:

Or maybe

if (TimeHour(Clocks) == 7)
{
switch (TimeMinute(Clocks)
{
case 15 : B = 1;
break;
case 30 : B = 2;
break;
case 45 : B = 3;
}
}

if (TimeHour(Clocks) == 8)
{
switch (TimkeMinute(Clocks)
{
case 0 : B = 4;
break;
case 15 : B = 5;
break;
case 30 : B = 6;

}
}

Otherwise 7:17 would also set a value of 1 to B.

Robert