How to code? - Page 208 - Forex-TSD

Roger09 · #**2071** (**permalink**) 09-27-2009, 10:44 PM

Quote:

Originally Posted by fxbg

Hi,
Could someone please let me know how I can place a fixed StopLoss in ths code?

Replace

Code:

extern double Lots       = 0.1; 
extern int ChannelPeriod = 25; 
extern int Slippage      = 3; 
extern int TakeProfit    = 15; 
//+------------------------------------------------------------------+ 
double LastOrderTime = 0; 
double CurrentDirection = 0; 
double CurrentTakeProfitPrice = 0; 
//+------------------------------------------------------------------+ 
void OpenLong() 
{ 
   if (Time[0] == LastOrderTime) 
      return; 
   if (CurrentDirection != 0) 
      return; 

   OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage, 0, 0, 
             "Daydream", MAGIC_NUM, 0, Blue); 
   LastOrderTime = Time[0]; 
   CurrentDirection = 1; 
} 
//+------------------------------------------------------------------+ 
void OpenShort() 
{ 
   if (Time[0] == LastOrderTime) 
      return; 
   if (CurrentDirection != 0) 
      return; 

   OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage, 0, 0, 
             "Daydream", MAGIC_NUM, 0, Red); 
   LastOrderTime = Time[0]; 
   CurrentDirection = -1; 
}

to

Code:

extern double Lots       = 0.1; 
extern int ChannelPeriod = 25; 
extern int Slippage      = 3; 
extern int TakeProfit    = 15; 
extern int StopLoss     = 15;
//+------------------------------------------------------------------+ 
double LastOrderTime = 0; 
double CurrentDirection = 0; 
double CurrentTakeProfitPrice = 0; 
//+------------------------------------------------------------------+ 
void OpenLong() 
{ 
   if (Time[0] == LastOrderTime) 
      return; 
   if (CurrentDirection != 0) 
      return; 

   OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage, Ask-StopLoss*Point, 0, 
             "Daydream", MAGIC_NUM, 0, Blue); 
   LastOrderTime = Time[0]; 
   CurrentDirection = 1; 
} 
//+------------------------------------------------------------------+ 
void OpenShort() 
{ 
   if (Time[0] == LastOrderTime) 
      return; 
   if (CurrentDirection != 0) 
      return; 

   OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage, Bid+StopLoss*Point, 0, 
             "Daydream", MAGIC_NUM, 0, Red); 
   LastOrderTime = Time[0]; 
   CurrentDirection = -1; 
}

asam · #**2072** (**permalink**) 09-27-2009, 11:20 PM

Hi all programmer,

I found an indicator (currency positions) in the forum which shows the current positions I am trading. Now I want to find someone out there help me make this indicator to use external window at the bottom of the chart, also the fonts and color can be changed. I am not good at program. Thanks a lot.

asam

fxbg · #**2073** (**permalink**) 09-28-2009, 09:13 AM

I start this EA in tester .When it reach the first Stoploss tester stop and don't continue make a test.Is it possible to correct this problem.Thank you Roger.

PHP Code:


			
//+------------------------------------------------------------------+

//|                                              Daydream by Cothool |

//|                                          Recommended: USD/JPY 1H |

//+------------------------------------------------------------------+

#define MAGIC_NUM  48213657

//+------------------------------------------------------------------+

extern double Lots       = 0.1;

extern int ChannelPeriod = 25;

extern int Slippage      = 3;

extern int TakeProfit    = 0;

extern int StopLoss     = 15;

//+------------------------------------------------------------------+

double LastOrderTime = 0;

double CurrentDirection = 0;

double CurrentTakeProfitPrice = 0;

//+------------------------------------------------------------------+

void OpenLong()

{

   if (Time[0] == LastOrderTime)

      return;

   if (CurrentDirection != 0)

      return;



   OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage,Ask-StopLoss*Point, 0,

             "Daydream", MAGIC_NUM, 0, Blue);

   LastOrderTime = Time[0];

   CurrentDirection = 1;

}

//+------------------------------------------------------------------+

void OpenShort()

{

   if (Time[0] == LastOrderTime)

      return;

   if (CurrentDirection != 0)

      return;



   OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage,Bid+StopLoss*Point, 0,

             "Daydream", MAGIC_NUM, 0, Red);

   LastOrderTime = Time[0];

   CurrentDirection = -1;

}

//+------------------------------------------------------------------+

void CloseLong()

{

   int i;



   if (Time[0] == LastOrderTime)

      return;

   if (CurrentDirection != 1)

      return;



   for (i = 0; i < OrdersTotal(); i++)

   {

      if (OrderSelect(i, SELECT_BY_POS) && OrderSymbol() == Symbol() &&

          OrderMagicNumber() == MAGIC_NUM && OrderType() == OP_BUY)

      {

         OrderClose(OrderTicket(), OrderLots(), Bid, 3, White);

         LastOrderTime = Time[0];

         CurrentDirection = 0;

      }

   }

}

//+------------------------------------------------------------------+

void CloseShort()

{

   int i;



   if (Time[0] == LastOrderTime)

      return;

   if (CurrentDirection != -1)

      return;



   for (i = 0; i < OrdersTotal(); i++)

   {

      if (OrderSelect(i, SELECT_BY_POS) && OrderSymbol() == Symbol() &&

          OrderMagicNumber() == MAGIC_NUM && OrderType() == OP_SELL)

      {

         OrderClose(OrderTicket(), OrderLots(), Ask, 3, White);

         LastOrderTime = Time[0];

         CurrentDirection = 0;

      }

   }

}

//+------------------------------------------------------------------+

void start()

{

   double HighestValue;

   double LowestValue;



   HighestValue = High[Highest(NULL, 0, MODE_HIGH, ChannelPeriod, 1)];

   LowestValue = Low[Lowest(NULL, 0, MODE_LOW, ChannelPeriod, 1)];



   // BUY

   if (Close[0] < LowestValue)

   {

      CloseShort();

      OpenLong();

      CurrentTakeProfitPrice = Bid + TakeProfit * Point;

   }



   // SELL

   if (Close[0] > HighestValue)

   {

      CloseLong();

      OpenShort();

      CurrentTakeProfitPrice = Ask - TakeProfit * Point;

   }



   // Trailing Profit Taking for Long Position

   if (CurrentDirection == 1)

   {

      if (CurrentTakeProfitPrice > Bid + TakeProfit * Point)

         CurrentTakeProfitPrice = Bid + TakeProfit * Point;

      if (Bid >= CurrentTakeProfitPrice)

         CloseLong();

   }



   // Trailing Profit Taking for Short Position

   if (CurrentDirection == -1)

   {

      if (CurrentTakeProfitPrice < Ask - TakeProfit * Point)

         CurrentTakeProfitPrice = Ask - TakeProfit * Point;

      if (Ask <= CurrentTakeProfitPrice)

         CloseShort();

   }

}

//+------------------------------------------------------------------+

nicesurf · #**2074** (**permalink**) 09-28-2009, 04:05 PM

The code is amazing, thanks

Roger09 · #**2075** (**permalink**) 09-28-2009, 04:48 PM

To fxbg
Adjust your logic. When you close the order by program, you change CurrentDirection to 0, but, if it is closed by stoploss - not.

tradertt · #**2076** (**permalink**) 09-30-2009, 06:14 AM

Hi GUys,

Can anyone help me edit this indicator that will search for a certain bar formation ONLY say 5 mins before the close of the bar on the timeframe I am on.

Thank you

Code:

//+------------------------------------------------------------------+
//|                                             outside_days_v01.mq4 |
//|                                       Copyright © 2008, Akuma99. |
//|                                    http://www.beginnertrader.com |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2008, Akuma99."
#property link      "http://www.beginnertrader.com"
#property indicator_chart_window
#property indicator_buffers 2
#property indicator_color1 Blue
#property indicator_color2 Red

double upArrows[];
double downArrows[];

//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
{
   //---- indicators
   SetIndexStyle(0,DRAW_ARROW);
   SetIndexBuffer(0,upArrows);
   SetIndexArrow(0,233);

   SetIndexStyle(1,DRAW_ARROW);
   SetIndexBuffer(1,downArrows);
   SetIndexArrow(1,234);
   //----
   return(0);
}

//+------------------------------------------------------------------+
//| Custom indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
{
//----

//----
return(0);
}

//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
void start()
  {
   int    counted_bars=IndicatorCounted();

   if (counted_bars < 0) {
      return(-1);
   } else {
      counted_bars--;
   }

   int    limit = Bars - counted_bars;

   int i;
   for (i=0; i<limit; i++) {
      if (Close[i] >= (Low[i]+0.7*(High[i]-Low[i])) && (Open[i] >= Low[i]+0.7*(High[i]-Low[i])) && (Open[i] >= Low[i+1]) && (Close[i] >= Low[i+1]) && (Open[i] <= High[i+1]) && (High[i] <= High[i+1]) && (Close[i] <= High[i+1]) && (Low[i] <= Low[i+1] - 0.3*(High[i]-Low[i])) && (1*(High[i] - Low[i]) >= ((High[i+1] - Low[i+1]) + (High[i+2] - Low[i+2]) + (High[i+3] - Low[i+3]) + (High[i+4] - Low[i+4]) + (High[i+5] - Low[i+5]))/5)) {
         if (Close[i] >= Low[i+1]) {
            upArrows[i] = Low[i] -0.3*(High[i]-Low[i]);
           // PlaySound("Alert.wav");
            Alert(Symbol(), " Bullish Pin Bar");
         } else if (Close[i] < Low[i+1]) {
            downArrows[i] = High[i];
           // PlaySound("Alert.wav");
            Alert(Symbol(), " Bullish Pin Bar");
         }
      }
   }

  }

ljuba973 · #**2077** (**permalink**) 10-01-2009, 10:27 PM

Hi all,

Very simple question as I am not sure that I understood properly values of indicators !?

I have values like this:

laADX00 = iADX(NULL,0,14,PRICE_CLOSE,MODE_MAIN,0);
laADXP0 = iADX(NULL,0,14,PRICE_CLOSE,MODE_PLUSDI,0);
laADXM0 = iADX(NULL,0,14,PRICE_CLOSE,MODE_MINUSDI,0);
laADX01 = iADX(NULL,0,14,PRICE_CLOSE,MODE_MAIN,1);
laADXP1 = iADX(NULL,0,14,PRICE_CLOSE,MODE_PLUSDI,1);
laADXM1 = iADX(NULL,0,14,PRICE_CLOSE,MODE_MINUSDI,1);
laADX02 = iADX(NULL,0,14,PRICE_CLOSE,MODE_MAIN,2);
laADXP2 = iADX(NULL,0,14,PRICE_CLOSE,MODE_PLUSDI,2);
laADXM2 = iADX(NULL,0,14,PRICE_CLOSE,MODE_MINUSDI,2);

and if later on I have something like:

Addon= "";
if (laADX02 > laADX01 && laADX01 > laADX00) Addon= "Up laADX0";
if (laADX02 < laADX01 && laADX01 < laADX00) Addon= "Down laADX0";
if (laADX02 > laADX01 && laADX01 < laADX00) Addon= "Top laADX0";
if (laADX02 < laADX01 && laADX01 > laADX00) Addon= "Bottom laADX0";
Print Addon.....
Addon= "";
if (laADXP2 > laADXP1 && laADXP1 > laADXP0) Addon= "Up laADXP";
if (laADXP2 < laADXP1 && laADXP1 < laADXP0) Addon= "Down laADXP";
if (laADXP2 > laADXP1 && laADXP1 < laADXP0) Addon= "Top laADXP";
if (laADXP2 < laADXP1 && laADXP1 > laADXP0) Addon= "Bottom laADXP";
Print Addon.....
Addon= "";
if (laADXM2 > laADXM1 && laADXM1 > laADXM0) Addon= "Up laADXM";
if (laADXM2 < laADXM1 && laADXM1 < laADXM0) Addon= "Down laADXM";
if (laADXM2 > laADXM1 && laADXM1 < laADXM0) Addon= "Top laADXM";
if (laADXM2 < laADXM1 && laADXM1 > laADXM0) Addon= "Bottom laADXM";

And I have printed that for example UP laADXM ...and on chart ADX DI- id going down or something else but not rising. Similar for RSI, CCI, MACD, ...

What is wrong here? I understood that defined like above laADX00 is value of ADX at the moment, laADX01 is value of ADX for previous bar at the moment when price is closed for that bar, laADX02 is value of ADX for 2 bars ago at the moment when price is closed for that bar. Is that correct or laADX01 is ADX value for previous tick and laADX02 for 2 ticks ago?

Can somebody clarify this to me please as charts and these definitions are not 1:1?

PS: I tested my EA in Strategy Simulator when I saw these contradiction results

Thanks in advance

Aleksandar

ljuba973 · #**2078** (**permalink**) 10-01-2009, 10:34 PM

Sorry ... example was wrong ... this is from my script ... but anyhow simulator present it different than printed sentence

Addon= "";
if (laADX02 < laADX01 && laADX01 < laADX00) Addon= "Up laADX0";
if (laADX02 > laADX01 && laADX01 > laADX00) Addon= "Down laADX0";
if (laADX02 < laADX01 && laADX01 > laADX00) Addon= "Top laADX0";
if (laADX02 > laADX01 && laADX01 < laADX00) Addon= "Bottom laADX0";
Print Addon.....

koolrafa · #**2079** (**permalink**) 10-03-2009, 11:54 AM

Hi!

Need help understanding how to use orderselect().

I'd like to know if it's possible to set a variable with the same value of orderprofit() .
Thank You

koolrafa · #**2080** (**permalink**) 10-03-2009, 12:44 PM

One more thing is there a way to close all open orders???
Thanks