How to code? - Page 123

InTrance · #**1221** (**permalink**) 08-27-2008, 01:58 PM

Quote:

Originally Posted by ssvl

thx for the information, will try it out

i'm just started learning mql

Don't try it, do it

ssvl · #**1222** (**permalink**) 08-27-2008, 02:44 PM

Quote:

Originally Posted by InTrance

Don't try it, do it

i'm at work... and the metatrader port is blocked at here

fireslayer26 · #**1223** (**permalink**) 08-27-2008, 09:02 PM

Hey, I'm still new to programming, and I am having trouble adding the following features to this simple EA:

1. Take Profit
2. Stop Loss
3. Trailing Stop
4. Number of pips to activate trailing stop

PHP Code:


			
//---- input parameters

extern double    Lots=0.1;

extern int       Slippage=5;



int MagicNum = 98760;

bool longPosOpened, shortPosOpened;

//+------------------------------------------------------------------+

//| expert initialization function                                   |

//+------------------------------------------------------------------+

int init()

  {

//----

   

//----

   return(0);

  }

//+------------------------------------------------------------------+

//| expert deinitialization function                                 |

//+------------------------------------------------------------------+

int deinit()

  {

//----

   

//----

   return(0);

  }

//+------------------------------------------------------------------+

//| expert start function                                            |

//+------------------------------------------------------------------+

int start()

  {

   

   double crossup = iCustom(NULL , 0, "18_28Cross", 1,18,1,28,1,0, 1);

   double crossdown = iCustom(NULL , 0, "18_28Cross", 1,18,1,28,1,1,1);

   

   if (crossup != EMPTY_VALUE)

   {

      if (!PosOpened(OP_BUY))

      {

         CloseAllOpenAndPendingTrades();

         OrderSend(Symbol(),OP_BUY,Lots,Ask,Slippage,0,0,Symbol(),MagicNum,0);

      }

   }

   else if(crossdown != EMPTY_VALUE)

   {

      if (!PosOpened(OP_SELL))

      {

         CloseAllOpenAndPendingTrades();

         OrderSend(Symbol(),OP_SELL,Lots,Bid,Slippage,0,0,Symbol(),MagicNum,0);

      }

   }

   

   return(0);

  }

//+------------------------------------------------------------------+

bool PosOpened(int orderType)

{

  int total=OrdersTotal();

  for(int cnt=0;cnt<total;cnt++)

  {

    OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);

    if(OrderSymbol() == Symbol() && OrderType() == orderType)

    {

      return(true);

    }

  }

  return(false);

}



void CloseAllOpenAndPendingTrades()

{

  int total = OrdersTotal();

  for(int i=total-1;i>=0;i--)

  {

    OrderSelect(i, SELECT_BY_POS);

    if(Symbol() != OrderSymbol()) continue; // important! only close positions of current currency pair

    

    int type   = OrderType();

    bool result = false;

    

    switch(type)

    {

      //Close opened long positions

      case OP_BUY       : result = OrderClose( OrderTicket(), OrderLots(), MarketInfo(OrderSymbol(), MODE_BID), 200);

                          break;

      

      //Close opened short positions

      case OP_SELL      : result = OrderClose( OrderTicket(), OrderLots(), MarketInfo(OrderSymbol(), MODE_ASK), 200);

                          break;



      //Close pending orders

      case OP_BUYLIMIT  :

      case OP_BUYSTOP   :

      case OP_SELLLIMIT :

      case OP_SELLSTOP  : result = OrderDelete( OrderTicket() );

    }

  }

  

  return(0);

}

ssvl · #**1224** (**permalink**) 08-28-2008, 09:49 AM

I'm currently using this code for detecting a jump:

if(iSAR(NULL,0,0.02,0.2,0)-iSAR(NULL,0,0.02,0.2,1)>1.0){ // if there is a jump up

But this doesn't seem to work right.

How can i detect if the psar is above or below my bars?

TIA

IN10TION · #**1225** (**permalink**) 08-28-2008, 10:03 AM

:: use your proxy in metatrader...

IN10TION

Quote:

Originally Posted by ssvl

i'm at work... and the metatrader port is blocked at here

IN10TION · #**1226** (**permalink**) 08-28-2008, 10:05 AM

:: compare your sar result with a current close[0]

Quote:

Originally Posted by ssvl

I'm currently using this code for detecting a jump:

if(iSAR(NULL,0,0.02,0.2,0)-iSAR(NULL,0,0.02,0.2,1)>1.0){ // if there is a jump up

But this doesn't seem to work right.

How can i detect if the psar is above or below my bars?

TIA

matrixebiz · #**1227** (**permalink**) 08-28-2008, 12:03 PM

Hey IN10TION, do you know of a good way to check if a trade just closed so that the EA won't place another trade (re-entry) until next signal comes? My EA checks trade condition upto lets say 10 bars but if a Sell trade condition was already met in the first few bars and closed I want the EA to stop checking upto the 10 bar Offset and wait until the next actual signal?
Thansk

luxinterior · #**1228** (**permalink**) 08-28-2008, 05:13 PM

Use the OrderHistory() function.

Lux

matrixebiz · #**1229** (**permalink**) 08-28-2008, 07:08 PM

Quote:

Originally Posted by luxinterior

Use the OrderHistory() function.

Lux

Thanks but not sure how that works. I don't really want to know if an order was just closed but rather if an order was just Opened and Closed within so many bars. Then only place another trade on next main signal entry. I'm still trying to eliminate quick trade re-entries when an order was just opened and closed but trade conditions are still met. I want it to somehow only do One trade per main signal, so even though trade conditions are still valid don't trade again if already traded on that signal (including offset).

Let me see if I can explain with an example. It might be something that can't be helped.

EG: Let's say I'm using QQE and VQI as a signal trade entry point (QQE cross and VQI changes from buy to Sell or visa-versa)
Now I'm adding a SignalOffset option of lets say 6 bars because the QQE cross and VQI signal might not happen exactly on the same bar.

Now lets say there is a valid trade within 2 bars of each other when QQE and VQI agree, so now a trade is placed but I have a TP of 10 pips and the bar moves 15 pips my TP is hit and the trade is closed. Trade conditions are still met because of my 6 bar Offset now another trade is placed (re-entry) bad

if that one or two bars moves 100 pips and my TP is 10, I've just had 10 trades, bad

I only want One trade per Signal (Offset included)

Does that make sense? i would still want it to trade within the 6 bars though if and opposite signal happens and the other trade was closed still.

Thanks

IN10TION · #**1230** (**permalink**) 08-28-2008, 08:08 PM

:: make a [switch] variable, if there is already 1 sell order made it stops doing other sells (switch value is -1) & will only readjust when there is a buy signal & buy order made (switch value is 1)... something extra (surplus) you can think about is a timer reset, in case if there is a big trend up or down, you can have 2 or 3 sells with a kind of interval in between same orders (timing).

IN10TION

Quote:

Originally Posted by matrixebiz

Thanks but not sure how that works. I don't really want to know if an order was just closed but rather if an order was just Opened and Closed within so many bars. Then only place another trade on next main signal entry. I'm still trying to eliminate quick trade re-entries when an order was just opened and closed but trade conditions are still met. I want it to somehow only do One trade per main signal, so even though trade conditions are still valid don't trade again if already traded on that signal (including offset).

Let me see if I can explain with an example. It might be something that can't be helped.

EG: Let's say I'm using QQE and VQI as a signal trade entry point (QQE cross and VQI changes from buy to Sell or visa-versa)
Now I'm adding a SignalOffset option of lets say 6 bars because the QQE cross and VQI signal might not happen exactly on the same bar.

Now lets say there is a valid trade within 2 bars of each other when QQE and VQI agree, so now a trade is placed but I have a TP of 10 pips and the bar moves 15 pips my TP is hit and the trade is closed. Trade conditions are still met because of my 6 bar Offset now another trade is placed (re-entry) bad

if that one or two bars moves 100 pips and my TP is 10, I've just had 10 trades, bad

I only want One trade per Signal (Offset included)

Does that make sense? i would still want it to trade within the 6 bars though if and opposite signal happens and the other trade was closed still.

Thanks

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

LinkBacks (?) LinkBack to this Thread: http://www.forex-tsd.com/metatrader-programming/554-how-code.html
Posted By	For	Type	Date
Need an experienced programmer? - Page 2	Post #0	Refback	09-24-2008 07:24 AM

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
How to code this?	iscuba11	Metatrader 4 mql 4 - Development course	1	08-03-2007 05:22 PM

Register in Forex TSD!
Trading Systems Leaders in this forum (automated trading systems) are winning more than 3000 pips in a month (30000$ investing one lot every time). Click here to register and get more information