How to open 1 trade per bar

anthonyrae · #1 (**permalink**) 04-13-2007, 01:47 PM

Hello,

I was wondering if there is anyone kind enough to tell me how you would program an expert advisor to open one trade only per bar. What I mean for this is, I have programmed an expert advisor that opens a buy trade when the current MACD is greater than the previous MACD, but opens a trade every time the price moves. I only want it to open 1 trade per bar, (the important bit is the 1 trade per bar, as I want it to open a trade for the next bar)

ie)

if trade < 1 for current bar ( open trade )
else
( do nothing )

If anyone can help, it would be much appreciated !

Cheers, Anthony

Kalenzo · #2 (**permalink**) 04-13-2007, 01:51 PM

You can use OrdersTotal() function and magic number and for or while loop.
Combine those and check if your magic number currently exists, if the answer will be true, then you should say to ea - do not open any trades now (eg. with "if")

anthonyrae · #3 (**permalink**) 04-14-2007, 01:18 AM

hi,

thanks for your help, but I couldn't figure out how to do it with what you suggested. however i have made a similar solution by saying only open a new trade if the time of the last trade was 15 mins ago (ie 1 trade every bar for the 15 min timeframe).

It seems to work, but it's not as accurate.

If anyone can give an example of code, it would be appreciated !

Cheers, Anthony

ralph.ronnquist · #4 (**permalink**) 04-14-2007, 01:53 AM

PHP Code:


			
bool opened_on_current_bar = false;



for (int i = OrdersTotal() - 1; i >=0; i-- ) {

    if ( ! OrderSelect( i, SELECT_BY_POS ) )

        continue;

    if ( OrderOpenTime() >= Time[ 0 ] ) {

        opened_on_current_bar = true;

        break;

    }

}

// Here the variable opened_on_current_bar is set appropriately

Kalenzo · #5 (**permalink**) 04-14-2007, 11:21 AM

Quote:

Originally Posted by ralph.ronnquist

PHP Code:


			
bool opened_on_current_bar = false;



for (int i = OrdersTotal() - 1; i >=0; i-- ) {

    if ( ! OrderSelect( i, SELECT_BY_POS ) )

        continue;

    if ( OrderOpenTime() >= Time[ 0 ] ) {

        opened_on_current_bar = true;

        break;

    }

}

// Here the variable opened_on_current_bar is set appropriately

Nice code but the condition OrderOpenTime() >= Time[0] will not work.
First some basic information:
OrderOpenTime() and Time[] are int's and they are like timestamp.
Time[0] is the current time value.

But lets say that we will use normal hours just for education purposes.
Assuming that we are currently on bar 12.00 on 1h chart, we open trade at 12.01, and lets say that we are 1 minute after that time (12.02).

Now lets check this condition:
if 12.01 >= 12.02 opened_on_current_bar = true;

will this code work ? I don't think so. And where is the magic number condition? Hm... try again

lowphat · #6 (**permalink**) 04-14-2007, 12:06 PM

could you do something like this or would it be bad practice?

Code:

if (NewBar() == true) allowtrade=true;

if (allowtrade)//entry
   {
   if(logic)buy;
   if(logic)sell;
   allowtrade=false;
   }

}

Code:

bool NewBar()
{
   static datetime lastbar = 0;
   datetime curbar = Time[0];
   if(lastbar!=curbar)
   {
      lastbar=curbar;
      return (true);
   }
   else
   {
      return(false);
   }
}

ralph.ronnquist · #7 (**permalink**) 04-14-2007, 02:02 PM

Time[0] is the opening time of the current bar.

Kalenzo · #8 (**permalink**) 04-14-2007, 04:22 PM

Quote:

Originally Posted by ralph.ronnquist

Time[0] is the opening time of the current bar.

No, Time[0] is the current time.

ralph.ronnquist · #9 (**permalink**) 04-14-2007, 05:27 PM

RTFM

http://docs.mql4.com/predefined/variables/time

antone · #10 (**permalink**) 04-15-2007, 11:21 AM

Code:

datetime OneTradePerBar; 

if(OneTradePerBar== iTime(NULL,TimeFrame,0)) return(0); else OneTradePerBar = iTime(NULL,TimeFrame,0);

that should do the Job.. instead of doing those other codes.. just add it before the trade codes..

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Using Gannswing to open trade	gee	Expert Advisors - Metatrader 4	1	02-15-2007 09:00 PM
Restarting EA with current open trade	dwmcqueen	Metatrader 4	5	01-26-2007 04:29 AM
script open trade	BrunoFX	Tools and utilities	6	05-21-2006 11:08 PM

Register in Forex TSD!
Trading Systems Leaders in this forum (automated trading systems) are winning more than 3000 pips in a month (30000$ investing one lot every time). Click here to register and get more information