Code to send email alerts when closed trades...

Nicholishen · #1 (**permalink**) 02-27-2006, 01:39 AM

I was writing some code to send me email alerts after trades close, regardless of whether or not the expert closed the trade or the trade was closed via TP or SL. I have tested it and it works, however, I am having problems with the emails violating SMTP rules when use MT4's SendMail(). (see http://cr.yp.to/docs/smtplf.html)

Does anyone know how to get around or correct this problem, because this would be a VERY valuble tool, especially for those who need to focus time on other work and would like to keep up to speed on the account as trades are being executed. Personally, it would be great to have trades emailed to my BlackBerry to see the details after the trade is close. I appreciate any help!

cockeyedcowboy · #2 (**permalink**) 02-27-2006, 02:21 AM

Nicholishen

Try to send emails to other address, like some friend that receives email on different sever then yours. I use a mailer to send messages to myself from MetaQuote and I get errors when sending to HotMail.com addresses, the emailer wont work. Thats the only email sever I can't send to. LF means LINE FEED. In your message it mentions MSN net work which includes hotmail.com. Also some email severs donot permit you to email to the address from which the mail originates from as well. Emailing to a friend will at least eliminate the above conditions from the list.

I have not used the mailer that comes with MQ. I use a third party software, as MQ didnot have that function back in v3.xx I have not rewriten my communication module to use the built-in mailer yet, plan to do this in the near future.

The CockeyedCowboy

Nicholishen · #3 (**permalink**) 02-27-2006, 02:24 AM

...It seems that it did not like my "\n" statements.

To use the mail alert you must first setup MT preferences. If you haven't yet done it, you would go to: TOOLS>OPTIONS>EMAIL. Enable the email feature and set the preferences for SMTP.

Depending on how you intend to use it you can insert it into your code and change the subject to the name of the advisor. Make sure to add filters to the qualifying if statement. An example is inserted but commented out. Optionally you can just#include as a generic mailer.

The benefit of this is to have the system email you the details of closed trades; even when they have closed due to SL or TP.

I would appreciate feedback as to what details you would like to see in the email.

Nicholishen · #4 (**permalink**) 02-27-2006, 02:26 AM

Quote:

Originally Posted by cockeyedcowboy

Nicholishen

Try to send emails to other address, like some friend that receives email on different sever then yours. I use a mailer to send messages to myself from MetaQuote and I get errors when sending to HotMail.com addresses, the emailer wont work. Thats the only email sever I can't send to. LF means LINE FEED. In your message it mentions MSN net work which includes hotmail.com. Also some email severs donot permit you to email to the address from which the mail originates from as well. Emailing to a friend will at least eliminate the above conditions from the list.

I have not used the mailer that comes with MQ. I use a third party software, as MQ didnot have that function back in v3.xx I have not rewriten my communication module to use the built-in mail yet, plan to do this in the near future.

The CockeyedCowboy

...looks like we posted at same time. Thanks for the info!

dimmyr · #5 (**permalink**) 05-27-2009, 02:36 AM

I used your script and beefed it up a bit. Can't get around /n but it works for me. I am not a coder, I just played a little.

I would like to change it to alert on every instance of a market order, opening or closing.

Can you look at the code and see how you can augment the EA to do that?

Code:

//+------------------------------------------------------------------+
//|                                               MailAlert TEST.mq4 |
//|                                                      Nicholishen |
//|                                                                  |
//+------------------------------------------------------------------+
//http://www.forex-tsd.com/metatrader-4/1125-code-send-email-alerts-when-closed-trades.html
#property copyright "Nicholishen"
#property link      ""
int k;
//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
for(int i=0;i<1000;i++){
      if(OrderSelect(i,SELECT_BY_POS,MODE_HISTORY)){
         if(OrderSymbol()==Symbol()  ){
            k++;
         }
      }else{
         break;
      }  
   }
   Comment("Init() Trades Count = ",k);
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
  {
//----

int f =0;
   for(int i=0;i<10000;i++){
      if(OrderSelect(i,SELECT_BY_POS,MODE_HISTORY)){
         if(OrderSymbol()==Symbol() /*&& OrderMagicNumber()==MAGICMA && OrderComment() ==Cmt(Period())*/ ){
            f++;
          
         }
      }else{
         break;
      }  
   }
   Comment(" Trades in History ",f," Init cnt ",k  );
   if(k < f){
      string ordertyp;
      
      OrderSelect(f,SELECT_BY_POS,MODE_HISTORY);
      if(OrderType()==0)ordertyp="BUY";
      if(OrderType()==1)ordertyp="SELL";
      SendMail("prof: "+DoubleToStr(OrderProfit(),2)+", bal: "+DoubleToStr(AccountBalance(),2)+", eq: "+DoubleToStr(AccountEquity(),2)+"",
      "Symbol: "+Symbol()+" "+ordertyp+"   "+DoubleToStr(OrderMagicNumber(),0)+" \n"+
      "Comment: "+DoubleToStr(OrderComment()
      "Ticket: "+DoubleToStr(OrderTicket(),0)+" \n"+ 
      "Size: "+DoubleToStr(OrderLots(),2)+" \n"+ 
      "OpenTime: "+TimeToStr(OrderOpenTime())+" \n"+
      "Close Time: "+TimeToStr(OrderCloseTime())+" \n"+
      "Open: "+DoubleToStr(OrderOpenPrice(),4)+" \n"+
      "Close: "+DoubleToStr(OrderClosePrice(),4)+" \n"+
      "Profit: "+DoubleToStr(OrderProfit(),2)+" \n\n"+

      "Balance: "+DoubleToStr(AccountBalance(),2)+" \n"+
      "Used Margin: "+DoubleToStr(AccountMargin(),2)+" \n"+
      "Free Margin: "+DoubleToStr(AccountFreeMargin(),2)+" \n"+
      "Equity: "+DoubleToStr(AccountEquity(),2)+" \n"+
      "Open Orders: "+DoubleToStr(OrdersTotal(),0)+"" );

      k++;
   }
 return;
} 


//----
  
//+------------------------------------------------------------------+

dimmyr · #6 (**permalink**) 06-01-2009, 09:46 PM

Just made final modifications to it.

It alerts upon the close of a trade on a pair to which the EA was attached. I use a commercial EA, and I open up an extra chart to which I attach the alerter.

I would love to have it augmented to alert on trade openings as well, but I am not that smart yet. If anyone can contribute to this code, that would be great!

This is what the email looks like:

Subject: CLOSE pr: 23.59, bal: 5152.57, eq: 5058.81

Symbol: <PAIR> <BUY/SELL> <MAGIC#>
Comment: <COMMENT>
Ticket#: <TICKET#>
Size: <SIZE_LOT>
OpenTime: <OPEN_TIME/DATE>
Close Time: <CLOSE_TIME/DATE>
Open: <OPEN_PRICE>
Close: <CLOSE_PRICE>
Profit: <$PROFIT>
Pips: <PROFIT_IN_PIPS>

Balance: <CURRENT_BALANCE>
Used Margin: <USED_MARGIN>
Free Margin: <FREE_MARGIN>
Equity: <CURRENT_EQUITY>
Open Orders: <CURRENT_OPEN_ORDERS>

Broker: <BROKER_NAME>
Leverage: <LEVERAGE_USED>

dimmyr · #7 (**permalink**) 06-09-2009, 06:15 AM

Looks like my EA counts wrong, gives me some random closed trade from history. Anyone can look at the code?

CilO · #8 (**permalink**) 06-12-2009, 07:00 AM

Hello !

First, i would like to thank the many contributos of the forum ! Great place !!!

I have no skills in programming and would like to slightly modify an indicator i use.
It sends an email whena na alert occurs. All is mentionned except the price.
So, what to add to have the price inserted in the email ?

SendMailOnce("Signal " + Symbol(),Symbol()+ ":" + PeriodToText() + " - Up Signal" + #price# ,1);

I will have to specify the correct code for price as well as a conversion from real to string.

I know this sounds too easy for most of you, but it will help me a lot !

Thanks in advance,

CilO