Trouble Shooting

Mr.Marketz · #1 (**permalink**) 11-02-2006, 07:10 PM

So I’m trying to piece together my first EA… obviously I’m at a dead end. The concept is to combine two functions which are:

Run (close profitable trades) executed every designated (time cycle)
I have two user input options – 1 (define profitable) and 2 define (time cycle). I believe most of the code is in order.

I am left with one last error “end program”... and I can't figure out why. Can someone with a bit more experience at coding please correct what I’m doing wrong? It’s driving me CRAZY!!!

Thanks in advance,
MM

Michel · #2 (**permalink**) 11-02-2006, 08:36 PM

Quote:

Originally Posted by Mr.Marketz

So I’m trying to piece together my first EA… obviously I’m at a dead end. The concept is to combine two functions which are:

Run (close profitable trades) executed every designated (time cycle)
I have two user input options – 1 (define profitable) and 2 define (time cycle). I believe most of the code is in order.

I am left with one last error “end program”... and I can't figure out why. Can someone with a bit more experience at coding please correct what I’m doing wrong? It’s driving me CRAZY!!!

Thanks in advance,
MM

The "For" do not have an ending bracket

Mr.Marketz · #3 (**permalink**) 11-03-2006, 08:28 PM

Did as suggested, and compiles fine now. However upon running it live I noticed it did not work as specified. In other words I set the time update to 15 min and it never initialized the Close All Profitable Positions script. Any thoughts?

Michel · #4 (**permalink**) 11-03-2006, 10:29 PM

PHP Code:


			
double   LastUpdate = CurTime();

//----

if (MathAbs(CurTime()-LastUpdate)> UpdateInterval*60)

This will never work, as at each tick you assign at lastUptade the value Curtime(), then, immediately after, you check if there is a difference between both...no.
The right way is:

PHP Code:


			
if(CurTime() >= LastUpdate + UpdateInterval*60)

{

   BlahBlahBlah;

   LastUpdate = CurTime();

}

My 2 cents : Why this time trick ? you can check all your orders every tick and close those which have reached your target !

EDIT : sorry, I didn't see it is a Script and not an EA, so there is another reason why it doesn't work : a script is executed only once : if you want to check something periodically, you have to write some loop in the code

Mr.Marketz · #5 (**permalink**) 11-07-2006, 09:37 PM

Quote:

Originally Posted by Michel

PHP Code:


			
double   LastUpdate = CurTime();

//----

if (MathAbs(CurTime()-LastUpdate)> UpdateInterval*60)

This will never work, as at each tick you assign at lastUptade the value Curtime(), then, immediately after, you check if there is a difference between both...no.
The right way is:

PHP Code:


			
if(CurTime() >= LastUpdate + UpdateInterval*60)

{

   BlahBlahBlah;

   LastUpdate = CurTime();

}

My 2 cents : Why this time trick ? you can check all your orders every tick and close those which have reached your target !

EDIT : sorry, I didn't see it is a Script and not an EA, so there is another reason why it doesn't work : a script is executed only once : if you want to check something periodically, you have to write some loop in the code

Thanks Michel,

I might have to leave this one to the pros.

MM

Michel · #6 (**permalink**) 11-07-2006, 09:48 PM

Quote:

Originally Posted by Mr.Marketz

Thanks Michel,

I might have to leave this one to the pros.

MM

No ! You will never learn if you do not try !
Just write an EA to close your trades, not a script : put your test and the close func in the "start" func without any time-trick, that's all : at every tick the start function is called, there all your trades will be checked and eventually closed.