Originally Posted by zuijlen

I know that bolla created an EA combining V1 and V2, which has been posted in this thread. I have not used it myself, but wouldn't it be easier to base continued development on that one?

Originally Posted by mikejody

Ryan, can you explain in laymen's (non-programmer) terminology the reason we would need this "clean code" version? I am not knocking the value of it, and can see from a coder's perspective why it would be important to work with clean code, but from an end-users perspective who knows nothing about code, would there be a reason why I would not keep using the same dirty code V1andV2mini that I have been using?

Also, is the V1clean for mini accounts or standard?

Originally Posted by zuijlen

Mike, the mean reason to clean up the code is that it would be easier to work with for a programmer if he/she wants to improve upon it. From an end-user perspective it doesn't make any difference. I remember cucurucu being reluctant to post the EAs beacuse the code was "dirty", so we may be grateful that he actually did post them and should not criticize the code for what it is because he never claimed anything else. That said, I do appreciate the efforts of Ryan to clean it up, as this will help further development.

V1clean is equivalent to the original V1, so would be for a standard account.

Originally Posted by ryanklefas

Voila!

Settings for V1 and V2. These setting files are used by "V1 Clean" which is to be found a few posts up.

Originally Posted by ryanklefas

For simplicity, put the settings files with the EA. (Actually they can be loaded from anywhere). To get the hedge that you have been using with V1 and V2

Originally Posted by Dr. Lemmy Kilmeister

The code for V1 and V2 positively stinks. It appears to have been written by a 6 yr. old kid. Probably was.

Originally Posted by ryanklefas

As I said earlier, V1 and V2 are actually the same EA with different settings. This setup just makes it more obvious. Also, I won't have to modify 2 or more EAs every time a new feature is needed. I'll just be modifying one EA.

Originally Posted by ryanklefas

Here is a cleaner version of V1. If this EA works the way I think it does, to get a "V2" all you have to do is change a few of the settings. Here is what I did

I cleaned out unnecessary variables, changed unintelligible variable and file names so that you can somewhat understand what the EA is doing, organized the code so it is easier to read, and brought out some of the external inputs that were hidden away.

I have not implemented anything new; if someone can verity that this cleaner version works as the "dirty" ones did, then I will start adding features to it. I've attached a strategy test that "V1 Clean" produced. All looks well?


PS: It is my humble honor to help the community develop this promising EA

Originally Posted by cucurucu

Thank you doc. You are so kind.

That's yesterday's news. Search the post where I first posted the EAs and read "the code is messy ...". However, MT4 uses the ex4 file.

Originally Posted by Dr. Lemmy Kilmeister

50% modeling quality on control points is pure junk.