Pivot indicators - Page 4

bookfixer · #31 (**permalink**) 07-10-2006, 10:27 AM

Thanks cja, that is just what I was looknig for!

Jim

cardio · #32 (**permalink**) 07-18-2006, 04:38 AM

Help with pivot indicator

Hi
I am trying to make a pivot indicator - that should show the pivot possition on an hourly or half hourly chart. I want to see the pivot position of the pivot for the last 1000 bars on the chart.
I have written the following - but it is not working. I see it calculates but draws nothing.

Please help

Code:

//+------------------------------------------------------------------+
//|                                                       pivot1.mq4 |
//|                      Copyright © 2006, MetaQuotes Software Corp. |
//|                                        http://www.metaquotes.net |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2006, MetaQuotes Software Corp."
#property link      "http://www.metaquotes.net"

#property indicator_chart_window
double piv1[];
static double h1,l1,c1,p;
int Previous_day;
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
  {
//---- indicators
   SetIndexStyle(0,DRAW_LINE,2);
   SetIndexBuffer(0,piv1);
   
   
   if (Period() == 1440) l1=1;
   if (Period() == 240) l1=6;
   if (Period() == 60) l1=24;
   if (Period() == 30) l1=48;
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
  {
   int shift,  counted_bars=IndicatorCounted();
   if(counted_bars<1000+(l1+1)) return(-1); 
  
//---- main calculation loop 
   shift=1000; 
   while(shift>=0) 
     {
//----
   
     if (Previous_day!=TimeDay(Time[shift+1]))  //get the day of month for the previous bar
     {  
     // a new day has started so recalc pivot point
      Previous_day=TimeDay(Time[shift+1]); 
      
      h1=0; l1=10000000;
      int i;
      for (i=shift+l1;i>=shift;i--)
      {
         h1 = MathMax( h1, High[i]);
         l1  = MathMin( l1 , Low[i]);      
      }   
 
      c1 = Close[i+1];
      p = (h1+l1+c1) / 3;
      piv1[shift] =p;
      shift--;// 
      Print("p : ",p," ,Pevious_day : ",Previous_day);
     }
     else 
     {
       // a new day has not started so use the same pivot point as yesterday
       piv1[shift] = p;
       Previous_day=TimeDay(Time[shift+1]); 
       shift--;// 
     }
  
  }  
//----
   return(0);
  }
//+------------------------------------------------------------------+

elihayun · #33 (**permalink**) 07-18-2006, 05:25 AM

Your problem is that in every day change you are taking the high/low/open/close of the current TF not the daily TF

do not use : High[shift] use iHigh(NULL, PERIOD_D1, shift) and so on

cardio · #34 (**permalink**) 07-18-2006, 12:50 PM

thanks elihayun I will give it a go - though I don't think that is the problem.

i do use high[shift], I go into a loop when a new day is detected and it determines the high,low for the previous day here is the loop -

Code:

     // a new day has started so recalc pivot point
      Previous_day=TimeDay(Time[shift+1]); 
      
      h1=0; l1=10000000;
      int i;
      for (i=shift+l1;i>=shift;i--)
      {
         h1 = MathMax( h1, High[i]);
         l1  = MathMin( l1 , Low[i]);      
      }   
 
      c1 = Close[i+1];
      p = (h1+l1+c1) / 3;
      piv1[shift] =p;
      shift--;//

elihayun · #35 (**permalink**) 07-18-2006, 02:02 PM

Quote:

Originally Posted by cardio

thanks elihayun I will give it a go - though I don't think that is the problem.

i do use high[shift], I go into a loop when a new day is detected and it determines the high,low for the previous day here is the loop -

Code:

     // a new day has started so recalc pivot point
      Previous_day=TimeDay(Time[shift+1]); 
      
      h1=0; l1=10000000;
      int i;
      for (i=shift+l1;i>=shift;i--)
      {
         h1 = MathMax( h1, High[i]);
         l1  = MathMin( l1 , Low[i]);      
      }   
 
      c1 = Close[i+1];
      p = (h1+l1+c1) / 3;
      piv1[shift] =p;
      shift--;//

1) How do u know that the TF will be D1? If you change the TF you will see pivot of the current TF
2) How do u know that there are 10000000 bars ? U better use Bars instead.

cardio · #36 (**permalink**) 07-18-2006, 02:51 PM

Hi

I think I have found what I am looking for in this post

Historical Pivot Indicator

post 7

I think I can modify the indicators there - I will try and post results.

Thank you for your help and interest Elihayun.

ligerny · #37 (**permalink**) 07-22-2006, 03:30 PM

Hi,

Does anyone have any ebooks or absolute begginers to advanced course for learning how to use pivot points, preferrably for forex and any regular unmodified mt4 pivot point indicator that's good ?

thnx

sailor · #38 (**permalink**) 07-22-2006, 04:14 PM

try this site http://www.investopedia.com/terms/p/pivotpoint.asp
also just search the site for other info :-)

sailor

ligerny · #39 (**permalink**) 07-22-2006, 04:49 PM

thnx sailor, is there also a website where i can get previous day's high, low, open, and close. im sure there's a website which keeps that info ?

fxtraderguru · #40 (**permalink**) 07-22-2006, 06:18 PM

Depending on the trading platform you have selected...go to the day of your choice, look for the daily HIGH, LOW, OPENING Candle and CLOSING Candle.

Place your mouse over them respectfully and write down the info you need. Place it in a PP calculator and then draw your lines as needed, or simply keep the sheet near your screen for reference.

Depending on the trading platform you may want to use: there are indicators that can be placed right on your chart to calculate PP and re-draw them everyday.