Help: How to write simple EA to buy and sell at a specific time? - Page 4

mauro269 · #31 (**permalink**) 04-09-2008, 03:23 PM

I didn't understand.

This EA seems that starts and finishes to work for the time that you choice in the settings. Now, is it able to open a sell and buy order in the same time on the same pair with prefixed TP and SL?

Flying Fish · #32 (**permalink**) 04-11-2008, 03:40 AM

Quote:

Originally Posted by matrixebiz

What is this actually doing? I don't understand what this code is doing.
Thanks you

I thought you were asking for some programming help, I missed the part were you wanted someone to code it for you. Please disregard my post.

matrixebiz · #33 (**permalink**) 04-13-2008, 05:40 PM

Hello, I have this TimeBased EA that opens trade at a specific time;

Code:

//+------------------------------------------------------------------+
//|                                                  TimeBasedEA.mq4 |
//|                      Copyright © 2008, MetaQuotes Software Corp. |
//|                                       http://www.metaquotes.net/ |
//+------------------------------------------------------------------+
//changed by:       "forex4capital@yahoo.ca"

// Time frame: M5 and higher

extern int     MagicNumber = 20080122;
extern int     OpenHour     = 8;        
extern int     OpenMinute   = 55;      
extern double  TakeProfit  = 10;
extern double  StopLoss    = 10;
extern double  Lots        = 0.1;
extern bool    OpenBuy     = true;
extern bool    OpenSell    = false;
extern int     NumBuys     = 1;
extern int     NumSells    = 1;
extern int     Slippage    = 3;

//+------------------------------------------------------------------+
//|                        S T A R T                                 |
//+------------------------------------------------------------------+
int start()
  {
   int cnt, ticket, total;
   //int ct;
//-------------------------------------+
   if(Bars<100)
     {
      Print("bars less than 100");
      return(0);  
     }
//-------------------------------------+
   if(TakeProfit<10)
     {
      Print("TakeProfit less than 10");
      return(0);  // check TakeProfit
     }
//-------------------------------------+
   //ct = Hour() * 100 + Minute();
   total=OrdersTotal();
   if(total<1) 
     {
      // no opened orders identified
      if(AccountFreeMargin()<(1*Lots))
        {
         Print("We have no money. Free Margin = ", AccountFreeMargin());
         return(0);  
        }
      // check for long position (BUY) possibility
      if (Hour()==OpenHour && Minute()>=OpenMinute && OpenBuy)
      //if(ct == StartHour && Close[1]>Open[1] && OpenBuy)
      //if(ct == StartHour && High[1]<Open[0] && OpenBuy)
        {
         for ( cnt = 0; cnt < NumBuys; cnt++)
         {
           ticket=OrderSend(Symbol(),OP_BUY,Lots,Ask,Slippage,Bid-StopLoss*Point,Ask+TakeProfit*Point,"",MagicNumber,0,Blue);
           if(ticket>0)
           {
            if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES)) Print("BUY order opened : ",OrderOpenPrice());
           }
           else Print("Error opening BUY order : ",GetLastError()); 
         }
         return(0); 
        }
      // check for short position (SELL) possibility
      if (Hour()==OpenHour && Minute()>=OpenMinute && OpenSell)
      //if(ct == StartHour && Close[1]<Open[1] && OpenSell)
      //if(ct == StartHour && Low[1]>Open[0] && OpenSell)
        {
         for ( cnt = 0; cnt < NumSells; cnt++)
         {
           ticket=OrderSend(Symbol(),OP_SELL,Lots,Bid,Slippage,Ask+StopLoss*Point,Bid-TakeProfit*Point,"",MagicNumber,0,Red);
           if(ticket>0)
           {
            if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES)) Print("SELL order opened : ",OrderOpenPrice());
           }
           else Print("Error opening SELL order : ",GetLastError());
         } 
         return(0); 
        }
     }
   return(0);
  }
// the end

How do I add in Close code to Close the trade at another specific time?

Code:

//---- Close input parameters
extern int   CloseHour     = 7;      // Âðåìÿ çàêðûòèÿ, ÷àñû
extern int   CloseMinute   = 0;      // Âðåìÿ çàêðûòèÿ, ìèíóòû
bool  UseCurrSymbol = True;  // Èñïîëüçîâàòü òîëüêî îäèí èíñòðóìåíò
extern color clCloseBuy    = Blue;   // Öâåò çàêðûòèÿ ïîêóïêè
extern color clCloseSell   = Red;    // Öâåò çàêðûòèÿ ïðîäàæè.....

.............

  if (Hour()==CloseHour && Minute()>=CloseMinute) {
    for (int i=OrdersTotal()-1; i>=0; i--) {
      if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES)) {
        if (!UseCurrSymbol || OrderSymbol()==Symbol()) {
          if (OrderType()==OP_BUY) {
            pBid=MarketInfo(OrderSymbol(), MODE_BID);
            OrderClose(OrderTicket(), OrderLots(), pBid, Slippage, clCloseBuy);
          }
          if (OrderType()==OP_SELL) {
            pAsk=MarketInfo(OrderSymbol(), MODE_ASK);
            OrderClose(OrderTicket(), OrderLots(), pAsk, Slippage, clCloseSell);
          }
        }
      }
    }
  }
}

Thanks

newdigital · #34 (**permalink**) 04-13-2008, 05:48 PM

Explanation about EA (with the same name and functions so may be it is the same EA) is on the first page of this thread.

And the other EAs are on this thread (as th links) Buy/sell EA

matrixebiz · #35 (**permalink**) 04-13-2008, 05:59 PM

Quote:

Originally Posted by Flying Fish

I thought you were asking for some programming help, I missed the part were you wanted someone to code it for you. Please disregard my post.

No, I just want to know what the code means or is telling me so I can understand what it is doing. You don't have to write another EA, just explain or clarify what the code is it's meanings, got it? because I was trying to add "if (Hour()==CloseHour && Minute()>=CloseMinute)" but was getting errors/warnings ('CloseHour' - expression on global scope not allowed)

waltini · #36 (**permalink**) 04-14-2008, 02:03 PM

Hope this works

matrixebiz · #37 (**permalink**) 04-15-2008, 10:54 PM

Quote:

Originally Posted by waltini

Hope this works

No it didn't close the trade

it kept opening and closing the trade in a loop and didn't allow different currencies to open, and doesn't work with USD/CHF

waltini · #38 (**permalink**) 04-16-2008, 09:57 PM

Hi Matrixebiz,

I have tested it again on a mini ibfx platform and it works fine for me.

Please post your set file and I will try it with your settings.

waltini · #39 (**permalink**) 04-17-2008, 12:09 AM

http://www.forex-tsd.com/attachment....d=12083906 40

I am trying my first picture

Jeeves · #40 (**permalink**) 05-21-2008, 05:44 PM

Hello there.
I have traded a demonstration account for a year and would like my system made into an EA. I do not know how to do it. But it is a very easy system.
I place a straddle trade using the high and the low of the 12:00pm 1 hour candle. Broker time.
Tp 15
SL 15
No more.
I would like to change the TP & SL if I want. Also the bar time.
If you can help I would be very happy.
Thank you

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

LinkBacks (?) LinkBack to this Thread: http://www.forex-tsd.com/expert-advisors-metatrader-4/8067-help-how-write-simple-ea-buy-sell-specific-time.html
Posted By	For	Type	Date
Ø¯Ø±Ø®ÙˆØ§Ø³Øª Indicator Ùˆ expert - ØµÙØÙ‡ 84 - Sarmaye Forums	This thread	Refback	03-23-2008 11:36 AM

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Detecting price trend independent of a specific time frame	gee	Metatrader 4	4	02-24-2007 04:53 PM
Anyone want to write a simple EA?	Kaper	Suggestions for Trading Systems	6	10-29-2006 10:36 PM
A Simple Buy/Sell Script	excite2	Expert Advisors - Metatrader 4	8	07-18-2006 03:16 AM
Simple question of determining the time of day	Fishtank	Metatrader 4	2	04-04-2006 04:12 AM

Register in Forex TSD!
Trading Systems Leaders in this forum (automated trading systems) are winning more than 3000 pips in a month (30000$ investing one lot every time). Click here to register and get more information