I'm having a problem with this EA. It is supposed to close all pending orders when a stop loss is modified, however, it is closing all my orders before the stop loss is being modified. Hence, I don't even know if the stop order modifications work correctly.





//+------------------------------------------------------------------+
//| Millionaire.mq4 |
//| Copyright © 2007, MetaQuotes Software Corp. |
//| http://www.metaquotes.net |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2007, MetaQuotes Software Corp."
#property link "http://www.metaquotes.net"

#include <stdlib.mqh>
#include <WinUser32.mqh>


extern double Price1;
extern double HighPrice = 0;



int start()
{
if(OrderSelect(0,SELECT_BY_POS,MODE_TRADES)==true)
{
Price1 = OrderOpenPrice();
if(Bid>HighPrice==true)
{
HighPrice = Bid;
}

{
if(((HighPrice - OrderOpenPrice()) > (40 * Point)) && (OrderStopLoss() < (HighPrice - (20 * Point)))==true)
{
OrderModify(
0,
OrderOpenPrice(),
HighPrice - (20 * Point),
HighPrice + (100 * Point),
0,
CLR_NONE);
int total = OrdersTotal();

for(int i=total-1;i>=0;i--)
{
OrderSelect(i, SELECT_BY_POS);
int type = OrderType();

bool result = false;

switch(type)
{

//Close pending orders
case OP_BUYLIMIT :
case OP_BUYSTOP :
case OP_SELLLIMIT :
case OP_SELLSTOP : result = OrderDelete( OrderTicket() );
}

if(result == false)
{
Alert("Order " , OrderTicket() , " failed to close. Error:" , GetLastError() );
Sleep(3000);
}
}
}
}
}
return(0);
}

It looks to me like you have statements for closing orders IMMEDIATELY after the statements for modifying them, which would cause what you are getting. By the way, why are you trying to modify a stop AND THEN delete the order? Makes no sense to me. While we're thinking along these lines, I just made an EA that can modify stops and close orders. You can check it out below. Maybe it will help you, maybe it won't. At the very least, you can check the code as a programming example:

Swiss Army EA (Automatic order management)

__________________
"Don't work harder, work smarter." -- my Java professor

Advertise on The All New FireCell Network
"Where online investing makes sense"

Coder for Hire:
http://firecell.info