Turtles EA

Aaragorn · #1 (**permalink**) 12-16-2006, 07:12 PM

InvestorMe Asked me to post this on it's own thread. It's not fully debugged. I don't know why it never opens any long positions. There's still alot about this strategy I don't yet understand.

kyliejaeger · #2 (**permalink**) 12-17-2006, 05:31 AM

Valvk talks about his turtle EA currently #2 in the championship. Turtle Power!!

http://championship.mql4.com/2006/news/92

sstillwell · #3 (**permalink**) 12-17-2006, 07:42 PM

Quote:

Originally Posted by Aaragorn

InvestorMe Asked me to post this on it's own thread. It's not fully debugged. I don't know why it never opens any long positions. There's still alot about this strategy I don't yet understand.

Running backtest, it DOES open long and short positions...

The problem I had is that it only opens positions in backtest if I use "control points"...it doesn't open any orders at all if I use "every tick".

Weird.

I'm on IBFX...I'll start forward testing as soon as the market opens.

sstillwell

sstillwell · #4 (**permalink**) 12-17-2006, 07:46 PM

Also, look out for this...

Code:

void ClosePending()
 { 
     if(OrderType()<=OP_SELL && OrderSymbol()==Symbol() && OrderComment()=="Trend Rider" && OrderMagicNumber()==MAGIC) 
        {
          if(OrderType()==OP_BUY) OrderClose(OrderTicket(),OrderLots(),Bid,3,Violet);
          else if (OrderType()==OP_SELL) OrderClose(OrderTicket(),OrderLots(),Ask,3,Violet);
        }
 }

No orders ever get sent with the comment "Trend Rider", it should be:

Code:

void ClosePending()
 { 
     if(OrderType()<=OP_SELL && OrderSymbol()==Symbol() && OrderComment()=="Turtles" && OrderMagicNumber()==MAGIC) 
        {
          if(OrderType()==OP_BUY) OrderClose(OrderTicket(),OrderLots(),Bid,3,Violet);
          else if (OrderType()==OP_SELL) OrderClose(OrderTicket(),OrderLots(),Ask,3,Violet);
        }
 }

don't you think so?

Regards,

sstillwell

investor_me · #5 (**permalink**) 12-17-2006, 08:49 PM

Quote:

Originally Posted by sstillwell

Also, look out for this...

Code:

void ClosePending()
 { 
     if(OrderType()<=OP_SELL && OrderSymbol()==Symbol() && OrderComment()=="Trend Rider" && OrderMagicNumber()==MAGIC) 
        {
          if(OrderType()==OP_BUY) OrderClose(OrderTicket(),OrderLots(),Bid,3,Violet);
          else if (OrderType()==OP_SELL) OrderClose(OrderTicket(),OrderLots(),Ask,3,Violet);
        }
 }

No orders ever get sent with the comment "Trend Rider", it should be:

Code:

void ClosePending()
 { 
     if(OrderType()<=OP_SELL && OrderSymbol()==Symbol() && OrderComment()=="Turtles" && OrderMagicNumber()==MAGIC) 
        {
          if(OrderType()==OP_BUY) OrderClose(OrderTicket(),OrderLots(),Bid,3,Violet);
          else if (OrderType()==OP_SELL) OrderClose(OrderTicket(),OrderLots(),Ask,3,Violet);
        }
 }

don't you think so?

Regards,

sstillwell

You're absolutely right. This is among a few more issues that are being worked on. I hope we could post the newer version soon so we can get contributions. Please, whoever wishes to contribute can do so and post the new version. It should be team work

mikhaildgreat · #6 (**permalink**) 12-17-2006, 10:12 PM

hello,

Im also developing my own turtle EA, perhaps we could work together

Anyways I also started a thread for my Ninja Turtle!

heres the link: MY TURTLES EA - need Testers

Ok Happy Holidays!
Mikhail

iPlayGames · #7 (**permalink**) 12-18-2006, 03:33 PM

do not use ordercomment() to identify your trades, use ordermagicnumber() instead. some brokers modify comments of orders sent to them by an EA.

sstillwell · #8 (**permalink**) 12-18-2006, 03:36 PM

Good idea. We're already identifying by magic number, so matching comment is kind of redundant.

sstillwell

Aaragorn · #9 (**permalink**) 12-18-2006, 07:58 PM

I fixed the close pending function....

It still wasn't working cause it didn't have anything selected... now it works

void ClosePending()
{
for(int i=0;i<=OrdersTotal(); i++)
{
OrderSelect(i,SELECT_BY_POS,MODE_TRADES);
if(OrderSymbol()==Symbol() && OrderComment()=="Turtles" && OrderMagicNumber()==MAGIC)
{
if(OrderType()==OP_BUY) OrderClose(OrderTicket(),OrderLots(),Bid,3,Violet) ;
else if (OrderType()==OP_SELL) OrderClose(OrderTicket(),OrderLots(),Ask,3,Violet) ;
}
}
}

i know it's comparision is still redundant but that doesn't really effect anything so I didn't change it. Sometimes redundancy is security, if it doesn't hurt anything.

sstillwell · #10 (**permalink**) 12-18-2006, 11:36 PM

You shouldn't need to do that.

ClosePending() is called from within the PendingOrders() loop, where the order is already being selected.

What problem are you observing that makes you think it needs to be changed?

sstillwell