Show Us Your Best EA - Page 65

Michel · #**641** (**permalink**) 04-27-2008, 09:02 PM

Quote:

Originally Posted by 360648

Please

Thanks for sharing your strategy; we need minds like yours here !
But did you already forward test it ?
I don't think so, because there is an error in your code.
It's not very important because it's not an essential part of your strategy, but it cannot work correctly in forward test.
After the closing of an order, you are waiting 100 or 1000 seconds before eventually openning a new one; here is your code:

PHP Code:


			
  hstTotal=HistoryTotal();



   OrderSelect(hstTotal,SELECT_BY_TICKET,MODE_HISTORY);

   ctm=OrderCloseTime();



   if (CurTime() - ctm < waittime)

      return;

If we replace the obsolete functions, this is equivalent to

PHP Code:


			
   hstTotal=OrdersHistoryTotal();



   OrderSelect(hstTotal,SELECT_BY_TICKET,MODE_HISTORY);

   ctm=OrderCloseTime();



   if (TimeCurrent() - ctm < waittime)

      return;

In backtest mode this works as the ticket numbers are counted from 1, 2, 3, and so on, so OrderHistoryTotal() reflects the ticket number of the last closed order, but with a broker, the ticket numbers may be 645230, 645259, ...
Also you are depending of the sorted collumn of the history table, so it's not the highest index which point to the last closed order.
I sugest you the following code to find the lastest close time :

PHP Code:


			
for(int i = 0; i < OrderHistoryTotal(); i ++) {

 OrderSelect(i, SELECT_BY_POS, MODE_HISTORY);

 cmt = MathMax(cmt, OrderCloseTime()); 

}

Now you should be carefull with this kind code because there is a bug in MT4 and the backtests are looking in the real history and not the one build by the backtest itself. I do not know if now this bug is fixed or not (but it's easy to check).
Cheers !

clement · #**642** (**permalink**) 04-28-2008, 09:08 AM

hello thank you for testing the ea pls i would like to know how well it perforemed and if the errors you stated are risky and if there have to be corrections in the ea on wat accoutn did you use if for and wat was the gain pls i will like you to help me coreect the error and end me reply so i will kjnow how well it will perform this is my first ea and i was hoping it will work without errors pls get back to me with corrections you have made and pls help me back test and forward test so i will know how well it will work pls do get back to me soon and do you think it will work with a mini acount of 1000 dollars

Michel · #**643** (**permalink**) 04-28-2008, 10:52 AM

Quote:

Originally Posted by clement

hello thank you for testing the ea pls i would like to know how well it perforemed and if the errors you stated are risky and if there have to be corrections in the ea on wat accoutn did you use if for and wat was the gain pls i will like you to help me coreect the error and end me reply so i will kjnow how well it will perform this is my first ea and i was hoping it will work without errors pls get back to me with corrections you have made and pls help me back test and forward test so i will know how well it will work pls do get back to me soon and do you think it will work with a mini acount of 1000 dollars

When sombody posts an EA, my intention is more to understand what is the strategy behind, what is the EA intended to do, than to use it for myself.
Then, if I understand what the author is willing to do but I see that the code is wrong to do exactly that, I call this an "error" and try to explain it to the author and also to help him to correct it. That's was the point of my previous post.

This doesn't mean that the EA is not working, but instead that it's not working as it is expected to work following my understanding.

Of course, if the EA's "author" is not the real one and if he doesn't understand anything about coding, he cannot understand what I mean.

You stated "this is my first ea", but let me have some doubt about that: inside the code there are obsolete functions which are not used since more than one year now....

forexmoments · #**644** (**permalink**) 04-28-2008, 11:18 AM

Quote:

Originally Posted by clement

hello thank you for testing the ea pls i would like to know how well it perforemed and if the errors you stated are risky and if there have to be corrections in the ea on wat accoutn did you use if for and wat was the gain pls i will like you to help me coreect the error and end me reply so i will kjnow how well it will perform this is my first ea and i was hoping it will work without errors pls get back to me with corrections you have made and pls help me back test and forward test so i will know how well it will work pls do get back to me soon and do you think it will work with a mini acount of 1000 dollars

Do you know how to use punctuation?

cockeyedcowboy · #**645** (**permalink**) 04-28-2008, 01:12 PM

Quote:

Originally Posted by forexmoments

Do you know how to use punctuation?

English is not the important factor here If your into the proper english thing then find your self a forum that is based on that this is for traders not english teachers most here english is not their mother language and most do the best they can to communicate trading questions and Idears that is what this forums about not ENGLISH

Keit
,.,.,.,.,..,.,;'::::..;......,.,.,.,......,,,,,,,! !!!!!!!???????

PS put your dam punctuations were you want them and no my name is not spelled wrong

omelette · #**646** (**permalink**) 04-28-2008, 05:04 PM

Quote:

Originally Posted by cockeyedcowboy

English is not the important factor here If your into the proper english thing then find your self a forum that is based on that this is for traders not english teachers most here english is not their mother language and most do the best they can to communicate trading questions and Idears that is what this forums about not ENGLISH

Keit
,.,.,.,.,..,.,;'::::..;......,.,.,.,......,,,,,,,! !!!!!!!???????

PS put your dam punctuations were you want them and no my name is not spelled wrong

forexmoments is far more concerned about free advertising (his signature link) than punctuation - the vast majority of his posts are vaguely relevant one-liners - employing the minimium of effort, and just relevant enough to slip under the admins radar...

BigBoppa · #**647** (**permalink**) 04-28-2008, 06:36 PM

Quote:

Originally Posted by cockeyedcowboy

... most here english is not their mother language and most do the best they can to communicate trading questions and Idears that is what this forums about not ENGLISH

Don´t you think that especially for non english mother language people it is easier to read if it is correct spelling and punctuation?