Forex
Google

Go Back   Forex Trading > Downloads > Expert Advisors - Metatrader 4
Forex Forum Register FAQ Members List Calendar Search Today's Posts Mark Forums Read


Register in Forex TSD!
Trading Systems Leaders in this forum (automated trading systems) are winning more than 3000 pips in a month (30000$ investing one lot every time).
Click here to register and get more information

Reply
 
LinkBack (11) Thread Tools Display Modes
  #11 (permalink)  
Old 03-24-2006, 05:23 PM
Nicholishen's Avatar
Nicholishen Nicholishen is offline
Senior Member
 
Join Date: Dec 2005
Posts: 531
Nicholishen is on a distinguished road
Quote:
Originally Posted by holyguy7
Yes. That is exactly correct. It is most successful on daily and higher. I am also testing it on the weekly chart and it is successful as well (though does not trade as much).

It also has a problem (bug) that it does not always close orders when it hits its take profit. I was wondering if someone could fix that as when I went up to monitor the results, it would be way over the take profit price and I would have to close manually. It had only happened on a couple currency pairs but I do want if fixed as it could have easily when way higher or started dropping again.

Below is the attached statement so far. It keeps generating money.

The code is correct for setting the take profit with the order. Can you check to see that the TP is set when you first open an order? Then, what level is is that TP set (is it correct)? Please verify that this is where the 'bug' is and if it is sending these TP in with order, the problem is your broker.
__________________
"Anyone who has never made a mistake has never tried anything new." -Albert Einstein
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #12 (permalink)  
Old 03-24-2006, 05:34 PM
Nicholishen's Avatar
Nicholishen Nicholishen is offline
Senior Member
 
Join Date: Dec 2005
Posts: 531
Nicholishen is on a distinguished road
Quote:
Originally Posted by holyguy7
I am currently forward testing a new EA that seems to have some potential. I was hoping that everyone on the board here could help with different settings and perameters and perhaps improve on the EA if possible.

I called the EA, "Profit Generator" because I believe that is what is really could be. It is simple in its rules yet powerful as you can see by the results so far. It was previously called FxAnt and is now renamed to Profit Generator after some slight modifications by Nicholishen and myself.

Let's all improve this EA together and find some good settings for it. Improvements that could make it better:

1. Add in Trailing Stop
2. Add in Money Management
3. Add in Hedging
4. Add in additional filter (to verify)
5. Add in adjustable MagicEA

There are probably other improvements that could be made but I am a bit tired right now. Let's work together to improve this EA as I do believe it has some great potential.
Where would hedging come into play here? What do you propose to use as alt filters?
__________________
"Anyone who has never made a mistake has never tried anything new." -Albert Einstein
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #13 (permalink)  
Old 03-24-2006, 06:11 PM
Nicholishen's Avatar
Nicholishen Nicholishen is offline
Senior Member
 
Join Date: Dec 2005
Posts: 531
Nicholishen is on a distinguished road
...............................................
__________________
"Anyone who has never made a mistake has never tried anything new." -Albert Einstein

Last edited by Nicholishen : 03-27-2006 at 05:45 AM.
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #14 (permalink)  
Old 03-24-2006, 06:23 PM
holyguy7's Avatar
holyguy7 holyguy7 is offline
Senior Member
 
Join Date: Feb 2006
Posts: 443
holyguy7 is on a distinguished road
Quote:
Originally Posted by Nicholishen
The code is correct for setting the take profit with the order. Can you check to see that the TP is set when you first open an order? Then, what level is is that TP set (is it correct)? Please verify that this is where the 'bug' is and if it is sending these TP in with order, the problem is your broker.

I figured out why it did not take the take profit correctly. I believe it skipped past them on fast price movement and does not look back. I had the same thing happen to me on the same computer on a stoploss and it just kept its downward trek to lose money.

I have 7 metatrader 4 versions running at the same time on a slow computer and that could be the reason for the missing trades.
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #15 (permalink)  
Old 03-24-2006, 06:34 PM
holyguy7's Avatar
holyguy7 holyguy7 is offline
Senior Member
 
Join Date: Feb 2006
Posts: 443
holyguy7 is on a distinguished road
Quote:
Originally Posted by Nicholishen
Where would hedging come into play here? What do you propose to use as alt filters?
I am not sure. I was just thinking out loud. Thanks for the improvements. I have been looking at the results and am totally amazed.

Interesting is that after analizing the trades, the only losing currency pairs are the EURUSD and USDCHF. I saw when the trades were executed and I believe that putting the timefilter on those two currency pairs would have solved that problem.

Here are the latest forward testing on the D1 chart. I have added in the presets to all 12 currency pairs that I use. I tend to stay away from currency pairs that either have:

1. Too high of spread (I don't use spreads higher than 5 pips with the exception of the GBPJPY).

2. Are on the same continent with the exception of the USDCAD.

I also like the JPY currency pairs as they tend to move more than the other ones.
Attached Images
File Type: gif Profit Generator.gif (4.8 KB, 606 views)
Attached Files
File Type: htm Profit Generator.htm (20.6 KB, 999 views)
File Type: zip Profit Generator presets.zip (2.3 KB, 788 views)
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #16 (permalink)  
Old 03-24-2006, 06:41 PM
holyguy7's Avatar
holyguy7 holyguy7 is offline
Senior Member
 
Join Date: Feb 2006
Posts: 443
holyguy7 is on a distinguished road
I also am testing this on the Weekly timeframe with some good results so far. It does not trade as much but is more accurate. I had to manually close both trades as it skipped past the TP.

I increased the TP on the weekly timeframes to 100-140 pips as you are basically doing trend trading at this point. I also increased the Stoploss to 40-50.

It seems to be working fairly well but again, too soon to tell on this timeframe it has only traded a few times so far. Someone might want to try the Monthly timeframe to see if they can make a profit on that one too.

This is crazy but it really seems to work this very simple yet powerful EA.

Let's keep testing different timeframes and settings on this one as I think this is the most profitable EA I have ever seen.
Attached Images
File Type: gif Profit Generator Weekly.gif (4.5 KB, 499 views)
Attached Files
File Type: htm Profit Generator Weekly.htm (8.3 KB, 541 views)
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #17 (permalink)  
Old 03-24-2006, 06:42 PM
Maji Maji is offline
Senior Member
 
Join Date: Mar 2006
Posts: 787
Maji is on a distinguished road
Here are my observations on this EA. Please correct me if I am wrong, and I am sure that I will be, at least partly, because I am not an expert in MQ4.

1. This EA works off Bid and Ask Prices. Thus, it sends out orders each time the conditions are met and the number of trades open is less than maxtrades allowable.

2. Suppose we are using daily data. The EA has to check every tick against the daily hi, low and open prices. Change the code to make the hi, low and open be assigned to the daily bar and then we should be able to run it using lower time frame. Anyway, it is going to use the daily data and the bid/ask, so it should not matter.

3. Now if you do 2 above, then you see the results deteriorate, at least did in my case. That I think is because the way MT runs its tests. The bid/ask becomes more accurate in the lower time frames, I think, and the stops are hit faster than profit targets are.

4. In MQ4, the stop and the take profits are sent with the open trade order. Thus, I think the connection speed etc. should not matter. If the stop order is there, then it should be honored. If not, then one should talk to their broker.

Very interesting EA still. Need to be investigated fully

Thanks Holyguy for posting it.

Maji
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #18 (permalink)  
Old 03-24-2006, 06:50 PM
holyguy7's Avatar
holyguy7 holyguy7 is offline
Senior Member
 
Join Date: Feb 2006
Posts: 443
holyguy7 is on a distinguished road
Quote:
Originally Posted by Maji
Very interesting EA still. Need to be investigated fully

Thanks Holyguy for posting it.

Maji
You can thank Nich as he did most of the work on this EA. I just figured out how to make it profitable. I love the fact that it uses NO indicators and is very simple yet powerful.

As I said before, add the timefilter on the major currency pairs: EURUSD, USDCHF and I believe that it can even be more profitable.

I also like the fact that it has a very LOW stoploss (30-40 pips) so that you are not risking much if the trade does not go your way.
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #19 (permalink)  
Old 03-24-2006, 07:02 PM
SPACECHIMP SPACECHIMP is offline
Member
 
Join Date: Feb 2006
Posts: 30
SPACECHIMP is on a distinguished road
i've read this thread but i'm not too clear on exactly how this EA functions..
is there a description of it somewhere?

THANKS!
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #20 (permalink)  
Old 03-24-2006, 07:49 PM
JoZo's Avatar
JoZo JoZo is offline
Senior Member
 
Join Date: Feb 2006
Location: Croatia
Posts: 409
JoZo is on a distinguished road
Thumbs up

Hi,
Really CRAZY Ea

Good job guys!
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Forum Jump

LinkBacks (?)
LinkBack to this Thread: http://www.forex-tsd.com/expert-advisors-metatrader-4/1415-profit-generator-ea.html
Posted By For Type Date
كارگاه اكسپرت Profit Generator - Page 7 - انجمن تخصصی فارکس پارس This thread Refback 02-29-2008 02:27 PM
كارگاه اكسپرت Profit Generator - Page 7 - انجمن تخصصی فارکس پارس This thread Refback 02-29-2008 07:07 AM
expert ها - Page 6 - انجمن تخصصی فارکس پارس This thread Refback 02-14-2008 08:31 AM
expert ها - Page 6 - انجمن تخصصی فارکس پارس This thread Refback 12-02-2007 09:49 AM
- 12 - This thread Refback 08-08-2007 09:03 PM
- This thread Refback 07-19-2007 12:28 PM
Control Panel - Powered by Semipixel.com Technology This thread Refback 07-19-2007 05:30 AM
ASCTrend - 6 - This thread Refback 06-27-2007 12:28 AM
- This thread Refback 06-26-2007 03:59 PM
Profit Generator 333 - IRXFX Forums - Enjoy Pips ! This thread Refback 06-24-2007 03:03 AM
VTTrader: Request Indicator or Trading System for VT Trader. - Page 4 @ Forex Factory This thread Refback 06-22-2007 07:32 PM

Similar Threads
Thread Thread Starter Forum Replies Last Post
forex signal generator paijolopez Analytics 730 07-03-2008 06:36 PM
Generator of filter's indicator for MT4 newdigital Digital Filters 26 05-20-2008 07:54 AM
News Generator mqldev News/Signal Trading 21 03-23-2007 12:52 AM
Profit Generator EA results sadaloma Post and compare Trades 216 05-27-2006 06:24 PM


All times are GMT. The time now is 11:25 PM.