Forex
Google
New signals service!

Go Back   Forex Trading > Downloads > Expert Advisors - Metatrader 4


Register in Forex TSD!
Trading Systems Leaders in this forum (automated trading systems) are winning more than 3000 pips in a month (30000$ investing one lot every time).
Click here to register and get more information

Reply
 
LinkBack (11) Thread Tools Display Modes
  #121 (permalink)  
Old 03-27-2006, 05:50 PM
Nicholishen's Avatar
Senior Member
 
Join Date: Dec 2005
Posts: 531
Nicholishen is on a distinguished road
Quote:
Originally Posted by Maji
Nich,

I think using any kind of indicator is a bad idea. The strength of the system is because it depends on price action and adding any derivatives and degrees of freedom will only degrade the performance.

Just my $0.02.

Maji
KISS-"Keep it simple stupid". I agree with your statement, however JO has a great idea and stochastics on a one minute chart can get you better entry points. For example, we are entering into a long position from 'Price Action'. The final check is to see if (k>d)on M1. If K>D then the order will go through immediately. If not it will wait until it has crossed, and then enter the order. It won't limit the amount of trades; only get better entry points... just my 2 cents
__________________
"Anyone who has never made a mistake has never tried anything new." -Albert Einstein
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #122 (permalink)  
Old 03-27-2006, 06:09 PM
Nicholishen's Avatar
Senior Member
 
Join Date: Dec 2005
Posts: 531
Nicholishen is on a distinguished road
Quote:
Originally Posted by jojolalpin
I don't like to have orders with no SL or no TP and when using superclose(), there is no TP untill Trailing be activated. So I ask why not set an initial takeprofit (before superclose set one) to be secured in case of computercrash. That's why I proposed two times the value of takeprofit variable.

Also to initiate on the test plan, parameters are:

Stoploss: 10 to 30?
Takeprofit: 20 to 100?
TimeFrames: M1 M15 H4 Daily Weekly..
Currencies: 12 from Holyguy7 selection? only those with a little spread (<=5)?

those are just suggestions.
Ok, I see what you mean now. It's fairly easy to do. I use a dedicated server with 100% up time, so i neglect to think about things like that.

And here are some notes on the superclose(). I was hoping to be able to have the ability to track TS prices by the ticket number, so you can set MaxTrades to more than 1 AND be able to trail by less than 10 pips.
PHP Code:
void SuperClose(){
   for(
int i=0;i<OrdersTotal();i++){
      if(
OrderSelect(i,SELECT_BY_POS)){
         if(
OrderSymbol()==Symbol() && OrderMagicNumber()==ID){//Pulls in order that meets the criteria for processing
            
int num=0;int pos=0;
            for(
int b=0;b<21;b++){// this (loopB) compares the ticket# of the selected order against the number stored in the ticket array
               
if(tsTicket[b]==OrderTicket() ){
                  
num++; pos=b;// if ticket numbers match, pos is the position in the array where the trailing data is stored
                  
Print("(",pos,") Ticket ",tsTicket[pos]," found.  SL is ",tsPrice[pos]);
                  break;
               }  
            }
            if(
num==0){ // if the loopB did not find a matching ticket number it is time to initialize the data
               
for(int j=0;j<21;j++){
                  if(
tsTicket[j]==0){// this is looking for the earliest instance within the array to store the data
                     
pos=j;
                     
                     break;
                  }
               }
               
tsTicket[pos]=OrderTicket();// setting the ticket number
               
tsok[pos]=false;// this is to determine when trailing kicks in
               
Print("(",pos,") New ticket initialized = ",tsTicket[pos]);
            }
            if (
OrderType()==OP_SELL) {
               if (!
tsok[pos] && (OrderOpenPrice()-Ask>=TSactivation*Point || TSactivation==) ) {// if the trailing factor is false, but it has hit the activation point continue
                  
tsPrice[pos]=Ask+TrailPips*Point;// this is the new trailinf stop price
                  
tsok[pos]=true;// it's ok to proceed with trailing stop
                  
if(TrailPips>8){// if this distance from the current price to the new stop, then modify the order.
                     
ModifyStopLoss(Ask+TrailPips*Point);//modifies order
                  
}
               }
               if (
tsok[pos] && Ask+TrailPips*Point tsPrice[pos] ){//if the position is gaining in profit
                  
tsPrice[pos]=Ask+TrailPips*Point;
                  if(
TrailPips>8){ 
                     
ModifyStopLoss(Ask+TrailPips*Point);
                  }
               }
               if (
tsok[pos] && Ask >= tsPrice[pos] ){// if the postion hits the stop price
                  
CloseOrder(2);
                  Print(
"Order ",tsTicket[pos]," Closed from TS");
               }
            }
            if (
OrderType()==OP_BUY) {// reverse of SELL
               
if(!tsok[pos] && (Bid-OrderOpenPrice() >= TSactivation*Point  || TSactivation==) ) {
                  
tsPrice[pos]=Bid-TrailPips*Point;
                  
tsok[pos]=true;
                  if(
TrailPips>8){
                     
ModifyStopLoss(Bid-TrailPips*Point);
                  }
               }
               if (
tsok[pos] && Bid-TrailPips*Point tsPrice[pos] ){
                  
tsPrice[pos]=Bid-TrailPips*Point;
                  if(
TrailPips 8){
                     
ModifyStopLoss(Bid-TrailPips*Point);
                  }
               }
               if (
tsok[pos] && Bid <= tsPrice[pos] ){
                  
CloseOrder(1);
                  Print(
"Order ",tsTicket[pos]," Closed from TS");
   }  }  }  }  }
   for(
i=0;i<21;i++){// this searches the array for ticket numbers that are now obsolete due to an order that has closed
      
if(tsTicket[i]>0){
         
bool found=false;
         for(
b=0;b<OrdersTotal();b++){
            
OrderSelect(b,SELECT_BY_POS);
            if(
tsTicket[i]==OrderTicket()){
               
found=true;
             break;
            }
         }
         if(!
found){// if there are matching ticket numbers in the trade pool and the array then nothing happens
            
tsTicket[i]=0;tsPrice[i]=0;tsok[i]=false;// if there is an obolete ticket the the data is reset.  And the next new ticket data can occupy this space
            
Print("Array pos ",i," Cleaned");
}  }  }  } 
__________________
"Anyone who has never made a mistake has never tried anything new." -Albert Einstein

Last edited by Nicholishen; 03-27-2006 at 06:15 PM.
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #123 (permalink)  
Old 03-27-2006, 06:14 PM
jojolalpin's Avatar
Member
 
Join Date: Mar 2006
Posts: 89
jojolalpin is on a distinguished road
Great! Thanks a lot!
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #124 (permalink)  
Old 03-27-2006, 06:17 PM
Member
 
Join Date: Dec 2005
Posts: 37
dazminder is on a distinguished road
Zero Loss,,,,,No Trades

I was hoping to test out Profit Generator 2.4. It has not placed any trades from 630GMT.....Has it been placing anyother trades for anyone. TF15 $/CHT, £/$, Euro/$..


Please let me know, as I think this is a good EA in principal.
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #125 (permalink)  
Old 03-27-2006, 06:21 PM
Nicholishen's Avatar
Senior Member
 
Join Date: Dec 2005
Posts: 531
Nicholishen is on a distinguished road
Here is the EA with change to the TP after UseClose is true. It will double the TP for safety purposes. Thanks Jo!
Attached Files
File Type: mq4 Profit Generator 2.6.3.mq4 (13.1 KB, 328 views)
__________________
"Anyone who has never made a mistake has never tried anything new." -Albert Einstein
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #126 (permalink)  
Old 03-27-2006, 06:22 PM
Nicholishen's Avatar
Senior Member
 
Join Date: Dec 2005
Posts: 531
Nicholishen is on a distinguished road
Quote:
Originally Posted by dazminder
I was hoping to test out Profit Generator 2.4. It has not placed any trades from 630GMT.....Has it been placing anyother trades for anyone. TF15 $/CHT, £/$, Euro/$..


Please let me know, as I think this is a good EA in principal.
You will get less trades because the first criteria is that the present bar has to be greater than the value of LongBar in length. I would recommend a smaller candle on the lower TF.
__________________
"Anyone who has never made a mistake has never tried anything new." -Albert Einstein
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #127 (permalink)  
Old 03-27-2006, 06:22 PM
jojolalpin's Avatar
Member
 
Join Date: Mar 2006
Posts: 89
jojolalpin is on a distinguished road
nothing more since last post about this (gbpusd still loser) but i'm running on H1 and daily and I kept longbar=15.
let's wait this night (overall for jpy pairs)

Last edited by jojolalpin; 03-27-2006 at 06:31 PM.
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #128 (permalink)  
Old 03-27-2006, 07:09 PM
jojolalpin's Avatar
Member
 
Join Date: Mar 2006
Posts: 89
jojolalpin is on a distinguished road
Question

anyone to suggest me testing parameters (SL & TP)?
I will use no hours limit on main currencies and M1, M5, M15, H1 and H4.
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #129 (permalink)  
Old 03-27-2006, 07:55 PM
holyguy7's Avatar
Senior Member
 
Join Date: Feb 2006
Posts: 446
holyguy7 is on a distinguished road
Quote:
Originally Posted by jojolalpin
nothing more since last post about this (gbpusd still loser) but i'm running on H1 and daily and I kept longbar=15.
let's wait this night (overall for jpy pairs)
I have noticed that the GBPUSD seems to work better on the Daily chart:

TP: 40
SL: 30
No Timefilter
Longbar: 10

Just seems more reliable. EURUSD and USDCHF seem to do better on the H1 chart with longbar at 15 and timefliter on.

I am struggling right now as the major currency pairs are giving me fits with this EA. Anybody been successful on the major currency pairs??? If so, please post your findings.
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #130 (permalink)  
Old 03-27-2006, 09:51 PM
Senior Member
 
Join Date: Jan 2006
Posts: 153
kumawat is on a distinguished road
Hi

HolyGUY,

What is the progress today on this new EA
Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply

Bookmarks

Tags
profit generator 333, profit generator EA, forex

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are Off
Forum Jump

LinkBacks (?)
LinkBack to this Thread: http://www.forex-tsd.com/expert-advisors-metatrader-4/1415-profit-generator-ea.html
Posted By For Type Date
ظƒط§ط±ع¯ط§ظ‡ ط§ظƒط³ظ¾ط±طھ Profit Generator - Page 7 - ط§ظ†ط¬ظ…ظ† طھط®طµطµغŒ ظپط§ط±ع©ط³ ظ¾ط§ط±ط³ This thread Refback 02-29-2008 02:27 PM
ظƒط§ط±ع¯ط§ظ‡ ط§ظƒط³ظ¾ط±طھ Profit Generator - Page 7 - ط§ظ†ط¬ظ…ظ† طھط®طµطµغŒ ظپط§ط±ع©ط³ ظ¾ط§ط±ط³ This thread Refback 02-29-2008 07:07 AM
expert ظ‡ط§ - Page 6 - ط§ظ†ط¬ظ…ظ† طھط®طµطµغŒ ظپط§ط±ع©ط³ ظ¾ط§ط±ط³ This thread Refback 02-14-2008 08:31 AM
expert ظ‡ط§ - Page 6 - ط§ظ†ط¬ظ…ظ† طھط®طµطµغŒ ظپط§ط±ع©ط³ ظ¾ط§ط±ط³ This thread Refback 12-02-2007 09:49 AM
حقل تجارب الاكسبرتات - الصفحة 12 - منتديات المتداول العربي This thread Refback 08-08-2007 09:03 PM
اكسبرت عجيب - منتديات المركز الخليجي This thread Refback 07-19-2007 12:28 PM
Control Panel - Powered by Semipixel.com Technology This thread Refback 07-19-2007 05:30 AM
مؤشر يعطي بيع وشراء على جميع الفريمات ASCTrend - الصفحة 6 - منتديات المركز الخليجي This thread Refback 06-27-2007 12:28 AM
اكسبرت عجيب - منتديات المتداول العربي This thread Refback 06-26-2007 03:59 PM
Profit Generator 333 - IRXFX Forums - Enjoy Pips ! This thread Refback 06-24-2007 03:03 AM
VTTrader: Request Indicator or Trading System for VT Trader. - Page 4 @ Forex Factory This thread Refback 06-22-2007 07:32 PM

Similar Threads
Thread Thread Starter Forum Replies Last Post