Thread: MQL4 Learning
View Single Post
  #165 (permalink)  
Old 08-02-2007, 05:04 AM
flexie flexie is offline
Member
 
Join Date: Feb 2006
Posts: 35
flexie is on a distinguished road
Quote:
Originally Posted by iscuba11 View Post
envtop_cur0=iEnvelopes(NULL,0,30,0,5,0,-0.04,2,0);//TopBand


envbottom_cur0=iEnvelopes(NULL,0,30,0,5,0,0.04,1,0 );//BottomBand


Something is not right with above - Can someone spot and fix this code??

Dave
<><<<

Much thanks in advance!!
A suggestion from a seasoned coder ... try to get in the habit of using words for your variables rather than numbers. I think you will find the errors become easier to find. Also, you need to be a bit more specific in the context of how it's being used for us to spot problems.

So, some concerns I see:
1) do you want the shift as 5 or applied price to be 5? I am assuming you want the price to be 5 = PRICE_TYPICAL.
2) you have the modes reversed. MODE_UPPER = 1, MODE_LOWER = 2.
3) you are forcing the shift to 0, which is the current bar only. Not sure if this is what you want, but for an indicator that draws lines it needs to be a variable. An EA is ok with a 0.

Mark
Reply With Quote